From: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
To: Shuvam Pandey <shuvampandey1@gmail.com>,
Carl Vanderlip <carl.vanderlip@oss.qualcomm.com>,
Oded Gabbay <ogabbay@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] accel/qaic: Protect perf stats BO state with bo->lock
Date: Tue, 13 Oct 2026 12:56:14 -0600 [thread overview]
Message-ID: <e6a86bf0-86bd-4010-9d95-5b87bb2a3009@oss.qualcomm.com> (raw)
In-Reply-To: <6a115824.a0bed9bd.3c0137.9edf@mx.google.com>
On 5/23/2026 1:32 AM, Shuvam Pandey wrote:
> qaic_perf_stats_bo_ioctl() validates each BO by checking bo->sliced and
> bo->dbc before returning its perf stats. These fields are changed by the
> detach paths while holding bo->lock, but the perf stats ioctl reads them
> without that lock.
>
> A concurrent detach can clear bo->dbc and mark the BO unsliced while the
> perf stats ioctl is validating the BO. Take bo->lock while checking the
> BO state and copying the per-BO stats into the temporary result buffer.
>
> Fixes: 4ddf4ddfceb4 ("accel/qaic: Ensure entry belongs to DBC in qaic_perf_stats_bo_ioctl()")
> Signed-off-by: Shuvam Pandey <shuvampandey1@gmail.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Pushed to drm-misc-next.
-Jeff
prev parent reply other threads:[~2026-10-13 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 7:32 Shuvam Pandey
2026-10-13 18:56 ` Jeff Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6a86bf0-86bd-4010-9d95-5b87bb2a3009@oss.qualcomm.com \
--to=jeff.hugo@oss.qualcomm.com \
--cc=carl.vanderlip@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=shuvampandey1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®