From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] ASoC: qcom: qdsp6: lpass-ports: add support for QAIF AIF MI2S and TDM dais
Date: Fri, 18 Sep 2026 21:50:11 +0100 [thread overview]
Message-ID: <e6adda57-a2af-4a64-942e-456896ed1ac3@oss.qualcomm.com> (raw)
In-Reply-To: <20260918-qaif_dai_id_support-v1-2-ed863c0e5e45@oss.qualcomm.com>
On 9/18/26 2:31 PM, Mohammad Rafi Shaik wrote:
> Add support for Qualcomm Audio Interface (QAIF) AIF MI2S and TDM dais in
> the dai-driver, these dais are used in Shikra, Hawi and Nord based
> Qualcomm platform devices.
>
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---
Lgtm,
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 ++
> sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c | 54 ++++++++++++++++++++++++++++++++
> 2 files changed, 56 insertions(+)
>
> diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> index e204fd59e512..83f2711bceea 100644
> --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
> @@ -386,6 +386,7 @@ static int q6tdm_set_tdm_slot(struct snd_soc_dai *dai,
>
> switch (dai->id) {
> case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7:
> + case AIF_TDM_RX_0 ... AIF_TDM_TX_12:
> slot_mask = (dai->id & 0x1) ? tx_mask : rx_mask;
> if (slot_mask & ~cap_mask) {
> dev_err(dai->dev, "%s: invalid slot mask 0x%x for %d slots\n",
> @@ -474,6 +475,7 @@ static int of_q6apm_parse_dai_data(struct device *dev,
> case QUINARY_MI2S_RX ... QUINARY_MI2S_TX:
> case SENARY_MI2S_RX ... SENARY_MI2S_TX:
> case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7:
> + case AIF_MI2S_RX_0 ... AIF_TDM_TX_12:
> priv = &data->priv[id];
> priv->mclk = of_clk_get_by_name(node, "mclk");
> if (IS_ERR(priv->mclk)) {
> diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> index c3d8116ad503..f422346a50c6 100644
> --- a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> +++ b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> @@ -548,6 +548,32 @@ static struct snd_soc_dai_driver q6dsp_audio_fe_dais[] = {
> .id = SENARY_MI2S_TX,
> .name = "SEN_MI2S_TX",
> },
> + Q6AFE_MI2S_RX_DAI("AIF RX0", AIF_MI2S_RX_0),
> + Q6AFE_MI2S_RX_DAI("AIF RX1", AIF_MI2S_RX_1),
> + Q6AFE_MI2S_RX_DAI("AIF RX2", AIF_MI2S_RX_2),
> + Q6AFE_MI2S_RX_DAI("AIF RX3", AIF_MI2S_RX_3),
> + Q6AFE_MI2S_RX_DAI("AIF RX4", AIF_MI2S_RX_4),
> + Q6AFE_MI2S_RX_DAI("AIF RX5", AIF_MI2S_RX_5),
> + Q6AFE_MI2S_RX_DAI("AIF RX6", AIF_MI2S_RX_6),
> + Q6AFE_MI2S_RX_DAI("AIF RX7", AIF_MI2S_RX_7),
> + Q6AFE_MI2S_RX_DAI("AIF RX8", AIF_MI2S_RX_8),
> + Q6AFE_MI2S_RX_DAI("AIF RX9", AIF_MI2S_RX_9),
> + Q6AFE_MI2S_RX_DAI("AIF RX10", AIF_MI2S_RX_10),
> + Q6AFE_MI2S_RX_DAI("AIF RX11", AIF_MI2S_RX_11),
> + Q6AFE_MI2S_RX_DAI("AIF RX12", AIF_MI2S_RX_12),
> + Q6AFE_MI2S_TX_DAI("AIF TX0", AIF_MI2S_TX_0),
> + Q6AFE_MI2S_TX_DAI("AIF TX1", AIF_MI2S_TX_1),
> + Q6AFE_MI2S_TX_DAI("AIF TX2", AIF_MI2S_TX_2),
> + Q6AFE_MI2S_TX_DAI("AIF TX3", AIF_MI2S_TX_3),
> + Q6AFE_MI2S_TX_DAI("AIF TX4", AIF_MI2S_TX_4),
> + Q6AFE_MI2S_TX_DAI("AIF TX5", AIF_MI2S_TX_5),
> + Q6AFE_MI2S_TX_DAI("AIF TX6", AIF_MI2S_TX_6),
> + Q6AFE_MI2S_TX_DAI("AIF TX7", AIF_MI2S_TX_7),
> + Q6AFE_MI2S_TX_DAI("AIF TX8", AIF_MI2S_TX_8),
> + Q6AFE_MI2S_TX_DAI("AIF TX9", AIF_MI2S_TX_9),
> + Q6AFE_MI2S_TX_DAI("AIF TX10", AIF_MI2S_TX_10),
> + Q6AFE_MI2S_TX_DAI("AIF TX11", AIF_MI2S_TX_11),
> + Q6AFE_MI2S_TX_DAI("AIF TX12", AIF_MI2S_TX_12),
> Q6AFE_MI2S_RX_DAI("LPI RX0", LPI_MI2S_RX_0),
> Q6AFE_MI2S_RX_DAI("LPI RX1", LPI_MI2S_RX_1),
> Q6AFE_MI2S_RX_DAI("LPI RX2", LPI_MI2S_RX_2),
> @@ -562,6 +588,32 @@ static struct snd_soc_dai_driver q6dsp_audio_fe_dais[] = {
> Q6AFE_MI2S_TX_DAI("LPI TX4", LPI_MI2S_TX_4),
> Q6AFE_MI2S_TX_DAI("LPI TX5", LPI_MI2S_TX_5),
> Q6AFE_MI2S_TX_DAI("LPI TX6", LPI_MI2S_TX_6),
> + Q6AFE_TDM_PB_DAI("AIF RX0", 0, AIF_TDM_RX_0),
> + Q6AFE_TDM_PB_DAI("AIF RX1", 1, AIF_TDM_RX_1),
> + Q6AFE_TDM_PB_DAI("AIF RX2", 2, AIF_TDM_RX_2),
> + Q6AFE_TDM_PB_DAI("AIF RX3", 3, AIF_TDM_RX_3),
> + Q6AFE_TDM_PB_DAI("AIF RX4", 4, AIF_TDM_RX_4),
> + Q6AFE_TDM_PB_DAI("AIF RX5", 5, AIF_TDM_RX_5),
> + Q6AFE_TDM_PB_DAI("AIF RX6", 6, AIF_TDM_RX_6),
> + Q6AFE_TDM_PB_DAI("AIF RX7", 7, AIF_TDM_RX_7),
> + Q6AFE_TDM_PB_DAI("AIF RX8", 8, AIF_TDM_RX_8),
> + Q6AFE_TDM_PB_DAI("AIF RX9", 9, AIF_TDM_RX_9),
> + Q6AFE_TDM_PB_DAI("AIF RX10", 10, AIF_TDM_RX_10),
> + Q6AFE_TDM_PB_DAI("AIF RX11", 11, AIF_TDM_RX_11),
> + Q6AFE_TDM_PB_DAI("AIF RX12", 12, AIF_TDM_RX_12),
> + Q6AFE_TDM_CAP_DAI("AIF TX0", 0, AIF_TDM_TX_0),
> + Q6AFE_TDM_CAP_DAI("AIF TX1", 1, AIF_TDM_TX_1),
> + Q6AFE_TDM_CAP_DAI("AIF TX2", 2, AIF_TDM_TX_2),
> + Q6AFE_TDM_CAP_DAI("AIF TX3", 3, AIF_TDM_TX_3),
> + Q6AFE_TDM_CAP_DAI("AIF TX4", 4, AIF_TDM_TX_4),
> + Q6AFE_TDM_CAP_DAI("AIF TX5", 5, AIF_TDM_TX_5),
> + Q6AFE_TDM_CAP_DAI("AIF TX6", 6, AIF_TDM_TX_6),
> + Q6AFE_TDM_CAP_DAI("AIF TX7", 7, AIF_TDM_TX_7),
> + Q6AFE_TDM_CAP_DAI("AIF TX8", 8, AIF_TDM_TX_8),
> + Q6AFE_TDM_CAP_DAI("AIF TX9", 9, AIF_TDM_TX_9),
> + Q6AFE_TDM_CAP_DAI("AIF TX10", 10, AIF_TDM_TX_10),
> + Q6AFE_TDM_CAP_DAI("AIF TX11", 11, AIF_TDM_TX_11),
> + Q6AFE_TDM_CAP_DAI("AIF TX12", 12, AIF_TDM_TX_12),
> Q6AFE_TDM_PB_DAI("Primary", 0, PRIMARY_TDM_RX_0),
> Q6AFE_TDM_PB_DAI("Primary", 1, PRIMARY_TDM_RX_1),
> Q6AFE_TDM_PB_DAI("Primary", 2, PRIMARY_TDM_RX_2),
> @@ -717,9 +769,11 @@ struct snd_soc_dai_driver *q6dsp_audio_ports_set_config(struct device *dev,
> case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX:
> case LPI_MI2S_RX_0 ... LPI_MI2S_TX_4:
> case LPI_MI2S_RX_5 ... LPI_MI2S_TX_6:
> + case AIF_MI2S_RX_0 ... AIF_MI2S_TX_12:
> q6dsp_audio_fe_dais[i].ops = cfg->q6i2s_ops;
> break;
> case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7:
> + case AIF_TDM_RX_0 ... AIF_TDM_TX_12:
> q6dsp_audio_fe_dais[i].ops = cfg->q6tdm_ops;
> break;
> case WSA_CODEC_DMA_RX_0 ... RX_CODEC_DMA_RX_7:
>
next prev parent reply other threads:[~2026-09-18 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:31 [PATCH 0/3] ASoC: qcom: Add QAIF AIF MI2S and TDM DAI support Mohammad Rafi Shaik
2026-09-18 13:31 ` [PATCH v1 1/3] ASoC: dt-bindings: qcom: add QAIF AIF MI2S and TDM dai ids Mohammad Rafi Shaik
2026-09-18 13:31 ` [PATCH v1 2/3] ASoC: qcom: qdsp6: lpass-ports: add support for QAIF AIF MI2S and TDM dais Mohammad Rafi Shaik
2026-09-18 20:50 ` Srinivas Kandagatla [this message]
2026-09-18 13:31 ` [PATCH v1 3/3] ASoC: qcom: sc8280xp: Handle AIF MI2S and TDM interfaces Mohammad Rafi Shaik
2026-09-18 21:00 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6adda57-a2af-4a64-942e-456896ed1ac3@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®