From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 062D7292B54 for ; Tue, 25 Nov 2025 06:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764052680; cv=none; b=ZE1VqH5thOO0x/Jw7VeuNq/XVcVOz3Lo0jiqKitGsh73RaMNqtUhkxyfL0mUZTQYpwY8A7u38BBJ6eaYIjMLJoqgnhifEVN3HFz83OUj2/2prmJMmuS4XNRQ7izHadoNqbFL3EhTcQ1x6PipjYx35j0c2AZ78gAvgxL18FkJ4GM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764052680; c=relaxed/simple; bh=rWLERcFF2SbpU1nSKdtBfJAGJKT+za0aFJS7Vfsi9eU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ANJtJSLk6ncU5n2BXpZTFdSId/fispxWkZ9aoBtWvM6rg3g1w6ZMKh420wPEib0s0wdFm/bjeDKtrY4E3HKiKNKxWvWStc/3ypEuohIhJ7xwx57VEnuwsqPHE+iPI/CqHfKbF+gvn4K3mUkeHt2WZWUDvxZOQG+8w0uyEOOfW50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oiCWSWb8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZbhoQIqK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oiCWSWb8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZbhoQIqK" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AP2hesG2010532 for ; Tue, 25 Nov 2025 06:37:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ErqSuJhmVOAQ6Obb00NbJWCGaUXkzOxerh/e1fs0cE4=; b=oiCWSWb8VF2dOwPO mR1QLGw3v/dqeQ3Dl+rEGA7UD/jL1l9LVyR/HRPsGmFz1e6vC4rK/rfcW3JsInQx ZIo0BndnpiWoQcZbRRxtxQKk2dkrq7Y+KKn5a/Y1MHUmodi96/lcdrp7D1Jh49q7 cfAqpKadKK99k2siT4fvSftV/4Kn9WTTz2ZJ+OmrboKa3bl4ApQT6VX0k4prDUx2 0UBQByU0Wj7ZfOGON0CGa4h9/jbewy1P0pC70Yig//u649OyzQmRbjb4GB8cOZd3 8cdQ7bDX43BpoeBZOH/xXvF+DK/p8c1v1AL8omMTQL+Q9cw2G65X+Z3XaPd0J2Za ag1ugQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amkknugt0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Nov 2025 06:37:57 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee21a0d326so91388181cf.3 for ; Mon, 24 Nov 2025 22:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764052677; x=1764657477; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ErqSuJhmVOAQ6Obb00NbJWCGaUXkzOxerh/e1fs0cE4=; b=ZbhoQIqK/ZiPHXOipq8oK6GWzZXZHMn0s5Y4wvjagJZYWjkkgzj2LBy8dvrcs7O8ZD VJoNwyeKOL+EwE25HbvjAPtmMWGgkAdt/+JoGiD0a6whIaAfR/qRD/ptaUnWvfz0wj1B jHUXG9VI7Nd7kbkA2ngCsn6lffFR4wdVAkg9jtwVVh4DMugYhpMyE0W6DDEbfyKRByoa VjR6CDTXfwqK564cgAdwdabPy581bMnnjzwbn6EFS/DPKc58sZd2b0CemdAXJXHDkikn 5ZStQMYPzH5X4GwsaTPcWk2UG0v7Cd9nhdDiBEp5PUAec8Ie7eUVRZSOrLr+nlKevpBY DM+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764052677; x=1764657477; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ErqSuJhmVOAQ6Obb00NbJWCGaUXkzOxerh/e1fs0cE4=; b=qxyGaYB93uemd3wnwoQmJJG+AweNEiapDtHHZAxbrbiLVsrxe8dNBAjJtI3letHVfs hZrdfSg9xq9osiYOpyvdnckXHlSoYbiDf9ziyQUSzGhhUbPxgZW2o/UjmXqNGje1Zn5L zkHDSZtegX1/bb45Nmreisd7JJjem5lxoaIScR+nxMNqLpc3FF3aO6t2bYdsX6E/7DYT aguJaRMmtKf3ddIMSWRfsSUYHKHUa14gbZCae4XqoLzpQNfTcSUvx09aPsip15EpVhSl NT7dJWi77Mk4VZ62hqGaMN3ZbBzIt3XgndoFdPB3iIYRet//rFOgJMBLjtfmCPMtfbsI Rs/g== X-Forwarded-Encrypted: i=1; AJvYcCWn9fiVdI9oZNRrxiNaa+rlo7lpcw3tdTVABdtJBCfoBJluH6tI79q8F+oq1om10FJEw6LfBz/ne2PhTFA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+iZQuIJv9i/Fmp1XWXwG2+WGMzc4J33Rni2qj7piw/mEeUCHY ugnWn+4Dbwq0tsmhwLqqTh31VwXKuziqA83P+W9l/aGBNw6rLb9C0j9GKlO8FO/KxA622G2r4xi kDx0eMRotutWQNWACHu/1QaLCvpmeR3e951nZNjO2/uhojee43tT20NIE+ZVXWwhOX2k= X-Gm-Gg: ASbGncsrE7rM+DNCUJxPNB+tIm8j8w7Ca7thzgbiWOgLYHOK6f2omvVtRHV4yHHJ8EE iAI+eNSWRMWiffq5qXHMbrUpgN52Vh/UDLbrDWzbQG51EGwA6sFviQS1jJ9qUq4RiTVbMn7RrQC EwUO3jt4tboqyJt4CaCEiIuvrTs6IxPRn2MOz7Kakbch/8PdYhTSpSWBYZwpPvAfrAeHoov6U3s D6N0uT791gf3INo91pniaDYj+D2JX5mXDGq62qVcrI6VUt0ftw8ITJRN+h+p/vpCxNnuEXF52ok jkC6RCiYphI6UNyF0v6ZqJw62bRey7zH+poOci4DZPAind5X+WJPE6nfki1IOUtP4jWuohJvnjT ga4ku2ZvjCYE1gImqwaEVaGHDmKoUKoWkGA== X-Received: by 2002:a05:622a:148c:b0:4ed:67bc:50de with SMTP id d75a77b69052e-4ee5885402bmr185785561cf.24.1764052677004; Mon, 24 Nov 2025 22:37:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3IEAKR3Cy+9eYJq5upmyvN0y0HD6s2YnTjLvISf6qEEcoow8UYxypFBvz2esF8/bKVX5elg== X-Received: by 2002:a05:622a:148c:b0:4ed:67bc:50de with SMTP id d75a77b69052e-4ee5885402bmr185785451cf.24.1764052676589; Mon, 24 Nov 2025 22:37:56 -0800 (PST) Received: from [10.64.68.30] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ee48b45ccesm100522231cf.0.2025.11.24.22.37.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 22:37:56 -0800 (PST) Message-ID: Date: Tue, 25 Nov 2025 14:37:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/38] drm/msm/dp: remove cached drm_edid from panel To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-1-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: zkJfL6Pv7v_-vnfw0gzOTTXNqnYySWii X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI1MDA1MyBTYWx0ZWRfXx75Qx8eUVq/O XVz3O7siESDxzMtuBuI3GTQDfCxYQhzekuG80/7M2QPMCOsglrl3Y9o+RhqWO/eH6tUa/lQa3FA hcC8WPeeAXfpzmBr1gF1U8wWANgELZr0l0qhskql9YluWBXyBcG1OlT047QlGniLkjBcPUy+SBs ds+N8IVQnWrWeJxv+FLhNxjcdgvFGuXU8pfp3QKJTIk9wj/a2KQGEq+FYgavV5Y4VMqS+ytVgf4 JvuANIoy0sleXyp83N/1uD0J0YYf+Ox+kCFS/wk4gnt3vjzQ48opo7j/+T28H0D0hRgUnA2pwXp 0Da4GnfR7ZsdwWAymIG+GH+vBq1viuIPxVOqGk0xBDBohfakCB2Ltb1/WW6LdBER3Yhc0tXyR62 /koTBl5X9KE13M4L/iyxzUfgD8i9iA== X-Proofpoint-GUID: zkJfL6Pv7v_-vnfw0gzOTTXNqnYySWii X-Authority-Analysis: v=2.4 cv=B8S0EetM c=1 sm=1 tr=0 ts=69254ec5 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=UzQ1Ta3AV69qgWW9qvUA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_01,2025-11-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511250053 On 8/26/2025 12:41 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:15:47PM +0800, Yongxing Mou wrote: >> The cached drm_edid in msm_dp_panel was redundant and led to unnecessary >> state management complexity. This change removes the drm_edid member from > > Please see Documentation/process/submitting-patches.rst on how to write > commit messages. Please use imperative language instead of describing > the changes. > > THe patch LGTM. > How about this: "The cached drm_edid seems unnecessary here. Use the drm_edid pointer directly in the plug stage instead of caching it. Remove the cached drm_edid and the corresponding oneliner to simplify the code." >> the panel structure and refactors related functions to use locally read >> EDID data instead. >> >> - Replaces msm_dp_panel_read_sink_caps() with msm_dp_panel_read_link_caps() >> - Updates msm_dp_panel_handle_sink_request() to accept drm_edid as input >> - Removes msm_dp_panel_get_modes() and drm_edid caching logic >> - Cleans up unused drm_edid_free() calls >> >> This simplifies EDID handling and avoids stale data issues. >> >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 28 +++++++++++++++------- >> drivers/gpu/drm/msm/dp/dp_panel.c | 47 ++++--------------------------------- >> drivers/gpu/drm/msm/dp/dp_panel.h | 9 +++---- >> 3 files changed, 26 insertions(+), 58 deletions(-) >> >