Re: [PATCH] arm64: defconfig: enable further Rockchip platform drivers

["Nícolas F. R. A. Prado" <nfraprado@collabora.com>]

On Thu, 2025-06-26 at 17:16 +0200, Nicolas Frattaroli wrote:
> The RK3588 SoC, and its sibling, the RK3588S, are supported by
> mainline
> Linux. However, some of its SoC drivers are currently not enabled in
> the
> arm64 defconfig.
> 
> Enable rockchip-dfi, rockchip-rga, and the Rockchip specific
> extensions
> to Hantro as modules.

Personally I don't think the first paragraph adds much, so I'd drop it.
 
Also I feel like you're missing the most important information here,
which is what these modules are used for, so I'd focus on that eg
"Enable configs for rockchip-dfi, rga, hantro, etc. This enables
monitoring of DDR load, usage of the hardware codecs, etc"

> 
> These drivers are also used on other Rockchip SoCs that mainline
> supports, notably RK3566/RK3568, as well as RK3399.
> 
> Suggested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig
> b/arch/arm64/configs/defconfig
> index
> e071f8f45607dbfd8e00b915b27999949ee0fc88..8b5ecb20ed6450faa0da14a6fdb
> 4cb227a1f735f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1789,3 +1789,6 @@ CONFIG_CORESIGHT_STM=m
>  CONFIG_CORESIGHT_CPU_DEBUG=m
>  CONFIG_CORESIGHT_CTI=m
>  CONFIG_MEMTEST=y
> +CONFIG_DEVFREQ_EVENT_ROCKCHIP_DFI=m
> +CONFIG_VIDEO_ROCKCHIP_RGA=m
> +CONFIG_VIDEO_HANTRO_ROCKCHIP=m

You should run make savedefconfig and commit the configs from the
generated defconfig so they're in the right place in the defconfig,
rather than just appending them to end like this.

-- 
Thanks,

Nícolas