From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9987A1A0721 for ; Mon, 23 Dec 2024 12:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734955747; cv=none; b=CJUJEkSaAlg2/u8EKcpuVx8INGD4scV6HlGf41xdWVX+MH6Pm8DUugsh/QV4vU13JJyZvpI2k0cnU/DnfBIWtqqr2kSIx7/rQ4nQLDWiKpocuqzHIvRTB603jVwzaLDvz0XpOf1ijc1L/dyqRNjd5Z31A1QEmwuqP9xmCPWeIyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734955747; c=relaxed/simple; bh=PWuxP0waSQYUPxwhiiAvg16IX/P1n90ONOkhHSXMCoE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EQeA/+o3XIOXwZwrG4L9EXVYP5hfHpkeSoPv5IJP5GJGGm3Q+yOlN0Bpvg/0BidLVeVIkUOCJiuZx/2wDCO7ZhX+cv80klNL+FbN5bH7pCk6TH1kLbgbJFD1/lYqavKeipWslm1bW8CzYwDw7EKIli/fkiev3/6FIFq5IEUvaTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P4ukVUVM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P4ukVUVM" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BN9TZd0016836 for ; Mon, 23 Dec 2024 12:09:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JIqQZWLugXMrbtd+Pv4u/UkQJRgRYN19wBd0if9gpuc=; b=P4ukVUVM4rjhxZ6t QV3r6behOX15JyCas3OnGOialfA9YaLDljXH2JcB2Sgx/mp5fd23itH5NeFnF9bA 4K0AiX98izx5gA3X/c5BL6NcJxQ+NMX+QexH7mk+TrOOGb+iAOOobS46aezAgNhw dXY1VxmiUwzKmP6lHMQNdQpn80XCYjwJOF4aEFy143nLJ6oHCx8CKi82V/6IwNCS 8EQu55doEHTXiQ/Aj7jfIYR91U3ClGTHp0xREbDg0RBQbdJR0qmCcfvp8/vwHQVw +Nw+/xvo0laYxScT223yOy1HivHNx5Qy2TklDupzh8P6BhgqK7UbdqGoOQRC/t4o oH+6Lg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43nmp5gwyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 23 Dec 2024 12:09:04 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-467a0d7fb9fso11935751cf.2 for ; Mon, 23 Dec 2024 04:09:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734955744; x=1735560544; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JIqQZWLugXMrbtd+Pv4u/UkQJRgRYN19wBd0if9gpuc=; b=f6tyJ0m5hKKqgdjGXSsnMjxW2CnYnpsq/fKW5VVOgO6cIFVEZA8NXwA8k2nYd0SXm3 e5dlcLQqBADmg08NJHcB8+JhYm3pbOF2nWUsQ5w+++58dXcDMHNQBCXEMc3ycyX55qny y4U4gGGd4RzrmpVv2M7tRiMwMi3VV2UWEioGQTzLUHKNx021TaUAkCsgH2cJmzGU+494 Srr7TP3EGrj9oyzo2ZmYGVnsfZpxMOS/QO2NmVukVKA+K0G5EhbxvOuo4JzqysUPDQ1F qUPPvJY0qV7DuvGt9Xtdhg7WIA0rNRRjTtIWNWslg+CVr+uiDkSW0gO1y7dChzavUzOM DLSQ== X-Forwarded-Encrypted: i=1; AJvYcCU5EjcfVB21KD+z6/dfKzmBOTzJPZKL+jvxq3J13eCSmbCI+rvfl32Vqpq9C6TnsPl2nJNMUNGnUbdw8s8=@vger.kernel.org X-Gm-Message-State: AOJu0YwgKBGwNDFX9vFnGPStkcnJQboRFYo2DQJkvgeoo7xlQnUQiaet decfwfJsKjBWdWupMJi9wQwpXu10IW4fN5Vm7kh7Y3sEjqOGWFvKnwaMIWpl3WScrDQR3oVQXQi hneKD9u44qrCIQEkJXxdVfDXqi00AFD+OTL8szxr1tb+rop1EoaWHPI/C++Eu9zY= X-Gm-Gg: ASbGnct6WaUF8An5oh+uqp2XcPOnAWDVvxZ+qbltHvN8xTfNDU7dpuMAvnZAeiBmQJJ /rP4MFnvEnMqXA92IheC+A0VAbL4hWd/gecQpMXrRss6mEyW98zaH1K+KMYy5x4bCImnID1UTIx CPW9zpxKCzvzBQ7n2/uCKNpz8xUxDW6AU/oHeyzMDcKbM22AMtmAhK1UA/lAbFeZp7ccuBmlBh5 +ifE9izYuKO3fOWuKqOtk7Jvz502c8SZfm8G3mZp6HxAlGRAicmlWtbNfuS+opCr6pr1Efa90pY 7H0BEwfwpVe0f0xw1XgNXUfawA1MKbg/PII= X-Received: by 2002:a05:622a:449:b0:467:79fc:b009 with SMTP id d75a77b69052e-46a4a9709c3mr72961531cf.11.1734955743455; Mon, 23 Dec 2024 04:09:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKxC+1tQNCBB99OwH/BNWtDZdrZOkZJjM7RnPRfHbzGHUdI6Li6KnV1PY3BSEGZakTMhxcEw== X-Received: by 2002:a05:622a:449:b0:467:79fc:b009 with SMTP id d75a77b69052e-46a4a9709c3mr72961371cf.11.1734955743095; Mon, 23 Dec 2024 04:09:03 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d806fed752sm5028772a12.54.2024.12.23.04.09.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2024 04:09:02 -0800 (PST) Message-ID: Date: Mon, 23 Dec 2024 13:09:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: dts: qcom: qcs8300: Add coresight nodes To: Jie Gan , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241219024208.3462358-1-quic_jiegan@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241219024208.3462358-1-quic_jiegan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: j2ZcGYvOQGexNHyGblWzgSdcF1lmc8n1 X-Proofpoint-ORIG-GUID: j2ZcGYvOQGexNHyGblWzgSdcF1lmc8n1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 mlxlogscore=900 mlxscore=0 adultscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412230109 On 19.12.2024 3:42 AM, Jie Gan wrote: > Add following coresight components for QCS8300 platform. > It includes CTI, dummy sink, dynamic Funnel, Replicator, STM, > TPDM, TPDA and TMC ETF. > > Signed-off-by: Jie Gan > --- So I took a look at a bunch of reg values in this patch and the computer tells me they're bound to names similar to the compatible strings (good). This patch is unreviewably long, but at the same time it's made of very repetitive bits. I'm trusting you that you tested out all of these coresight components. I scrolled through a chunk of this, and syntactically it looks good, Rob's bot doesn't seem to complain either, so FWIW: Acked-by: Konrad Dybcio Konrad