From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14CC3339847 for ; Tue, 25 Aug 2026 17:03:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787677412; cv=none; b=Zv59lQn0SiMoCjIFXH+EYImq7932G/Khi56obu9WuiWpPOlqPfeiC+BGvqn+XqooPdgWVNrOYxQI/gLGwYHLa1LhsY8ml7g8/2bfr8Ng+nnpeQQkPQTOZKB0EJWJvd9OTe8x/jbsjeXxduE0nE5EFLOLeg8X+juQpdrW3vKefDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787677412; c=relaxed/simple; bh=6VxzQcU5gwUAm1OIoWROcDPRf8VEitMFSmwvuiGiFwI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rg8DffrRPwazOiKdg8x8355u/wj6VNF9jitkwHmVfF2fP+U1hxRXxBh9plMimycSdwGrXbbJfe/OTH7VefVAD0L+nlv4UqSNtOajoXZOcZ6DQ3uuV1+pL4+4xEpHPzdNorSgWOEHgCKJQOWu+LAhCnuqLJN4FFihr+xgH2tbUAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com; spf=none smtp.mailfrom=mojatatu.com; dkim=pass (1024-bit key) header.d=mojatatu.com header.i=@mojatatu.com header.b=Gvr3UsLX; arc=none smtp.client-ip=209.85.222.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mojatatu.com header.i=@mojatatu.com header.b="Gvr3UsLX" Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-97cb310ae18so23429241.0 for ; Tue, 25 Aug 2026 10:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1787677410; x=1788282210; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Kt1KRjRDTEuJqQ5xwc6xT/XfBUPuShim2DbNeahPWIo=; b=Gvr3UsLXiENM0u+QD+lMmZZBvLEQDrQdsyaOj3gHVubEIAssteL5CK84k3JuDdCv6o ABloTfoPW6GXLR9alw71MxqPQVL/iLfjMctPvEsoKTdmZ6bqC4GLbVcULpexUFN4t271 GXhD2gCmgEcf5XO+mWZM9SFZ7THqqlufp2oz4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787677410; x=1788282210; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Kt1KRjRDTEuJqQ5xwc6xT/XfBUPuShim2DbNeahPWIo=; b=ATT3T4lcoHgY+AwnmOz+vkZ+GOoyBAGVo4P08/nGoMsTa/sUdRDAQl27hNuBlXpbXp WBxCHLBu+KhW1FWeJaHWZdD2AA8hy18v/X88UOrIY1FuG8qAmuo6b1qxrN4jlQ/NTEwX caWTgofwcgxoK1zt+YXGeQKRgliddbg3ufNiU3lBpbOYIFavjERYR+WzaboSMd+veGvW UVSilQ6u00z+8c7k8tz2DYokUV3QyZYeWmayjlB6fmWtVMY+JVd11vwkXsDIeHGqFTBE TH5rxIjun895J/8D+ZB9FFZ1A87NQhfS2FO9quGNrJW4AaC5TwzkjwusCJ+DQ+q6KJBs IweQ== X-Gm-Message-State: AFuF++lzFhxLcg4J/N849/raCHGdWkZRlO6gjcHFD8DA2+f3l0Bhelrp 7MlseOqgbxmywFJ23o2ACn6W81wZkZPhZKAmgllPL1Pr7XXuUjt6CqfO2447zkPK9URlWstx297 pbMI= X-Gm-Gg: AR+sD10g4I7On9wER/Vk7FYFZB0WONrAZvMRnM++EweVUzsyzarwo0TCqmh0EANgJLq iwsBU9sKdU2gG/S/gte/zHqLcWDi83U8zvZHhSN6cey+qdr4ocYalTNkX7AXVu4kysvZh7wgaAg 6YLO/OjlZAlw5iUFwoVKMzZkkndZjGMhQ1xffRVVcx/3B5fKOvQVvcJUJ7+yIfKsg0Ft483RUbP pV0/WiHsoymUvIKLAknvOvN3v950UiQFw+vuMaVUOhNGkqqyt9CJzGvjnlR9M8jqWdVBxscqMjK 7lQu6Aw9E69fYwagNZZZkDyM5epOuoAsBBG3p3tHW1XSK73hSm1YltklXSAwrn0OBnJtobykhse JGJFBf0JrqN/c4WxdP8XClE84TUTTq8pq867AxnyQfoy04Nhr01LFLFeM6xdtEOeLQi2ydnCff1 1pKupMC4bH4pu6rWTznvcEdj4WH6o2cJOqG6CgI+EtnLEP0SBJxZ1YHqmrP1Vz60C92A58fw== X-Received: by 2002:a05:6102:3c4c:b0:774:ce64:242f with SMTP id ada2fe7eead31-77fd6508183mr1598915137.20.1787677408786; Tue, 25 Aug 2026 10:03:28 -0700 (PDT) Received: from ?IPV6:2804:14d:5c54:4d67::2000? ([2804:14d:5c54:4d67::2000]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-97cbb44542bsm101377241.9.2026.08.25.10.03.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 10:03:28 -0700 (PDT) Message-ID: Date: Tue, 25 Aug 2026 14:03:23 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net/sched: act_sample: reset truncation settings on action replace To: Khawar Ahemad , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org References: <20260825160143.86866-1-ahemadkhawar123@gmail.com> Content-Language: en-US From: Victor Nogueira In-Reply-To: <20260825160143.86866-1-ahemadkhawar123@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/08/2026 13:01, Khawar Ahemad wrote: > When replacing an existing sample action, if TCA_SAMPLE_TRUNC_SIZE is not > passed in the netlink request, s->truncate and s->trunc_size retain their > previous values from the prior configuration. > > As a result, a user cannot disable packet truncation when replacing a > sample action unless the action is fully deleted and recreated. In > addition, the hardware offload state and netlink dump continue to report > truncation as active. > > Fix this by explicitly resetting s->truncate to false and s->trunc_size > to 0 when TCA_SAMPLE_TRUNC_SIZE is omitted during tcf_sample_init(). This would be a behavioural regression. Users are not expecting that a replace omitting truncation parameters will silently overwrite their previous truncation settings. Can you instead create a new netlink attribute? Something like "TCA_SAMPLE_FLAGS" which might have a flag telling the action to unset this parameter? Other option is to interpret 0 as "unset", but that might break some setups. Your fixes commit doesn't seem to exist and, since this is a fix, you should target net and not net-next. Also remember to wait 24 hours before posting a v2. cheers, Victor