From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Jack Zhu <jack.zhu@starfivetech.com>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v1 2/4] dt-bindings: phy: Add starfive,jh7110-dphy-rx
Date: Wed, 15 Feb 2023 09:27:54 +0800 [thread overview]
Message-ID: <e6b9e942-633b-90f4-104e-1d6fbe5d0235@starfivetech.com> (raw)
In-Reply-To: <80d16935-dad6-8087-c1b2-1d5b1c3f738e@linaro.org>
On 2023/2/14 15:49, Krzysztof Kozlowski wrote:
> On 14/02/2023 04:07, Changhuang Liang wrote:
>>
>> OK, will drop quotes
>>
>>>> + items:
>>>> + items:
>>>> + - description: phandle of AON SYSCON
>>>> + - description: register offset
>>>> + description: The register of dphy rx driver can be configured
>>>> + by AON SYSCON in this property.
>>>
>>> Can be? So does not have to? But you made it a required property....
>>>
>>
>> Maybe I described it wrong.
>> I will change to:
>> description: The power of dphy rx can be configured by AON SYSCON
>> in this property.
>> It is like AON SYSCON is the power switch of the dphy rx, it is necessary to
>> configure the AON SYSCON register, so I made it a required property.
>
> Then do not use "can be". Can is optional: I can jump but I don't have
> to. :)
>
OK, "can be" will be changed to "is".
Best Regards,
Changhuang Liang
next prev parent reply other threads:[~2023-02-15 1:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 6:17 [PATCH v1 0/4] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-02-10 6:17 ` [PATCH v1 1/4] riscv: dts: starfive: jh7110: Add aon syscon node Changhuang Liang
2023-02-13 9:28 ` Krzysztof Kozlowski
2023-02-14 2:18 ` Changhuang Liang
2023-02-10 6:17 ` [PATCH v1 2/4] dt-bindings: phy: Add starfive,jh7110-dphy-rx Changhuang Liang
2023-02-10 13:58 ` Rob Herring
2023-02-13 7:47 ` Changhuang Liang
2023-02-10 18:29 ` Rob Herring
2023-02-13 7:51 ` Changhuang Liang
2023-02-13 9:30 ` Krzysztof Kozlowski
2023-02-14 3:07 ` Changhuang Liang
2023-02-14 7:49 ` Krzysztof Kozlowski
2023-02-15 1:27 ` Changhuang Liang [this message]
2023-02-10 6:17 ` [PATCH v1 3/4] phy: starfive: Add mipi dphy rx support Changhuang Liang
2023-02-10 6:17 ` [PATCH v1 4/4] riscv: dts: starfive: Add dphy rx node Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6b9e942-633b-90f4-104e-1d6fbe5d0235@starfivetech.com \
--to=changhuang.liang@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®