mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert Crocombe" <rcrocomb@gmail.com>
To: "Stefan Richter" <stefanr@s5r6.in-berlin.de>
Cc: "Keith Curtis" <Keith.Curtis@digeo.com>,
	linux1394-devel <linux1394-devel@lists.sourceforge.net>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: isochronous receives?
Date: Thu, 14 Dec 2006 11:23:11 -0700	[thread overview]
Message-ID: <e6babb600612141023g5fd73b8bi89282b8c3008522b@mail.gmail.com> (raw)
In-Reply-To: <45804615.3060004@s5r6.in-berlin.de>

On 12/13/06, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> How about leaving ohci1394 as it is but document tag_mask better in
> libraw1394's inline doxygen(?) comments, and maybe add an enum or macros
> to be used as values of raw1394_iso_recv_start's tag_mask argument?
>
> /* can be ORed together */
> #define RAW1394_IR_MATCH_TAG_0       1
> #define RAW1394_IR_MATCH_TAG_1       2
> #define RAW1394_IR_MATCH_TAG_2       4
> #define RAW1394_IR_MATCH_TAG_3       8
> #define RAW1394_IR_MATCH_ALL_TAGS   -1

Yeah, that's definitely much better.  I guess this would go in
libraw1394's raw1394.h?  Similar to:

--- raw1394.h   2006-11-29 11:54:56.000000000 -0700
+++ raw1394_modified.h  2006-12-14 11:20:57.000000000 -0700
@@ -40,6 +40,14 @@
 #define RAW1394_RCODE_TYPE_ERROR         0x6
 #define RAW1394_RCODE_ADDRESS_ERROR      0x7

+/* can be ORed together */
+#define RAW1394_IR_MATCH_TAG_0          0x1
+#define RAW1394_IR_MATCH_TAG_1          0x2
+#define RAW1394_IR_MATCH_TAG_2          0x4
+#define RAW1394_IR_MATCH_TAG_3          0x8
+#define RAW1394_IR_MATCH_ALL_TAGS       -1
+#define RAW1394_IR_MATCH_TAG(tag)       (1 << (tag))
+
 typedef u_int8_t  byte_t;
 typedef u_int32_t quadlet_t;
 typedef u_int64_t octlet_t;
@@ -273,7 +281,9 @@
  * @handle: libraw1394 handle
  * @start_on_cycle: isochronous cycle number on which to start
  * (-1 if you don't care)
- * @tag_mask: mask of tag fields to match (-1 to receive all packets)
+ * @tag_mask: mask of tag fields to match.  Use the RAW1394_IR_MATCH_*
+ * values for this rather than the literal tag bits: the values are not
+ * equivalent.
  * @sync: not used, reserved for future implementation
  *
  * Returns: 0 on success or -1 on failure (sets errno)

??

-- 
Robert Crocombe
rcrocomb@gmail.com

  parent reply	other threads:[~2006-12-14 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AccTUZEOi7v6J84+R+eLGKj8lA2txQAz+0pA>
2006-11-30  1:57 ` Keith Curtis
2006-12-01 10:30   ` Stefan Richter
2006-12-13 14:30   ` Robert Crocombe
2006-12-13 18:27     ` Stefan Richter
2006-12-13 23:15       ` Stefan Richter
2006-12-14 18:23       ` Robert Crocombe [this message]
2006-11-29  0:59 Robert Crocombe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6babb600612141023g5fd73b8bi89282b8c3008522b@mail.gmail.com \
    --to=rcrocomb@gmail.com \
    --cc=Keith.Curtis@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®