From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B832F8E8F for ; Mon, 22 Jun 2026 12:19:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782130746; cv=none; b=AYlD++ayrIVbI3PnafoK+2Iagfi78PO3D6Y61aXvFwqd3xvLNiQt9uDFNCCySFZgW2g1pY0fXwHL541vrYRmNqd9QQTm8DTRYzX+zd3RGiC5yfPVU/QFJlqQZ/Vh6D+xnsqqzitzNA6LUsRwL2HnEp/NxzPmwQKRlH5sJ1yty2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782130746; c=relaxed/simple; bh=IDAQwkwElewdfh6Wf9mYqA+Yy4/BfY0aRhjuZlMQGxs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LyV2qC/oCJw+D0q21Y7EddSOhq8Vd0DATheWPhc6lRodb5OCLbqmdzk2sj6ZMCEe/Iq2CFf6ddloYkmb6ywLtdjdKnD806juq2j9IxwAbunzD/ms72NlltiopvL4/h8M/qQHFkzwZ5c8cDU+pZgGWfnU9fXvFSxZ539wE3Ot1yQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dITy+Jnf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YE8g6K/H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dITy+Jnf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YE8g6K/H" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MAnVEP3214420 for ; Mon, 22 Jun 2026 12:18:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HeV8efjPqPS9nnwVB+vE4XQRlHFFHwy9Uis9TmOzdyI=; b=dITy+Jnfc9wiJxZU fDA8G1vgHoDCdn36+p9d1IX1URvQqd7CvhF6iy51qfjka7zwyKhY0OswHFYui9x8 vDVCD3aIF7fkqZVNqpP8cNj6IUL4mLH6JdWHwF68lgyrb8j23wB2Io60Pf1FcaVS dVJvvSYJTbTKDS4xc0Ec2mRuNg2PanCb3TIfk7LZeha7bJ7AG55vqRvYNzYspOj8 3HwvxOOCur3uvkw9EdtnSqbOFvzljTNKywMtix3LjFNWxKGk4cLMEF3poUJ+FSUd KNBZuRGqaYlcBN3ndovnvZSv/cJFMpuMJiG4EV3UMZJHQtfny/YsWzA5scA3q0Ff UNo5RQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey2yhre1v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 12:18:59 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9157263095fso62952585a.0 for ; Mon, 22 Jun 2026 05:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782130738; x=1782735538; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HeV8efjPqPS9nnwVB+vE4XQRlHFFHwy9Uis9TmOzdyI=; b=YE8g6K/HvmNAC6AllJMRJEGZ/jw0ql8+cv5CvP3L41bdtd+TLMx4ZqnYBxOHbgZfdT jxbCe3d+gATT3p6Q9OJipZQlfsT5XZ3D00fCdPXBlQ8NZOlcUewU7RRYX+le458mwn1n crgq79PtT6aholf5t99Kv4TQt5W83t7RvCi+6xp4VY5emXqpq003C+/rbE3XaSmQXXtR 1Qfzxt4EquzVnA33piLJK3lvfoJDsDcfSENTnOF2899KNFkiDTKFXZi/x6LowRrdhxTV Ss0+b0JWU48iLCaVvE9GvP2bpaJ2lB5aVJJH8P4VDn+3wcv6JEmEVHYinJaG3R1HHjY+ /Wgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782130738; x=1782735538; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HeV8efjPqPS9nnwVB+vE4XQRlHFFHwy9Uis9TmOzdyI=; b=RdopN/IkdCUnILBj7mMZxnWhdICWmJQvvXmFpY2UT2CcSDmdbScutUX6fTkYl+HOEj dqGkzZ+9IhpJuhAwFgfBWgY8bB4mYUgXfV73IYacFHM3rLz7YHpyWM4zu+eHS+sIlT0R kXG8lUdAO2sHbLZyYH9bsA/1RJp7JNXs1DTazHvrN9m1agjWzIDl5TPAdYKtCMPp22gC vHmsk4TpW0ISKQpEK4nG9Cufortbvg9R+ohVX7HSq43Sr6ZaFNU4PbjJU3oXzmI6r9ya 2TO60nDk+CVAzl/Y+rZ8jkkkYccamZkr+LHEUsqs2oH1/OijYcm5eZFGy4BlmQT5NYW8 HHXw== X-Forwarded-Encrypted: i=1; AFNElJ+my+fgxXwpoupTv8v1NulKaRPnsTKsac9rrMqB/cQLHsgxIaj3THDLbngp/TuoUilDpPXwBb79VrAFys4=@vger.kernel.org X-Gm-Message-State: AOJu0YzHVSU6UpUl3aW6rfqKqG27Kr/PX/5za28c7wzQTQwxVAXWai69 q1n1HzULgynYZSFtEvP408XSFY50LfMJH0rICFGGk8t8GY7UazancM7etwiQVa/buYqRYeXIF5Z xLL3TtfAYPybwEigUmzILyw89HvNVlZ25apN3PM6UQBmxGKowDDE6LUWFaQpJzr6UYGY= X-Gm-Gg: AfdE7ckS09YWhRXZaSEjEHVHARm/kW4SvtCnxoBJatBeETwgWdwFBj376JPDxBXMCYb BRARbh76C+aJGydt6NQ+xuGtCINPLQCiVhCYQxgXgKSHy45gLSn9pGmzBgOtoEmpmuHjXRJ4ZR0 LARZCIh6ve6RziWyNDq/4LNsvbQWaEd4osvmhz8cUHVQ+vWe0yZAwG+MIdpvjrzsEfE4dMilA88 wzV9A+aIalvsIIeZgrRZXcfHZDlCn83U7HudA+r9p4ZPJXLOcB7icQHTdXWiG2xpcEkcIH1AIAn JIjjB9xjjc+4m16nmfK5RqdFlooXVf87MUwNWza50jRVTIMFDDc/K8IRgurXoOQ7q3fw6OQ03AM wN6t8+XlLU/nHeB+pY55Lhqm1DZzx9ybrRUY= X-Received: by 2002:a05:620a:1791:b0:915:79da:a898 with SMTP id af79cd13be357-925cbff2a89mr6047185a.8.1782130738217; Mon, 22 Jun 2026 05:18:58 -0700 (PDT) X-Received: by 2002:a05:620a:1791:b0:915:79da:a898 with SMTP id af79cd13be357-925cbff2a89mr6043785a.8.1782130737667; Mon, 22 Jun 2026 05:18:57 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c60ac9406sm349372966b.38.2026.06.22.05.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 05:18:56 -0700 (PDT) Message-ID: Date: Mon, 22 Jun 2026 14:18:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR To: Qiang Yu , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-7-c939c22ded0c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260621-tcsr_qref_0622-v6-7-c939c22ded0c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDEyMiBTYWx0ZWRfX7n4ASd9yBlWL IyFD3T25A5MZjnT1qjqY53DHOi795en0lgFs5ghEMewTfG2EKFxy+3Q8kgLufWwU5c883/TB3Mt BND9uR4Ir22IjWrh71UMgBiMecSzF8E= X-Proofpoint-ORIG-GUID: wttRJ_iODyXAn-t39Cjs_t4dsbmTrm11 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDEyMiBTYWx0ZWRfXxgcTTgRRX3GM +ro8no4w+cOhuRFcCfQkDThh73NHqc+7pPUX7tdFIJqx4X+3KgWJD8UdHUwIhq9zbNzN32L+gmu ZrFEmf3veq2pseB7RW8IK6gtdvrJdp+BMvjh4i6MDkLFFbL813BXdX5vXhfrIeloXzqzOsWv9Eg wYyrs1L/X1tzuGJqEKihSaqK4GRhNMT63f0lStlas7k/HG+CVLyqxTJOIchSWoNdAOYQsvA1dDY zeHy+r3gLZEm2g5W/MUQz4vIYCTKtnEnU/cRW9DJeAIbWAYrB0Wq5MDESgFGfvpMnnyORSqEB6T GG4XWoX0zfnKMnRUSW0swBlfyzcbK+oa7F35QCRwHAzGkEhs26mFqjfl2onIeL+6OJTZTfIny6n q95P+1HvmNhYbwEa3B7J47Jb4mrbeYOSJkK8OoJf0/qo39Ci0VgijA0HgXGpuBGEhUhF4ihA9Ca XbDmDsgtkQPXFVsq8KA== X-Proofpoint-GUID: wttRJ_iODyXAn-t39Cjs_t4dsbmTrm11 X-Authority-Analysis: v=2.4 cv=cKbQdFeN c=1 sm=1 tr=0 ts=6a392833 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=0OB78NtceWqr1_yVbOgA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220122 On 6/22/26 7:11 AM, Qiang Yu wrote: > Mahua has a different PCIe QREF topology from glymur. Override the TCSR > compatible to qcom,mahua-tcsr in mahua.dtsi, and wire up the required > LDO supplies for the PCIe clkref paths on the CRD board. > > Signed-off-by: Qiang Yu > --- > arch/arm64/boot/dts/qcom/mahua-crd.dts | 15 +++++++++++++++ > arch/arm64/boot/dts/qcom/mahua.dtsi | 4 ++++ > 2 files changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/mahua-crd.dts b/arch/arm64/boot/dts/qcom/mahua-crd.dts > index 9c8244e892dd..8b42f5174b31 100644 > --- a/arch/arm64/boot/dts/qcom/mahua-crd.dts > +++ b/arch/arm64/boot/dts/qcom/mahua-crd.dts > @@ -19,3 +19,18 @@ / { > model = "Qualcomm Technologies, Inc. Mahua CRD"; > compatible = "qcom,mahua-crd", "qcom,mahua"; > }; > + > +&tcsr { > + vdda-qrefrpt0-0p9-supply = <&vreg_l2f_e1_0p83>; > + vdda-qrefrpt1-0p9-supply = <&vreg_l2f_e1_0p83>; > + vdda-qrefrpt2-0p9-supply = <&vreg_l2f_e1_0p83>; > + vdda-qrefrpt3-0p9-supply = <&vreg_l1f_e1_0p82>; > + vdda-qrefrpt4-0p9-supply = <&vreg_l2h_e0_0p72>; > + vdda-qrefrpt5-0p9-supply = <&vreg_l2h_e0_0p72>; > + vdda-qrefrx1-0p9-supply = <&vreg_l2f_e1_0p83>; > + vdda-qrefrx2-0p9-supply = <&vreg_l2f_e1_0p83>; > + vdda-qrefrx3-0p9-supply = <&vreg_l2h_e0_0p72>; > + vdda-qreftx1-0p9-supply = <&vreg_l1f_e1_0p82>; > + vdda-refgen3-0p9-supply = <&vreg_l1f_e1_0p82>; > + vdda-refgen3-1p2-supply = <&vreg_l4f_e1_1p08>; The supplies are correct, but QREF uses refgen4 on Mahua There's also rx0 with a 0p9 supply on l2f_e1 Konrad