From: "Christian König" <christian.koenig@amd.com>
To: Bernard Zhao <bernard@vivo.com>,
Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code
Date: Sun, 20 Jun 2021 18:59:27 +0200 [thread overview]
Message-ID: <e6c51c79-52ae-5591-45c7-382d1a8f2b5d@amd.com> (raw)
In-Reply-To: <20210619064349.26676-1-bernard@vivo.com>
Am 19.06.21 um 08:43 schrieb Bernard Zhao:
> Function radeon_fence_driver_init always returns success,
> the function type maybe coule be changed to void.
> This patch series will first delete the check of the return
> value of the function call radeon_fence_driver_init, then,
> optimise the function declaration and function to void type.
Please merge all of this into a single patch, I don't see any point
separating this.
Christian.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Bernard Zhao (4):
> drm/radeon: remove meaningless if(r) check code
> drm/radeon: remove meaningless if(r) check code
> drm/radeon: remove meaningless if(r) check code
> drm/radeon: delete useless return values
>
> drivers/gpu/drm/radeon/cik.c | 4 +---
> drivers/gpu/drm/radeon/evergreen.c | 4 +---
> drivers/gpu/drm/radeon/ni.c | 4 +---
> drivers/gpu/drm/radeon/r100.c | 4 +---
> drivers/gpu/drm/radeon/r300.c | 4 +---
> drivers/gpu/drm/radeon/r420.c | 5 +----
> drivers/gpu/drm/radeon/r520.c | 4 +---
> drivers/gpu/drm/radeon/r600.c | 4 +---
> drivers/gpu/drm/radeon/radeon.h | 2 +-
> drivers/gpu/drm/radeon/radeon_fence.c | 5 +----
> drivers/gpu/drm/radeon/rs400.c | 4 +---
> drivers/gpu/drm/radeon/rs600.c | 4 +---
> drivers/gpu/drm/radeon/rs690.c | 4 +---
> drivers/gpu/drm/radeon/rv515.c | 4 +---
> drivers/gpu/drm/radeon/rv770.c | 4 +---
> drivers/gpu/drm/radeon/si.c | 4 +---
> 16 files changed, 16 insertions(+), 48 deletions(-)
>
next prev parent reply other threads:[~2021-06-20 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 6:43 Bernard Zhao
2021-06-19 6:43 ` [PATCH 1/4] drm/radeon: " Bernard Zhao
2021-06-19 6:43 ` [PATCH 2/4] " Bernard Zhao
2021-06-19 6:43 ` [PATCH 3/4] " Bernard Zhao
2021-06-19 6:43 ` [PATCH 4/4] drm/radeon: delete useless return values Bernard Zhao
2021-06-20 16:59 ` Christian König [this message]
2021-06-21 1:33 ` Re:Re: [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6c51c79-52ae-5591-45c7-382d1a8f2b5d@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bernard@vivo.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®