From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91953EB64D7 for ; Tue, 20 Jun 2023 07:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231276AbjFTHbT (ORCPT ); Tue, 20 Jun 2023 03:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbjFTHbR (ORCPT ); Tue, 20 Jun 2023 03:31:17 -0400 Received: from forward500c.mail.yandex.net (forward500c.mail.yandex.net [178.154.239.208]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D945FE4D; Tue, 20 Jun 2023 00:30:56 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:c83:0:640:84f9:0]) by forward500c.mail.yandex.net (Yandex) with ESMTP id 379B75EDBD; Tue, 20 Jun 2023 10:30:54 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id pUbQt2qDVKo0-eL4OdmlW; Tue, 20 Jun 2023 10:30:53 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1687246253; bh=3rtRPYT14HBdyVacf+D4l8FmRddXv2uGiiB1drmivrY=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=n1eSasTp6ajRtQvhnqv+1Y30fetreVfCGaUbhe/ONKZruw5nR7lYLfj65my4PUj+5 IZvD+PJ7iQ3899jqYpUbdsJXAhi09TfZfIIxC6b/ByuAPe1cnvC7d1I0PTvZag9iIB Bsyp5Bq6nr4OPZW4a54OFVGbAum1HQMsQTITJu9I= Authentication-Results: mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net; dkim=pass header.i=@maquefel.me Message-ID: Subject: Re: [PATCH v1 29/43] dt-bindings: rtc: Add ST M48T86 From: Nikita Shubin To: Krzysztof Kozlowski , Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski Cc: Michael Peters , Kris Bahnsen , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 20 Jun 2023 10:30:54 +0300 In-Reply-To: References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601054549.10843-11-nikita.shubin@maquefel.me> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof! On Thu, 2023-06-01 at 10:18 +0200, Krzysztof Kozlowski wrote: > On 01/06/2023 07:45, Nikita Shubin wrote: > > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC. > >=20 > > Signed-off-by: Nikita Shubin > > --- > >=20 > > Notes: > > =C2=A0=C2=A0=C2=A0 v0 -> v1: > > =C2=A0=C2=A0=C2=A0=20 > > =C2=A0=C2=A0=C2=A0 - s/dallas/st/ > > =C2=A0=C2=A0=C2=A0 - description for regs > > =C2=A0=C2=A0=C2=A0 - s/additionalProperties/unevaluatedProperties/ > > =C2=A0=C2=A0=C2=A0 - add ref rtc.yaml > > =C2=A0=C2=A0=C2=A0 - changed compatible to st,m48t86 > > =C2=A0=C2=A0=C2=A0 - dropped label in example > > =C2=A0=C2=A0=C2=A0 - replaced Alessandro Alessandro to Alexandre Bellon= i > >=20 > > =C2=A0.../bindings/rtc/st,m48t86-rtc.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 38 > > +++++++++++++++++++ > > =C2=A01 file changed, 38 insertions(+) > > =C2=A0create mode 100644 > > Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86- > > rtc.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > > new file mode 100644 > > index 000000000000..eb8e6451d7c8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml >=20 > Filename based on compatible, so drop "rtc". >=20 > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/st,m48t86-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ST M48T86 / Dallas DS12887 RTC wirh SRAM >=20 > typo: with >=20 > > + > > +maintainers: > > +=C2=A0 - Alexandre Belloni > > + > > +properties: > > +=C2=A0 compatible: > > +=C2=A0=C2=A0=C2=A0 enum: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - st,m48t86 > > + > > +=C2=A0 reg: > > +=C2=A0=C2=A0=C2=A0 items: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - description: index register > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - description: data register > > + > > +allOf: > > +=C2=A0 - $ref: rtc.yaml > > + > > +unevaluatedProperties: false > > + > > +required: > > +=C2=A0 - compatible > > +=C2=A0 - reg >=20 > required goes after properties: >=20 > Keep the same order in all your patches. >=20 > > + > > +examples: > > +=C2=A0 - | > > +=C2=A0=C2=A0=C2=A0 rtc@10800000 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D "st,m48t86"; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x10800000 0x1>, <0x11700000 0= x1>; >=20 > One byte long? Not a word? They are indeed one byte long: https://elixir.bootlin.com/linux/v6.4-rc7/source/drivers/rtc/rtc-m48t86.c#L= 46 >=20 > > +=C2=A0=C2=A0=C2=A0 }; > > + > > +... >=20 > Best regards, > Krzysztof >=20