From: Nikolay Borisov <nborisov@suse.com>
To: John Ogness <john.ogness@linutronix.de>,
pmladek@suse.com, sergey.senozhatsky@gmail.com
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH] printk: ringbuffer: Convert function argument to local variable
Date: Tue, 10 Nov 2020 15:19:46 +0200 [thread overview]
Message-ID: <e6c7fcaa-2a65-7586-d82a-450996986770@suse.com> (raw)
In-Reply-To: <87v9edqrph.fsf@jogness.linutronix.de>
On 10.11.20 г. 15:14 ч., John Ogness wrote:
> On 2020-11-10, Nikolay Borisov <nborisov@suse.com> wrote:
>> data_alloc's 2nd argument is always rb::text_data_ring and that functino
>> always takes a struct printk_ringbuffer. Instead of passing the data
>> ring buffer as an argument simply make it a local variable.
>
> This is a relic of when we had a second data ring (for
> dictionaries). The patch is a nice cleanup, but there are actually
> several functions that could use this exact same cleanup:
>
> - data_make_reusable()
> - data_push_tail()
> - data_alloc()
> - data_realloc()
>
> Perhaps we should fix them all in a single patch?
I observed that right after sending this patch, so I have authored the
necessary changes I can squash them and send them.
>
> John Ogness
>
prev parent reply other threads:[~2020-11-10 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 12:50 Nikolay Borisov
2020-11-10 13:14 ` John Ogness
2020-11-10 13:19 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6c7fcaa-2a65-7586-d82a-450996986770@suse.com \
--to=nborisov@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®