From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
stephen eta zhou <stephen.eta.zhou@outlook.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: timer-sp804: Fix read_current_timer() issue when clock source is not registered
Date: Fri, 7 Mar 2025 12:17:03 +0100 [thread overview]
Message-ID: <e6cda34e-f363-4fae-897f-f4deb7c6bddc@kernel.org> (raw)
In-Reply-To: <198fe423-e797-4a82-a509-ee06ca05466e@linaro.org>
On 07/03/2025 09:10, Daniel Lezcano wrote:
>
> Hi Stephen,
>
> thanks for the proposed fix
>
> On 21/02/2025 04:46, stephen eta zhou wrote:
>> Hi daniel
>>
>> While debugging on the vexpress-v2p-ca9 platform, I discovered that the read_current_timer API wasn't functioning correctly. The issue was that the SP804 driver lacked ARM32 support and did not register read_current_timer. To add ARM32 compatibility, I’ve submitted this patch. Without it, using SP804 as the timer on ARM32 causes issues with boot_init_stack_canary when inserting the canary value into the interrupt stack, and also affects entropy generation and collection, resulting in incorrect rdseed values.
>
> It is better to put that information in the changelog and provide a
> fixed format of the patch description.
Daniel,
In case you actually consider applying this - some of the patches or
their descriptions were generated by sort of AI tools, thus approach
with caution.
It was already pointed out that patches might be a garbage output of AI.
Also they were not tested, even though what is claimed here "debugging
on ...".
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-07 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 3:46 stephen eta zhou
2025-03-07 8:10 ` Daniel Lezcano
2025-03-07 11:17 ` Krzysztof Kozlowski [this message]
2025-03-07 13:41 ` Daniel Lezcano
2025-03-08 3:15 ` stephen eta zhou
2025-03-08 2:32 ` stephen eta zhou
2025-03-08 4:23 ` stephen eta zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6cda34e-f363-4fae-897f-f4deb7c6bddc@kernel.org \
--to=krzk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen.eta.zhou@outlook.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®