From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752398AbdBMJvU (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Feb 2017 04:51:20 -0500
Received: from mout.web.de ([212.227.17.12]:60791 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751609AbdBMJvS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Feb 2017 04:51:18 -0500
Subject: Re: [PATCH 27/27] IB/hfi1: Code reuse with memdup_copy
To: Dennis Dalessandro <dennis.dalessandro@intel.com>,
        linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        "Michael J. Ruhl" <michael.j.ruhl@intel.com>,
        Mike Marciniszyn <mike.marciniszyn@intel.com>,
        Sean Hefty <sean.hefty@intel.com>
References: <8a997282-09c7-0f9f-645e-d7c6e8c79e67@users.sourceforge.net>
 <b19e44b3-601f-c642-b8d3-12c000511ce2@users.sourceforge.net>
 <477c8499-93ad-253d-aa2b-8f209ecfad62@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e6ce8bb1-dad3-a88c-89e6-f3d0c5ced1f7@users.sourceforge.net>
Date: Mon, 13 Feb 2017 10:50:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <477c8499-93ad-253d-aa2b-8f209ecfad62@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:2lFKQEE/pdPLtTWSjfih3RmYY4tITOjAgju2MpniYBBPbbMMfi2
 zwZwT26hUSZymaM9ahvu0hfbSR2j76Pb9qgmGR4J0XYdz6zt8AUUndwVj22UK+CFrpaP4qa
 H/JbiXBXXVubYCMxciTR7/Bo1IrmlC3b1/m7g+wfSG9LV6IFq1afLfCCN7l+KMQjgcN2CCL
 c/JOAAmfItK1sEaJCPCuw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:8Mqki2FJGPU=:NGEYV4z/6L11M3gGPiT/md
 JSElJqGGiYVB8Ms+hVX4uiN9z+RqBN7XemJIBbZP5Ks/g+sPAunvlbOhXD6H3MH6F85DluGgi
 JCQiytHp8n04M9uOnF7cMmlQ0dZmnynmkOOT0mk5UF5gu6KbHFw9vQbnAP1WXJPnSsw15v8xh
 TlVYCxgxF/vJB3uU2hy3b2K1i1kCueX5LeEyjeggn+s/5p55ywEFGsmOGQDJREnoAsLdidN2S
 u5NyjBK9kAXcam3FBZZ4yBNaAD5gngZDwdpFHmlY+KVxKZdn6IpAEhRjSldCIqhUJX/A+IPkd
 OdfHBNF4cMuHl/ugms4RIAlCpfGatbkavumHzDE9cWScA9OXBvhgJshDcZAB3d9q1P3/FKeEd
 ujbdLeqEsKYKCm7GAfVl7z8nUcv1c/VMxeJ2T3dr+dbpFBW7waoiZiqtN8WjtZY2TfgddlJNA
 E+eYh95oqpatMKOmFe7XJr5lxgk6JTJuCllp4XSpTvlvTQI54tDnOXYqF44Qg3BOe/E+p0dkv
 r/iqZ4L/wKai3aNbWC1BugjPESGS3g7Hvq3rtCDNUBxcAuGy52GKsgn+E/HcOLXpsQ83DuXt7
 nwiviit6mEOqRPpbxD3xwtOgmUv4bkK0kTI/ZBH4Yg2JnCuyFOLJAFOZb6gB15Shg35ByaFvr
 HbLzdR/rA4enmvRf/wkVgRUHbTPpy213G4wqPdaV2Scm6Z2eTZNDnPQY4f4CtwPyQLJWBprN3
 HiVtZN7ST8rLCij7CVLW3qg0dZcas6qhthkrcumyPlY3KK1+fUKl+7JR0MUYWfYDrTbVXRSdd
 PEM/wrr
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Thanks for the patch, but this one is already taken care of along with other similar uses of kmalloc/copy:
> http://marc.info/?l=linux-rdma&m=148656088729538&w=2

Thanks for your information.

The shown source code is reasonable in the update step “[PATCH 27/27] IB/hfi1:
Code reuse with memdup_copy”.
https://patchwork.kernel.org/patch/9562565/
https://lkml.kernel.org/r/<20170208132830.16442.93943.stgit@scvm10.sc.intel.com>

I find the commit subject and message partly inappropriate.
How do you think about to mention other function names there?

Regards,
Markus