From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85AD83624A7 for ; Tue, 18 Nov 2025 15:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763479122; cv=none; b=blc3+/iHaDEx6Ms1mm2CRbuqBccLGiohzZ1nEzievOjpvkYeH9qVhSsGQxFfh7G2RKgvmomRi6RONdr19Eabh8jC65To2886JGyWTMBMQbE5PT551aUSmWC2eL15MMeKXpBKlCXkIH849gx7to0GJyLBnFkX2V9us1gCSgdBZco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763479122; c=relaxed/simple; bh=Gpc8AO/IwVgbJhDACf3tqhXIOKnF1kwq15XSr1OW7tY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hh1fCKnTF+hGUcZxKTu5xHF4ToWCO6JJWqT/zVBGhrxwNGfg5y5e1YsZR82Skhpesn1tFkJq1lfuOWl3xAGWtAQsDfPHcVAcgf1H7udekmBAu9e53D581zx6a6nWAMcm/mQsZN1yy/BR3Gcu0ASjFEFNhMOsdiIBTnorJWNXdYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QOHeNtMZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BMvF1L9+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QOHeNtMZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BMvF1L9+" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AIDvCuB623877 for ; Tue, 18 Nov 2025 15:18:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C15Cd9BIgdY3KE5bqUCAig00grelyWdsLExE6aMv7Uc=; b=QOHeNtMZLQE9qtUJ H2vno/A1r0Hrz+WN1/QhmYSDdLUu2z5ur8exaTog2bl6o8Hoe/RsXndG4ToUXdVi GcZR8oR3HDCxxSL9dF1bfSu65EJKuguG1e23PCUEBhS0lsRvmhnIHxzKxThEHeRn +DlFfFcqknj9dOPVO27yCQ/yHcjMNZ6BTGBaPMdSpBIgIfFzblw+bgmgWgCJZAhF YOLo+Y7xWiq5FxuR9zQGa/IjcoopKM9pE6QR+WU65owMtkQW1CAbilIjLaFXktnK 0hWiIOA45EE7RkMT6ZtaL6UpOrIEU2ib+QyizYsNmS26QXoviiDiuEMJ135XMTlP Evi+Bg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4agahfavgw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 15:18:39 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2958a134514so73688955ad.2 for ; Tue, 18 Nov 2025 07:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763479119; x=1764083919; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C15Cd9BIgdY3KE5bqUCAig00grelyWdsLExE6aMv7Uc=; b=BMvF1L9+NVgd5mV+Y7mn4AkWrNylM4KuWPyEI9xWS+yWUp1fttbIngT8t/BzJQvO0V dUgQMWtr57v3J7KqtfvT8N3UBASza+CwgtR5g861WrE3pofzws93ioRck9IltMlcT0RR XXbgL+L6ukWPW6OsoF0fv0t+WDcrJc/7tKEXj1F6Bss0Uw/jP7ZgUZ9P78s5hdZ4Ji0K JLtrEfZsDOTtEdu08KU7CVGTtyWb0NQCuovhXc5vozY7f6E/5725K3tm+oqVsSBnbNDK +LmK7Usz7z33jzBeEeaxPZDgZLk+6CMQ5WVt8jSj+5EjrRiwqGWHb3s52k0Jg2Sem270 qoqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763479119; x=1764083919; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C15Cd9BIgdY3KE5bqUCAig00grelyWdsLExE6aMv7Uc=; b=bjMA+zcOeH3HA/S30o8DSC+hBnoPsL6VBCQLOU3dD4jMDLkl5gU8QVwMyXkZHuykHk lsvdHUp5n4F0ABYBRYivRQ5Tyu1xyDg7kOrRhKPOb+IXkW5M47nBinoLcHJXvfwo86KL W/oPmI0y2AMsztJRffz/KR9HRynHR8/sgrBRCoA0pa2RLfl/RDiDA/ERka2WCmQQinKY SSHNF6Gk+looc0FqFVu9QkmzUZs99vrpxX/kPDj6HoGxi8cpd7JhY+VUvGUkWwmUZUcG BDR8hiD53Pkg7Nfare0hAYJkIMaJz/hhK6KTirevedRcof4YU6djh5uSCaH29UR2Ii+n hUcQ== X-Forwarded-Encrypted: i=1; AJvYcCXcYVff+2BvuXyK2FbwhZ1dcfyKFiVYV7zkoT6r+QLVK5byTUFYOktrUHJ+vY4X/x1fEHGAcapbRzP6uXA=@vger.kernel.org X-Gm-Message-State: AOJu0YyTiZZhqUHZpL7LQN+JZkUhhZVHSAAyRWTO5yGI6WWwlwZHNv3Q 4M1yiHyWoyn4iRbE8ggZ3xtHfm31zsboCMsahSWk7jZyY1nxAslvUAcLdl35+g/hRfyRECWIVjp Nd9iHZgaiIaabsYN/srwRoVTSply5XVhLJvYrRqq+2HrqEY0GAGGBP7neMfPJLV4ktNs= X-Gm-Gg: ASbGncs7Bz1fvsOYUss/N+PecIRdvgVEWkHYe61exqcsdCVLBZVeYQaBmBdyCItB528 fbJxgVNj+k7277sJRY55F9tVBStS4Wvj2Dbbgu8AbpvF1TvAkwDV0i67hnM+QZntAbYXIFRJYr7 W7sCG8YNoVEDoeE4lyIhLmPAmT+xPkyJjduEIi8XC3jwGsxX3O0LWcOohZojkV+EUOUO0yGsJVW bNgvBF5v65W45QO2vJIg8vbw4q813+WXRTseNQ0XlG76NWuGC02Dc/wybuNqQqk3wD+7vc5eCYg cnRL8nLw93An138lniunB+6Y2fDq623f+NhInZxlK2prOykmSqTrPs9cCfvXH+cVjWsNEAjOt7s LutI8B3H5eKUmlgqFvgvod66moTClhzoEhSEQn1R+P/CXgHE53OaGGQ== X-Received: by 2002:a17:903:1b10:b0:296:3f23:b93b with SMTP id d9443c01a7336-2986a6b7b8emr190624205ad.2.1763479118824; Tue, 18 Nov 2025 07:18:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFh8pEfpZapLZo4Spzf3qXPEohV/hKDW57IhNxEJCgoiEZ++gOu97KBbpW3vM5hwpFmn8OREA== X-Received: by 2002:a17:903:1b10:b0:296:3f23:b93b with SMTP id d9443c01a7336-2986a6b7b8emr190623825ad.2.1763479118289; Tue, 18 Nov 2025 07:18:38 -0800 (PST) Received: from [192.168.1.9] ([122.164.83.145]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2b0e15sm177923855ad.60.2025.11.18.07.18.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 07:18:37 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 20:48:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] soc: qcom: aoss: Use __cleanup() for device_node pointers To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251117-cleanup_node_put-v1-0-5f107071d171@oss.qualcomm.com> <20251117-cleanup_node_put-v1-1-5f107071d171@oss.qualcomm.com> <9c10881d-d5c4-4e60-8960-2ead76c63a2d@kernel.org> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDEyMyBTYWx0ZWRfX9zadAh6mdOMs Ap9oGqilKG6TqWIgjDNUFdor1Qswe2N9o51p1T0gKIhWRbwVo2cF/ImXdQMh9xkM88ZXd2qZJvz UUFJh6T75RQLpFflrc5IY728EYfm1reVOGwahmxwohO6j1nCN9UszJhFebNvb0AGxJNT+9YmbWP es+gqCBYdCP9kD46SQxzLysSh6jJq6Ke9MYHUl7oktE0g33R6Wrjf39oGQ7JMYGPUVQGI169Wfp sUhB/ZFAy991UvGk1av4punjvTmhzACn1AUf8elzHNrQ5v8um5rtO+oIhUSszvMQb8Kd+b0wyQ9 cwVoq3mmGDuexvj318E/nC9hdaJFHqzTkWSEnSpsWSDPd6DnKpIhdmsgo6oMdF7Q0Si2v4Yl3OQ 0mAJDLs3d/zKb/mWYYa2ZxQWwpshyg== X-Authority-Analysis: v=2.4 cv=RpTI7SmK c=1 sm=1 tr=0 ts=691c8e4f cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=a3gljYgooLRA4er/6UIzuQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=rzkHM0hXlX4qtSzQHzcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: lKNfFNlEJwi7w3F2gm3pTGhv0jX77FLF X-Proofpoint-GUID: lKNfFNlEJwi7w3F2gm3pTGhv0jX77FLF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-18_01,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180123 On 11/18/2025 6:02 PM, Krzysztof Kozlowski wrote: > On 18/11/2025 13:25, Dmitry Baryshkov wrote: >> On Tue, Nov 18, 2025 at 12:39:51PM +0100, Krzysztof Kozlowski wrote: >>> On 17/11/2025 12:35, Konrad Dybcio wrote: >>>> On 11/17/25 5:51 AM, Kathiravan Thirumoorthy wrote: >>>>> Make use of the __cleanup() attribute for device_node pointers to simplify >>>>> resource management and remove explicit of_node_put() calls. >>>>> >>>>> Signed-off-by: Kathiravan Thirumoorthy >>>>> --- >>>> Reviewed-by: Konrad Dybcio >>> This is obviously wrong and not helpful patch. >> Describing why it is wrong would be helpful (or having a pointer to an >> explanation). Bear in mind people who read email archives and find this >> very brief note. > I gave some rationale in other patches, but summarizing: > 1. It is against cleanup.h - author did not bother to read it - which > clearly asks for constructor with declaration. Thanks for pointing this out. I understood that w/o NULL initialization we will be freeing some dangling pointers but looks like there are other cases also. I agree that I overlooked the details in cleanup.h.Apologies for the oversight and for taking up everyone’s time. Will take care of this going forward! > This was discussed many > times in the list, including many bugs and explicit checkpatch warning > (on LKML) because people don't bother to read cleanup.h. > > 2. It makes simple get+put code complicated, not simpler. > > 3. It grows the scope of OF reference without benefits. > > 4. This driver was already reviewed and simplified so author should go > back and think why this was left alone (would save a lot of trouble). > > Best regards, > Krzysztof