From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 936A3C74A5B for ; Wed, 29 Mar 2023 18:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbjC2Ss5 (ORCPT ); Wed, 29 Mar 2023 14:48:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjC2Ssx (ORCPT ); Wed, 29 Mar 2023 14:48:53 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E7BB4C3A for ; Wed, 29 Mar 2023 11:48:51 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id w9so67259666edc.3 for ; Wed, 29 Mar 2023 11:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680115730; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=GrKgNBdgVGDd5tuVm5wP/QWfKRU7XwBSou05qKklH3k=; b=Q8B3J857qhjR2TSPbJ1IJc6AAGDDCJRITn7O9RBll+yoLHHqTAfQeLs1CutVvnaRk+ w3pcaW+fhER4vIQa7gwgHeHXo1+ijAKhfYhPMpXsTMT1mNCFRYPcJjdt4vlPoJGl9JAn sgDwzuDzJBIzHxwb3lEiW4tTyYBBJKDFFg6G+l/F27R+DmfM9r98Zkh28N7o40XxNpY+ bvBMoGsRKqixep5wRcgokXu402Q0l/sPF3Up7deagSnLguMdWcEtq+5GOy5eb4G0/Ye2 fHSuulIFU5ix8lkw4hCK/sycBVePrhVHTSU4Fb1x1SoX1tt9qSHS2uD9iWCRscv511Hs dTHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680115730; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GrKgNBdgVGDd5tuVm5wP/QWfKRU7XwBSou05qKklH3k=; b=LN/bn3gWxjS7PnOjtsR+HbjoMBPhCydBE++9TPA9dR3gzMF7OABJRPacyz/ngf0xfx hwxKMQ98z4fNBHFcxLvSSHND3cTBn3BG7kA1eAyDY64z54Z7DPMQOPp3tyvge2RGCPje EUBoFEEOjLP1I4cXFwK0VCrTDv75UcWZhP2ZwTEge3HtxZJVT0Bb1IBmiYAIcESMh35L iODfncQhn/eYImsF1dldbd6OdrV9OPMpzI4rd667rksn/dhX9t8mT7Pg20HhKTYeHMQQ QYciK+Hq91EfX3OjdCFVsoMNNh8T1T95FMpAZ5nUaVenbtWmmqSnV8h10HTODyUzkdSH jcIg== X-Gm-Message-State: AAQBX9ebIzYCP0kVdljHT9yhjk/74Onprk7zShduHYxoqq7dyL1Eskmh +j3R6oIP+CVBDn+x+Sz3FX8= X-Google-Smtp-Source: AKy350Z17p+zY9Y3XDg1dbwXrWoAxNYu5kA+LGkZtazrsFODsTnCrhNL91vsa/MRE1g5Ap9lhF2JVQ== X-Received: by 2002:a05:6402:2811:b0:502:92d:4f51 with SMTP id h17-20020a056402281100b00502092d4f51mr24946261ede.1.1680115729529; Wed, 29 Mar 2023 11:48:49 -0700 (PDT) Received: from [192.168.0.103] (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id r17-20020a50aad1000000b005024459f431sm4008559edc.70.2023.03.29.11.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 11:48:48 -0700 (PDT) Message-ID: Date: Wed, 29 Mar 2023 20:48:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/5] staging: r8188eu: code cleanup and coding-style fix patches To: Abhirup Deb , Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: Content-Language: en-US From: Philipp Hortmann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/23 19:01, Abhirup Deb wrote: > This series of patches fixes the coding-style issues > reported by checkpatch.pl for the staging/r8188eu driver. > > Abhirup Deb (5): > staging: r8188eu: add blank line after declaration > staging: r8188eu: refactor block-comments > staging: r8188eu: remove redundant else after return > staging: r8188eu: Replace "<<" with BIT macro > staging: r8188eu: place constants on right side of comparison > > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 61 +++++++------- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 2 +- > drivers/staging/r8188eu/hal/rtl8188e_dm.c | 2 +- > .../staging/r8188eu/hal/rtl8188e_hal_init.c | 10 +-- > drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 2 +- > drivers/staging/r8188eu/hal/usb_halinit.c | 23 ++++-- > drivers/staging/r8188eu/include/ieee80211.h | 82 +++++++++---------- > drivers/staging/r8188eu/include/rtw_mlme.h | 4 +- > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +- > 9 files changed, 98 insertions(+), 94 deletions(-) > Hi, sorry this driver was deleted: Please read: https://lore.kernel.org/linux-staging/92a9442a-cece-4179-fbdc-3c9188da073e@redhat.com/ Please also check on which tree you are working on. This seems to be the wrong one. If you need support I will help you. Thanks for your support. Bye Philipp