From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6F5C4363A for ; Thu, 22 Oct 2020 07:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29659223C7 for ; Thu, 22 Oct 2020 07:56:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="FTrImu4m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2509073AbgJVHz7 (ORCPT ); Thu, 22 Oct 2020 03:55:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:46746 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2508907AbgJVHz6 (ORCPT ); Thu, 22 Oct 2020 03:55:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603353357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G1L1K+pLqf/UxGfuaoyoFjDiUcEiA4in4XnRyEgIr6g=; b=FTrImu4mPRJ6yrUt8DRnKbFPZn3OKJMXN4t/VfmJl5iw4jUj2yc3ObrXiULkDBTrT9+sJp wXtdVda1Cy74dr+SDvRITBJ/De2Wmd09N6dS2bZbCJ/pX4VSxaHsL88ufPD7r32lZ9H2IP KdGhBNfXNQ3fig/9Qz/FRuHOM65myAk= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A1670AC5F; Thu, 22 Oct 2020 07:55:57 +0000 (UTC) Subject: Re: [PATCH 4/5] xen/events: unmask a fifo event channel only if it was masked To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini References: <20201022074214.21693-1-jgross@suse.com> <20201022074214.21693-5-jgross@suse.com> From: Jan Beulich Message-ID: Date: Thu, 22 Oct 2020 09:55:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201022074214.21693-5-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.10.2020 09:42, Juergen Gross wrote: > --- a/drivers/xen/events/events_fifo.c > +++ b/drivers/xen/events/events_fifo.c > @@ -236,6 +236,9 @@ static bool clear_masked_cond(volatile event_word_t *word) > > w = *word; > > + if (!(w & (1 << EVTCHN_FIFO_MASKED))) > + return true; Maybe better move this ... > do { > if (w & (1 << EVTCHN_FIFO_PENDING)) > return false; > ... into the loop, above this check? Jan