From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D16633EF0B8 for ; Fri, 6 Feb 2026 14:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770386672; cv=none; b=BYUaVUVJpU86msMO36QZ18byuMtdRcRKV5G3FirxXyMwc3FgV3upqmZGnRcpvyitTCeAHgd4C6WZ/DZ62mF5SM5jEuxJjqZMzG3GVLmeRtDdrdY8kBIsmBtidvOfxgH8oCGhC9RvSpj+yRU1PTGSfUMlltyDe5Yt7A65SZZhv6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770386672; c=relaxed/simple; bh=e5sHRUDUGHJ76zPoOXJJWKpkAEhjS6mHPn07rZwieGs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NgNslZFst7loGBwLAXrwebVKodFMGO3iCRx+03mJ+ndtRUGxJLuCsvzHCxPTx/5R0TV6rdGivo7YtI0CQtWIzhtPhypwCTtPLuhDcPWr0JKxqO40jZxMNg2kjJvz77QIB6CswWv3YbUx7ZDcTBq3/9rx/zbPa+9CSOSRnIZNTPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=qPCZ4Ghb; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="qPCZ4Ghb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id BEC9DC243B8; Fri, 6 Feb 2026 14:04:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2F7B160729; Fri, 6 Feb 2026 14:04:30 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 50438119D1929; Fri, 6 Feb 2026 15:04:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770386669; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=d70krws98qMbryfn/12Zb3xwhE2iiVZ6JA0PmydolRU=; b=qPCZ4GhbgSvh7oc+x3hfb/WxEKcrK6O2VtHn9ZUnKHIWbmuwpDPS+JVzXwRZvJjY52JV/q jRFNs9CU0xQoxAmTuVScqUmJr3RhJksmzPmC2iDxOIGOKozVtX3K0+pFhuAw87JTmlzOzO Mx7asUoldGGsbCO1CxidWKqAh6wVT4SkqjyaR14D4D/lxH/+TnRz846TduWs57dgblA7K2 qq8aj5PKT39GkueFiEWEvJOcmHo1rod8gM8pqXd1pJ+UJU/zVu6F/+Oy2EP5MnYL2KIUVh AJXEPBPb7T4XHikvoDSeE/Goj7h2+A7djgwt/yvu7WKYngnH526TrWO6uKX5cQ== Message-ID: Date: Fri, 6 Feb 2026 15:04:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/4] drm/vkms: Support setting custom background color To: Cristian Ciocaltea , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Haneen Mohammed , Melissa Wen , Jani Nikula , Andy Shevchenko Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Diederik de Haas References: <20260204-rk3588-bgcolor-v7-0-78d1d01c5ca1@collabora.com> <20260204-rk3588-bgcolor-v7-3-78d1d01c5ca1@collabora.com> From: Louis Chauvet Content-Language: en-US In-Reply-To: <20260204-rk3588-bgcolor-v7-3-78d1d01c5ca1@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 On 2/4/26 21:02, Cristian Ciocaltea wrote: > Make use of the BACKGROUND_COLOR CRTC property when filling the > background during blending. It already defaults to solid black. > > Since the internal representation of the pixel color in VKMS relies on > 16 bits of precision, use the newly introduced DRM_ARGB64_GET{R|G|B}() > helpers to access the individual components of the background color > property, which is compliant with DRM_FORMAT_ARGB16161616. > > It's worth noting the alpha component is ignored, hence non-opaque > background colors are not supported. > > Reviewed-by: Nícolas F. R. A. Prado Reviewed-by: Louis Chauvet > Tested-by: Diederik de Haas > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/vkms/vkms_composer.c | 10 ++++++++-- > drivers/gpu/drm/vkms/vkms_crtc.c | 3 +++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c > index cd85de4ffd03..83d217085ad0 100644 > --- a/drivers/gpu/drm/vkms/vkms_composer.c > +++ b/drivers/gpu/drm/vkms/vkms_composer.c > @@ -475,8 +475,14 @@ static void blend(struct vkms_writeback_job *wb, > { > struct vkms_plane_state **plane = crtc_state->active_planes; > u32 n_active_planes = crtc_state->num_active_planes; > - > - const struct pixel_argb_u16 background_color = { .a = 0xffff }; > + u64 bgcolor = crtc_state->base.background_color; > + > + const struct pixel_argb_u16 background_color = { > + .a = 0xffff, > + .r = DRM_ARGB64_GETR(bgcolor), > + .g = DRM_ARGB64_GETG(bgcolor), > + .b = DRM_ARGB64_GETB(bgcolor), > + }; > > int crtc_y_limit = crtc_state->base.mode.vdisplay; > int crtc_x_limit = crtc_state->base.mode.hdisplay; > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > index 9a7db1d51022..2514c367f710 100644 > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > @@ -4,6 +4,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -228,6 +229,8 @@ struct vkms_output *vkms_crtc_init(struct drm_device *dev, struct drm_plane *pri > > drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE); > > + drm_crtc_attach_background_color_property(crtc); > + > spin_lock_init(&vkms_out->lock); > spin_lock_init(&vkms_out->composer_lock); > >