From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14F7C6FA81 for ; Fri, 2 Sep 2022 06:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235536AbiIBGql (ORCPT ); Fri, 2 Sep 2022 02:46:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235432AbiIBGqj (ORCPT ); Fri, 2 Sep 2022 02:46:39 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 552A6BC813 for ; Thu, 1 Sep 2022 23:46:38 -0700 (PDT) Received: from fraeml739-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4MJpJ63Cl0z67Zm5; Fri, 2 Sep 2022 14:42:46 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml739-chm.china.huawei.com (10.206.15.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 2 Sep 2022 08:46:35 +0200 Received: from [10.195.34.23] (10.195.34.23) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 2 Sep 2022 07:46:35 +0100 Message-ID: Date: Fri, 2 Sep 2022 07:46:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: John Garry Subject: Re: [PATCH 5/5] bus: hisi_lpc: Use platform_device_register_full() To: Andy Shevchenko CC: "xuwei (O)" , Andy Shevchenko , Linuxarm , "Rafael J. Wysocki" , Linux Kernel Mailing List , SoC Team , Yang Yingliang References: <1662030871-182688-1-git-send-email-john.garry@huawei.com> <1662030871-182688-6-git-send-email-john.garry@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.34.23] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2022 18:47, Andy Shevchenko wrote: >> + .name = "hisi-lpc-ipmi", >> + .id = PLATFORM_DEVID_AUTO, >> + >> + .res = res, >> + .num_res = num_res, >> + }, > ...here and in the other cases you have a lot of blank lines, can we > just get rid of them? ok > >> + }, >> }, >> /* 8250-compatible uart */ >> { >> .hid = "HISI1031", >> - .name = "serial8250", >> - .pdata = (struct plat_serial8250_port []) { >> + .pdevinfo = (struct platform_device_info []) { >> { >> - .iobase = res->start, >> - .uartclk = 1843200, >> - .iotype = UPIO_PORT, >> - .flags = UPF_BOOT_AUTOCONF, >> + .parent = hostdev, >> + .fwnode = acpi_fwnode_handle(child), >> + >> + .name = "serial8250", >> + .id = PLATFORM_DEVID_AUTO, >> + >> + .res = res, >> + .num_res = num_res, >> + >> + .data = (struct plat_serial8250_port []) { >> + { >> + .iobase = res->start, >> + .uartclk = 1843200, >> + .iotype = UPIO_PORT, >> + .flags = UPF_BOOT_AUTOCONF, >> + }, >> + {} >> + }, >> + .size_data = 2 * >> + sizeof(struct plat_serial8250_port), > I believe this can be one line. I think so, as we're exceeding 80 char width anyway. > >> }, Thanks, John