From: Wangao Wang <wangao.wang@oss.qualcomm.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: wangao.wang@oss.qualcomm.com, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v4 0/6] media: qcom: iris: add support for decoding 10bit formats
Date: Mon, 1 Jun 2026 13:52:46 +0800 [thread overview]
Message-ID: <e6df389b-cca9-481a-b2b9-5915cd6ff88a@oss.qualcomm.com> (raw)
In-Reply-To: <0fb85345-ea8c-4294-bf4b-220617c9f089@linaro.org>
On 2026/5/29 21:25, Neil Armstrong wrote:
> On 5/29/26 12:33, Wangao Wang wrote:
>>
>>
>> On 2026/5/29 17:55, Neil Armstrong wrote:
>>> Hi,
>>>
>>> On 5/29/26 10:21, Wangao Wang wrote:
>>>>
>>>>
>>>> On 2026/5/28 21:26, Neil Armstrong wrote:
>>>>> Hi Wangao,
>>>>>
>>>>> On 5/27/26 06:15, Wangao Wang wrote:
>>>>>> I tested the v4 patch using the gst command you provided earlier.
>>>>>> The decoded output still has the previous plane misalignment
>>>>>> issue, but all frames are decoded successfully. When viewing the
>>>>>> raw data with an image player at 1920x1080 resolution, the first
>>>>>> frame looks correct but subsequent frames appear shifted. If
>>>>>> viewed at 1920x1088 resolution, there are artifacts at the bottom
>>>>>> of each frame. I've attached the images.
>>>>>>
>>>>>> Also, have you tested the 720p case? I can't get it to run on my end.
>>>>>
>>>>> Thanks for the report but I don't have access to the Purwa platform
>>>>> you use,
>>>>> I've run test with multiple resolutions with display using P010
>>>>> and QC10, and ran fluster aswell and all passed on SM8550 and SM8650.
>>>>>
>>>>> I'll test it on the Hamoa T14S I have which should be the closest
>>>>> to purwa,
>>>>> but it uses the same driver setup as SM8550 so I expected it to
>>>>> work the same.
>>>>>
>>>>> Could you indicate which iris firmware you're using ?
>>>>>
>>>>> Could you try passing the fluster h265 main10 test suite with
>>>>> gstreamer ?
>>>>>
>>>>> fluster download -c h.265
>>>>> fluster run -d GStreamer-H.265-V4L2 -ts JCT-VC-HEVC_V1 -q -s -j1
>>>>>
>>>>> The picture you send looks like there's a mismatch with the kernel
>>>>> and firmware setup of planes offsets.
>>>>> Could you check if there's a Purwa specific firmware property
>>>>> to set for 10bit decoding ?
>>>>>
>>>>> Neil
>>>>>
>>>>>>
>>>>
>>>> Hi Neil,
>>>>
>>>> I also tested on hamoa, and it has the same issue as purwa. The
>>>> firmware used on purwa is vpu30_p1_s7.mbn.
>>>>
>>>> This is the result of fluster:
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) WP_MAIN10_B_Toshiba_3
>>>> ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0)
>>>> WPP_A_ericsson_MAIN10_2 ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) WPP_A_ericsson_MAIN_2
>>>> ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0)
>>>> WPP_B_ericsson_MAIN10_2 ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) WPP_B_ericsson_MAIN_2
>>>> ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0)
>>>> WPP_C_ericsson_MAIN10_2 ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) WPP_C_ericsson_MAIN_2
>>>> ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0)
>>>> WPP_D_ericsson_MAIN10_2 ... Error
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) WPP_D_ericsson_MAIN_2
>>>> ... Error
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0)
>>>> WPP_E_ericsson_MAIN10_2 ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) WPP_E_ericsson_MAIN_2
>>>> ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0)
>>>> WPP_F_ericsson_MAIN10_2 ... Success
>>>> [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) WPP_F_ericsson_MAIN_2
>>>> ... Success
>>>>
>>>
>>> Ok so this works fine, so I'm really wondering if your main10 HEVC is
>>> not properly encoded.
>>>
>>> Could you try playing a well know HEVC main10 files ?
>>>
>>> For example I just tried the 1080p and 4k 10bit files on Hamoa +
>>> fluster and it just worked as expected:
>>> https://larmoire.org/jellyfish/
>>> https://larmoire.org/jellyfish/media/jellyfish-10-mbps-hd-hevc-10bit.mkv
>>> https://larmoire.org/jellyfish/media/jellyfish-120-mbps-4k-uhd-
>>> hevc-10bit.mkv
>>>
>>> Neil
>>
>> Could you provide the test commands? I tried both files and the
>> results from gst still show anomalies, but the results from
>> iris_test_app are normal. I'm wondering if there are any additional
>> settings needed on the client side.
>>
>> Here are my test commands:
>> gst-launch-1.0 -v -m filesrc location=jellyfish-10-mbps-hd-
>> hevc-10bit.mkv ! matroskademux ! h265parse ! v4l2h265dec ! filesink
>> location=1080P_out.yuv
>> gst-launch-1.0 -v -m filesrc location=jellyfish-120-mbps-4k-uhd-
>> hevc-10bit.mkv ! matroskademux ! h265parse ! v4l2h265dec ! filesink
>> location=4K_out.yuv
>>
>
> If I run those exact commands, I can correctly visualize the files with:
> gst-launch-1.0 -v -m filesrc location=1080P_out.yuv ! rawvideoparse
> format=p010-10le width=1920 height=1080 frame-size=6266880 ! waylandsink
> gst-launch-1.0 -v -m filesrc location=4K_out.yuv ! rawvideoparse
> format=p010-10le width=3840 height=2160 frame-size=25067520 ! waylandsink
>
> I have to use the decoder full aligned buffer size because gst just
> dumps the whole v4l2 buffer into filesink and frames are not tighly
> packed together.
>
> If you want to output tighly packed frames, this worked for me:
> gst-launch-1.0 -v -m filesrc location=jellyfish-10-mbps-hd-
> hevc-10bit.mkv ! matroskademux ! h265parse ! v4l2h265dec ! rawvideoparse
> format=p010-10le width=1920 height=1080 frame-size=6266880 ! filesink
> location=1080P_out.yuv
> gst-launch-1.0 -v -m filesrc location=jellyfish-120-mbps-4k-uhd-
> hevc-10bit.mkv.1 ! matroskademux ! h265parse ! v4l2h265dec !
> rawvideoparse format=p010-10le width=3840 height=2160 frame-
> size=25067520 ! filesink location=4K_out.yuv
>
> There's probably a better way I don't know, but in any case gstreamer
> will only use the "frame-size" portion of each frame and process it.
>
> For example, you can convert it nv12 and dump to file, it will then dump
> only the nv12 data:
> gst-launch-1.0 -v -m filesrc location=jellyfish-10-mbps-hd-
> hevc-10bit.mkv ! matroskademux ! h265parse ! v4l2h265dec !
> videoconvert ! video/x-raw, format=NV12 ! filesink location=1080P_out.yuv
> gst-launch-1.0 -v -m filesrc location=1080P_out.yuv ! rawvideoparse
> format=nv12 width=1920 height=1080 ! waylandsink
>
> If the plane offset/alignment was wrong, the convert frames would be
> wrong and playback would also be wrong.
>
> Neil
Thanks. Using the commands you provided, the output file no longer has
the previous issues.
--
Best Regards,
Wangao
next prev parent reply other threads:[~2026-06-01 5:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 9:24 Neil Armstrong
2026-05-21 9:24 ` [PATCH v4 1/6] media: qcom: iris: add helpers for 8bit and " Neil Armstrong
2026-05-21 9:24 ` [PATCH v4 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations Neil Armstrong
2026-05-25 23:32 ` bod
2026-05-21 9:24 ` [PATCH v4 3/6] media: qcom: iris: gen2: add support for 10bit decoding Neil Armstrong
2026-05-21 9:24 ` [PATCH v4 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats Neil Armstrong
2026-05-21 9:24 ` [PATCH v4 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and " Neil Armstrong
2026-05-21 9:24 ` [PATCH v4 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format Neil Armstrong
2026-05-26 7:53 ` [PATCH v4 0/6] media: qcom: iris: add support for decoding 10bit formats Vikash Garodia
2026-05-26 12:39 ` Neil Armstrong
2026-05-26 12:45 ` Vikash Garodia
[not found] ` <12da2953-fe51-4999-9656-2b42a7897f91@oss.qualcomm.com>
2026-05-28 13:26 ` Neil Armstrong
2026-05-28 23:55 ` Bryan O'Donoghue
2026-05-29 8:21 ` Wangao Wang
2026-05-29 9:55 ` Neil Armstrong
2026-05-29 10:33 ` Wangao Wang
2026-05-29 13:25 ` Neil Armstrong
2026-06-01 5:52 ` Wangao Wang [this message]
2026-06-01 8:41 ` Vikash Garodia
2026-06-01 9:01 ` Wangao Wang
2026-06-01 15:03 ` Bryan O'Donoghue
2026-06-01 18:59 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6df389b-cca9-481a-b2b9-5915cd6ff88a@oss.qualcomm.com \
--to=wangao.wang@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®