mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: leqi@qti.qualcomm.com, Konrad Dybcio <konradybcio@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK
Date: Thu, 14 Aug 2025 10:41:57 +0200	[thread overview]
Message-ID: <e6e06ab1-6744-4730-a2a7-be8c66bf74a3@kernel.org> (raw)
In-Reply-To: <172f1a38-d7a8-4799-ad44-f3eea69f297a@kernel.org>

On 28/07/2025 13:08, Krzysztof Kozlowski wrote:
> On 28/07/2025 09:16, leqi via B4 Relay wrote:
>> From: leqi <leqi@qti.qualcomm.com>
>>
>> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
>> including WCD9385 configuration, micbias voltage settings, GPIO reset,
>> and power supply bindings. It enables basic audio functionality for
>> further development. Basic test is good in Hamoa-IOT-EVK board.
>>
>> Signed-off-by: leqi <leqi@qti.qualcomm.com>
>> ---
>> Changes in v2:
>> - Updated author email address to leqi@qti.qualcomm.com.
>> - Clarified that audio is validated with this change.
>> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
>> ---
>>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>>  1 file changed, 232 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
>> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> @@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
> 
> 
> This was not merged, was it? Same comment as other patch, when you have
> entire code ready send entire board. Not chunk by chunk.
> 
> You are not following properly release early, release often.

Why this is still not included in initial submission which happens now?
Either you work Linux style (release early) or, if you decide to wait
till everything is ready, you submit board as one patch, not everything
as 100 different patches.

Best regards,
Krzysztof

  reply	other threads:[~2025-08-14  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28  7:16 leqi via B4 Relay
2025-07-28  9:38 ` Dmitry Baryshkov
2025-07-28 11:08 ` Krzysztof Kozlowski
2025-08-14  8:41   ` Krzysztof Kozlowski [this message]
2025-08-14  9:48     ` Quill Qi
2025-08-14 11:17       ` Krzysztof Kozlowski
2025-08-15  4:12         ` Quill Qi
2025-07-28 13:56 ` Alexey Klimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6e06ab1-6744-4730-a2a7-be8c66bf74a3@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=leqi@qti.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®