Re: [RFC PATCH 1/3] arm64: dts: ti: am6-wakeup: Add gpio node

[Lokesh Vutla <lokeshvutla@ti.com>]

On 05/06/19 11:38 AM, Keerthy wrote:
> Add gpio0 node under wakeup domain. This has 56 gpios
> and all are capable of generating banked interrupts.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index f1ca171abdf8..8c6c99e7c6ed 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -74,4 +74,19 @@
>  		ti,sci-dst-id = <56>;
>  		ti,sci-rm-range-girq = <0x4>;
>  	};
> +
> +	wkup_gpio0: wkup_gpio0@42110000 {
> +		compatible = "ti,k2g-gpio", "ti,keystone-gpio";

This is not k2g. Can you either create a am6 specific compatible or just use
ti,keystone-gpio.

Thanks and regards,
Lokesh

> +		reg = <0x42110000 0x100>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-parent = <&intr_wkup_gpio>;
> +		interrupts = <59 128>, <59 129>, <59 130>, <59 131>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		ti,ngpio = <56>;
> +		ti,davinci-gpio-unbanked = <0>;
> +		clocks = <&k3_clks 59 0>;
> +		clock-names = "gpio";
> +	};
>  };
>