From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D229F3C09F4 for ; Tue, 30 Jun 2026 09:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782813298; cv=none; b=tUiamvx5lC9r1HoTAr6hQwoT+L4ACYT88DoDpWf4L9mthvMD/phfC93GNYyfvYFLtFNjWxC9CcTa3Aio7Hsu+CQvuje2dLqnMaH/de8+C9aUOTQ3KWwIXIXnT5Zv+yafseeKSHek+hmkg3Y5qPE+Lrs+IPSeIQhK3XeLsPWYH5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782813298; c=relaxed/simple; bh=9/Ppmccz0nh+h+90KrlbbTOVf2NpxKIj8/LBK/dP2vY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s8qIFTF9BvqkOLKIsBUWAHnAlwV13h/PVL7Gugo7MIauLA/PSyE6XY9J7Q7utArjBts+SETiZSf9N1Xv9jwkMQw2aonZC27UO/wqZMbwBxVkYITzxHqIicy5tDe9h1WX62sjOjBiScN7pALIpDwEblAtJjDrcCEhd96n/PdkMpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YwyMC1Zm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=awtk58zy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YwyMC1Zm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="awtk58zy" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9moXa1541521 for ; Tue, 30 Jun 2026 09:54:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I4mqX/qPgDfcNPuQAehIBrVbcs3SjlIok8zx5e9pV4A=; b=YwyMC1ZmYoTG3rm4 a4mVHjE/jp6wkHh3Wsih5lo58TJXc1JmrF0eJRXOX1AdOuXCG56ETBSayr0BdnaO PEkZJpVkRvLZWRO6xYEpYTCKjiOOvJ6JeTcIuPCCqXgHnVygfuWyA68ac/ifXTck GjowJSfjUmmVfCmf1JB7g2WSxLeibM8A4RRpE/cavngzQA7NT263IiBh8hxo1GkW R+s4flvvFRLgGIuHYL1wiVi8mULtMtQpv8omiB99+P/rAGhf/1KmTXFUo8wZs5B2 u0QS4h19ASNi/NLJs7t5EDbundKdpo5I4Vrqud8xM+oD3+VilHut8UL0wRoEqpcW Pj4Ocg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f44wp1rqx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 09:54:56 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c8894570b58so1793302a12.3 for ; Tue, 30 Jun 2026 02:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782813295; x=1783418095; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I4mqX/qPgDfcNPuQAehIBrVbcs3SjlIok8zx5e9pV4A=; b=awtk58zyL3ln7/97EqH0vgpCIM9s4f5ME+x2Kz8ruMzbqskJRaWYBawnxYsouUFUCf JPJOAGp70LtQAf9cCCgcUkd8md4HX8kU8vgT07YOGyHqa3kvgDY/eO9LzcjEB6VWrqoQ FScGz8yauvoqWnIFdzyUmluvoPxUhy9KrbKqkmfRyNHauH42o3Oc6XMLBEaZ46ujunjI l/47fUPTN2WxDlPZ80wC+ISa3SxLfFjhnQq1BCUhXrNUGM/rg5AN5KZrZAaIW3StAhJm C4z2IMfLwwBft6Zh+8tk1+75awulIBAdfFCih8fqk6aIRFuR477uZGxCdHQHAd8A7oZM 0lKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782813295; x=1783418095; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I4mqX/qPgDfcNPuQAehIBrVbcs3SjlIok8zx5e9pV4A=; b=Qvk99mt189xZGI2ot83JadVF6TbmWN3yd/6Rr7u6R9r/Ga0SpzbR9qHMK1zlgZFRKV odFYZZ0KW9xdwaa5uFCFMkSKNk9guFmMHCZtiTSmpIXqbnoPor2t89TeA+dI1XjMZlnF 1xDtssOps4f2eD0z0v1HoPOzXGoNmF+ZQpQeKXZQqT4Pj31Q3DQnfdIX38M0KrZ8kxs3 0mf4sBAzCGgD8HYcdKIejx22oZ/5Ky1XMbZojniC0HsxdSHjXchKiH0ZZePuQ4eNBJgm l4mGaCelbkYODtwj+w5RIoyAgn+Mzj6U88S8i/He7oA5pXiIEY6fEDQfHp4yvfAaCpoc 9sow== X-Forwarded-Encrypted: i=1; AHgh+Ro4y9AYlYE704QPA6CdxN9H8YzFjiy0XyGCYZXIbmD25bV5sExH4acJCBp2K8fm1n63IAGpDu0e8S/WUNQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh2gMeDNFOvpIda5UxC3O2YYSLOjIW2aVyLolGafVB/6s0keEv 4IdzMo7gbGPWNHAMeDjLmnLDvO1eLcMXNoTdplsWtoh28ccp2sZlSRNTTzkakK1GMEHkLEbn1Qs pXqw62EaexvQYSjbWTp3ofJIV3HiIHP0SldEvMqaUAGOAXh6y00MKyuUXBD6tsU2zKTc= X-Gm-Gg: AfdE7ckhn41ks7RpWGnlEh+kJ/HrdChGFtbJKWIdg7RgANSv29KSME1UsC0m6hX7ut6 8vZQwwpY8KvDVQocEY1PvSZsbhSSige43umJRzSiQmdnk1/6pAdBeOVydN8DVK7tzwemHIPHmv3 eO4WBCMmezEKLRlmslKG9eyxnzz3UT5wfx6AvxM3r1YmkjxOEwIqZ8gQUqLp5rvCM5bP8u62Azh yJPAxWKsrXP9Oo0Iukzv5n2SBJS7mfkKS/CeJtbFIzhE0dNrbF3uAZH879Bs0L303qJCYebqjWN zzbFI3XMw+9b0vkr9gXVXIGoya9t2XMV2l+Bn7UPy6EYSMbKa6PipJzc1rnl+V4huxN6MKXXq+k wZGgi7mJqfeEtoloV4Y/2TI8jMUK15xX9IUq12e8= X-Received: by 2002:a05:6a00:c87:b0:847:70aa:9586 with SMTP id d2e1a72fcca58-8479f0fb4f7mr2380841b3a.16.1782813295554; Tue, 30 Jun 2026 02:54:55 -0700 (PDT) X-Received: by 2002:a05:6a00:c87:b0:847:70aa:9586 with SMTP id d2e1a72fcca58-8479f0fb4f7mr2380832b3a.16.1782813295136; Tue, 30 Jun 2026 02:54:55 -0700 (PDT) Received: from [10.152.196.198] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a033b21esm1545220b3a.48.2026.06.30.02.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 02:54:54 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 15:24:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] wifi: ath12k: Flush the posted write after writing to PCIE_SOC_GLOBAL_RESET To: Manivannan Sadhasivam , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, mani@kernel.org, Alex Williamson References: <20260623141649.41087-1-manivannan.sadhasivam@oss.qualcomm.com> <20260623141649.41087-2-manivannan.sadhasivam@oss.qualcomm.com> Content-Language: en-US From: Raj Kumar Bhagat In-Reply-To: <20260623141649.41087-2-manivannan.sadhasivam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Z3dnDGzAl96ATfj9VzpBlnq2zbppbctp X-Authority-Analysis: v=2.4 cv=AtDeGu9P c=1 sm=1 tr=0 ts=6a439270 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=r1p2_3pzAAAA:8 a=EUspDBNiAAAA:8 a=fjTVS2QutaehiSyZ5pEA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=r_pkcD-q9-ctt7trBg_g:22 X-Proofpoint-ORIG-GUID: Z3dnDGzAl96ATfj9VzpBlnq2zbppbctp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDA4OSBTYWx0ZWRfX6PUQNX5/3Ks3 LVb44BNexcHJ873y2ZliyH38y372ZuMLH8Rn7x4TYNGus66U7wFe4P2B6Q785cwmuL64pizTFj2 xQT8Ahr1ZtQlC+hKbSbkQ7xWd8nE9ycAJxxFUgsgDkpKrtTJpsqN8t91ZneW9+xCSXNKSUH2Lg0 vguJPyx1Y8L43JrUSkvOIExgYVyGPt/D4vfIqnLNEsaH8b3I51WL7xdVGcoHMFA7pyzepZQo91G tr2IDIcddxuo3ZtnXTItC34nva981QqZjgzNuxzzdb4offuucd+d5ps4f3KJ8RvyYUvXC7WO8w2 D8s6EKfROoPzkciddJk+biasKUumh1kbPhdKv+Q9xpdYxlBxuRIOT9HPJFONQUI0OHAEVSyYmja Ur2xcxXTqlwTRrBRKxfvvYwo4oizZ+ED8WHA/tHOAunxS99rzwLPORplx3VGNBk86a59z4TXcjN E78YWL3qOEpbtjfGFPQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDA4OSBTYWx0ZWRfX6f2ICo8sKBKx BIi0feccE0++G0gHtCZfdUJ9BJ7D7B1RIQZZWOIWjb1Gtf9w5uvl4lyv3t4AjMztyoUGvcj6hgJ 20u6AGIB3Vy8RnRJiDDcx5tFqoLd4H4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300089 On 23-06-2026 19:46, Manivannan Sadhasivam wrote: > ath12k_pci_soc_global_reset() tries to reset the device by writing to the > PCIE_SOC_GLOBAL_RESET register. But it doesn't do a read-back to ensure > that the write gets flushed to the device before the delay. > > This may lead to the delay on the host to be insufficient, if the posted > write doesn't reach the device before the delay. > > So add a read-back after writing to the PCIE_SOC_GLOBAL_RESET register and > before the delay. > > Compile tested only. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Reported-by: Alex Williamson > Closes:https://lore.kernel.org/linux-pci/20260622160822.09350246@shazbot.org > Signed-off-by: Manivannan Sadhasivam > --- > drivers/net/wireless/ath/ath12k/pci.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Raj Kumar Bhagat