From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 119BEC63777 for ; Thu, 26 Nov 2020 11:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96C2F206B7 for ; Thu, 26 Nov 2020 11:21:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=hartkopp.net header.i=@hartkopp.net header.b="Yb5k4FHx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388917AbgKZLVr (ORCPT ); Thu, 26 Nov 2020 06:21:47 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]:19773 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729932AbgKZLVr (ORCPT ); Thu, 26 Nov 2020 06:21:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1606389705; s=strato-dkim-0002; d=hartkopp.net; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=uNCS1aFmz5+GRjbGXLATLfWOc3SHgcCVSH1L0o5r82g=; b=Yb5k4FHxkAX3gmnIslJIjnS8PKtNh14Lf8BlBEOpdcnnJkimu6XN5zQqeLHkrfb/u1 5HtK/h69To3dqIHU2wWCSe3ilzYBvmIJCj0HytcCLZ/jtoDAPjWcHLiRRS2StMXIiCwk BNbmXAb/U/IrwnTZ9KFgxoXW58t1w73nu7VJKwFHK02hYLR3qIGWE0n7Y6En8WzQsD0b 5/DOM46ZzPJb2Hpv8/SQFqJD1IpOqpI5MjpY2OO06onrKHPdaeuIfTxSb90Z0Vs7F4cL dcL61bbHCqtvAFNiJ9jkOlfWR97Zy1hfKV8ktEd2XdNvTdUNozx+i0DxrIUILg/9b6wV U9Cg== X-RZG-AUTH: ":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1o3TMaFqTGVxiOMVupw==" X-RZG-CLASS-ID: mo00 Received: from [192.168.10.137] by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id n07f3bwAQBLgsaF (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 26 Nov 2020 12:21:42 +0100 (CET) Subject: Re: [PATCH] can: m_can: add support for bosch mcan version 3.3.0 To: Marc Kleine-Budde , Pankaj Sharma , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: sriram.dash@samsung.com, dmurphy@ti.com, wg@grandegger.com, davem@davemloft.net, kuba@kernel.org, pankaj.dubey@samsung.com References: <1606366302-5520-1-git-send-email-pankj.sharma@samsung.com> From: Oliver Hartkopp Message-ID: Date: Thu, 26 Nov 2020 12:21:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.11.20 11:48, Marc Kleine-Budde wrote: > On 11/26/20 5:51 AM, Pankaj Sharma wrote: >> Add support for mcan bit timing and control mode according to bosch mcan IP >> version 3.3.0 >> The mcan version read from the Core Release field of CREL register would be >> 33. Accordingly the properties are to be set for mcan v3.3.0 > > BTW: do you have the v3.2 and v3.1 datasheets? Unfortunately Bosch does not give access to older documents, so I tried to concentrate all my downloaded versions of public available information here: https://github.com/hartkopp/M_CAN-User-Manual-History PR's with updates are welcome ;-) Best, Oliver ps. @Bosch Semiconductors - Read the README there! I would like to remove my own collection. > > Marc > >> Signed-off-by: Pankaj Sharma >> --- >> Depends on: >> https://marc.info/?l=linux-can&m=160624495218700&w=2 >> >> drivers/net/can/m_can/m_can.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c >> index 86bbbfa..7652175 100644 >> --- a/drivers/net/can/m_can/m_can.c >> +++ b/drivers/net/can/m_can/m_can.c >> @@ -1385,6 +1385,8 @@ static int m_can_dev_setup(struct m_can_classdev *m_can_dev) >> &m_can_data_bittiming_const_31X; >> break; >> case 32: >> + case 33: >> + /* Support both MCAN version v3.2.x and v3.3.0 */ >> m_can_dev->can.bittiming_const = m_can_dev->bit_timing ? >> m_can_dev->bit_timing : &m_can_bittiming_const_31X; >> >> > >