From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbcHJSsl (ORCPT ); Wed, 10 Aug 2016 14:48:41 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:9507 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753724AbcHJSsc (ORCPT ); Wed, 10 Aug 2016 14:48:32 -0400 Subject: Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda] To: Linus Torvalds References: <20160810053947.GG21941@yexl-desktop> CC: kernel test robot , Al Viro , Chris Mason , David Sterba , "J. Bruce Fields" , LKML , LKP , linux-btrfs , Linux NFS Mailing List From: Josef Bacik Message-ID: Date: Wed, 10 Aug 2016 14:46:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [107.15.72.49] X-ClientProxiedBy: DM3PR14CA0036.namprd14.prod.outlook.com (10.164.193.174) To DM5PR15MB1321.namprd15.prod.outlook.com (10.173.210.11) X-MS-Office365-Filtering-Correlation-Id: 1252c222-29c4-4602-2817-08d3c14ea4b3 X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1321;2:O1P/VM1bQl7Btm2/IvvlhW7OqYm+DaNjJP2xZ/FPllKQMUBJSNh9hkxIyZMGXWuZ7wuC0W8KInNMOs7mdMzE0V5JsE5qtrUUSMeCoPS4DUnEVrBJBtD/NR4gNxMlFbON/ImTx/8x3eFpS4HPp2d+KI+8tvYB4OjjonRCjDTwhEUHDZXvpRIgex2knDcszoN0;3:+gWMx11Xw/2gLZ6a91aVGtcHK4vZDfxAjil+wudlpZFhP0NXKPfPnGXHoAhvzuRONX4aW7sIaMMOfHcwNPzrcbQzZRTQu8MhPFigsVlKW7awM5iCCIaBWZeylTo9GX7h X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1321; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1321;25:xQF0IqaL7BgXeWDpyU/Ra9qIeZoXSL6ty8pVCJ16ywnF3u2DWuHPf8xgoqug+aKjWCuVcx2MGogSNd84vLpHJqy2pN/gYiznF7wwJDv7R3YcP77R1kqBXGInSVFviBozYbLCB5vJYX/C8fIr8HcwhtXL/JMoiCvwlLQuwSEVg0sqVSVwklUVj2YCrovWGs9s8yvTTmxs9e/O0lTtEBltNK/Y1HhzkXBm+TITV2V3+mX4Wzz6xbd5PGeA23HyqGP0N86mqOiG9xzR2DzNnuyuHMhYGMpPQSzrqiQ7Kr0hAZZgHWTHJ1NQHjDHI/qLckgRdb+IDojgQPqOdI+QINM6AtCYoNr27Sp3FRH18GjbBJyh10tGQyuRgXZctLlWJw3O3qbVVH0EZT3qCrGpJ+UJvYxq2fkobRf1fXNhZdrZXIKFpsr6VJjczogC2g7KhKX1m3meuuzphZh0tZGnt0cu/f2xrx+1HTZwLetaI1A0EMCzgh6X8QfAfwix5GDzeFB/EBO5qJGtUuNruuRSePJ7F5LG055edmmWsAbJuR+Ro5+EX9QamkBy/hMQ1CARczdMgdtzNWfq0K2sjsWhODVCH4kreAP6MIxAMJHr6ozbSuAE3i9vR9iin+KZZvwD96U3Qv0ySvMQcsEdNolvVyDL279eijfaW24Thf5NtDIX9TOqcUEvgiE9SGeINjqlHk0JrPLsPcHgwukXbUyBrIEl+g==;31:xmkEeLw6ABSQm8UFLQyo/LuY5yDRTS89aDuqlhDiHNsaPOoVBu4jzvFev2kW/C+cI0njsNhudncgH5CmMQ+NkdZX1uIJVmk+rTyD7DIhVBQvio/E6sVqnbrOY5GKaRarU6xTmf8UUTYF8bxJbyFiuMsXqx9EAULTr94+yWdazwGQy9u/ulwP/qTug7l/AEGny2n9oHrtwdP4wtUQhflnanOVZWgiHbTxVSmP2FlljJ8= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1321;20:C6axNahqPJl6AfUzeWoRZd9UtDC8TalJ80TQY0TcDuRBYzIGgGQEBKuZrqgCGQDRx87wOomctIccVvpDnxcWBT3cC40YvPCg5IWq5fDffNsbEPm4uyFDyh5yEEwVw8O4lqszcLapwq6Us8sFIKFA1k+QS/B6CLTr3CvkMe8esqY=;4:30LyBUvhXycJbCYK7WlgwghJy9W392jyF/euXxwJfSAW0JMDHp67g0l6bE1mEgNbZRrOHllgDeXrRdKAhMPMZN7RkL+Eo7uLKgpJ3Nwg+4rAio7P9kHdN6utSkCtaVWrns2AEsMlubQex0fEHATueW/PJvELqWsWDHcLHd8jQzn/TiZ49+PwlnlVh8NXanW6xHXX505ZTsVdwNyrN5WONtr11bQ4c/JkiIcQLVz/608Is2cY6WuqkkvdS+TRDJKVTCe3Qq8LmQzlLc85n1YH48zBuTTBmY2jMC+1AZoSeL/Vi5IDhZyp+CpNP3mN+Utpm1SqV/ZcNXshwLq33gKo+aWaY2jni4A51P2ibQiur1VbICqiZm6oW5nxKsdvpNsWC/HcG5ZXUq9xxowJIouwmKJcwpY1T6BFjpwUKo8VxafN+1HWICW8gJl40ypitofI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040168)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:DM5PR15MB1321;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1321; X-Forefront-PRVS: 0030839EEE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(199003)(24454002)(189002)(377454003)(4326007)(81156014)(68736007)(4001350100001)(86362001)(81166006)(50466002)(42186005)(83506001)(19580405001)(97736004)(2950100001)(230700001)(19580395003)(31696002)(23676002)(8676002)(106356001)(575784001)(36756003)(105586002)(33646002)(31686004)(2906002)(65956001)(76176999)(6116002)(77096005)(7736002)(3846002)(110136002)(305945005)(7846002)(586003)(66066001)(101416001)(50986999)(64126003)(93886004)(47776003)(65806001)(54356999)(189998001)(92566002)(65826006)(15760500001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1321;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxMzIxOzIzOkV1b0l6ZnFMMGttSTJtVHN0L2dwdThEYk9T?= =?utf-8?B?WlJxOHNBSnd3WTVtRldZajVjUW81SFlFNkgya0E2MXlsN3I4TkpCbXFEOThy?= =?utf-8?B?dGFyM1BhTXo4dS9DZ3Q4K1dRR1BSNFRpTkUyYVRBWXpIZ0RUSjVJZGZ2dlFs?= =?utf-8?B?aEhCSVNIRDV6emhDK3NKOE51N2Eyczd4SnRzUnUrQXVlYzlYOGNpUzZPS3NW?= =?utf-8?B?WnQ4V3VONTJZY0hGSE9Rcm9DTDhmUDIvYjJqQ2NBQ0JQRUt0aFlDNlpQUEh0?= =?utf-8?B?UFB4ZVhvMEdZZkJ4REx5dzE0bFoyYjhCOWoxRnhEZis4QTR6aEdMWHNuWlJK?= =?utf-8?B?WVpGdFRrNGk3RWhzVkM5Q2FyVTdDVFI5enRHVlVRcFBGbEM5akIzRHVMQjhr?= =?utf-8?B?b1h4N0JpaVJIb1ZrREl4OVJib2J5dUNFMG5OZTBodFlRWkVMT281US9OOXF5?= =?utf-8?B?emJ1OEtIVkdqb0l1bHE2ME44RXFZRUZ6VTI4MTVMTlRDaXNHOTJOMlBRNzhy?= =?utf-8?B?VGpNRDFyR2ZNNkpjS3M5NWJGQ2RQc015eFpobHFnMEZRbU52S1hmS21xL3Vl?= =?utf-8?B?d3BRUlZITjF4cjZodTJYVVk1cVYvTG44U3VFVWtOM0IyTUlab1JHVEt2WGtB?= =?utf-8?B?RFVxTHk4WG1MMmZXSTJBYmNCK2U4WjU4alNrT05GOUY2dEk2Uy9ObW1VeW5h?= =?utf-8?B?UnBzMWk4cWhCTmJrcmNab1RNK0F0V0I1TE9LOEVUbWJFam03OStBdG5EakJI?= =?utf-8?B?YVJqN3hGYmdFc0s4eHlzazI2Q3lhRDJXcEVQNW9Tc3pzVGRPK01Jc0VwMkls?= =?utf-8?B?R3dEUTBtTld0WFNySS9vSE1yaVB1ZmFuWEJjVU1VUXhyVUhJZHhxOVM1Y1RN?= =?utf-8?B?ZkY4YUN4Z3dYODdBZmRsUE5Qa3Vzc1JGK3A4bG9ueHo1bU5CWFNpNFJGRVRt?= =?utf-8?B?K2k3WU5GajFPelZ0RmVrM3dUdGttZWl3dlpxZVZ2MDlHVU12K0h2MERvbDVh?= =?utf-8?B?RUp4WFJnWWU0ZlhiQWZiZ0RqaWptK3VwOFpFNk0yVkRSTjhDWENiSUlqVVg1?= =?utf-8?B?YmFLRXdRYWttZmUvSk1iNWw5UmFNNDllYkFNWkhmWjlyYTczWk9UaFlIK1VU?= =?utf-8?B?S2dMazlKa0NpcEg3SjR2eG91bTNYUW1teDZOY3YzMlpqbkVsaUVvMTZvbFF6?= =?utf-8?B?MHZxcGNMdW03UHdwUUtYTzFWN3o0bnROTThsK3ZpbEJCTXYvK0E1OERtaDBm?= =?utf-8?B?SnZMMUNUS2dFVzQrQjJpaVBZbEcrTjczbkFqM0pTb0pDclc4WFRpemRESG1T?= =?utf-8?B?RmhRaWZrVWY2MlNkK0pJblgrUFQ0dDU1VUxWVVFiNTJwU25QdGVXMFhtSVJa?= =?utf-8?B?TU5HbGtvQ1p0VzZ1UEtDbDA1NDJpV0RPOWlwdHhKOXBKbVJibzZwdlNFdzFK?= =?utf-8?B?anh4MU1IRmd2Ti8vemdZeGt1V2F2QlBxQ1hPb3dkb2JDaWdpRDFIcnl0YTdk?= =?utf-8?B?QjBlN0s2WUFBaEZ3ZkdFU05NTE9YOEpiK2J4UFMyRFFYcjhDK2ZUbEsxMmNN?= =?utf-8?B?K0ZKR0hrWk1JZkVicmFBU2wzWjlxL1Y2S0hrcFplMlVmbzRQWGZNTTE1MEJo?= =?utf-8?B?bFdES0JXUEovYkFWSUFDZWtxUUhXM25BQ3Evc01SdHhKK252ekx1VG5xeTNS?= =?utf-8?B?SHo0aUI4WkJTYUl3Ti92VXkwTGdWWmJ2WElndzZ6Szh1cEp6elNoWXg1bElN?= =?utf-8?B?eWp5UmxtdUtDQ0RGNjlkOU5ScDRyY0gyMkNkRFl6QVRPWC9hSzhTczR0cU5s?= =?utf-8?Q?cselfgG8+RAw8?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1321;6:8dyZ3MzrMl2YkdHegEJ0aS2oKqgfsh/Qww0OCdaqSIzIYIDgRFxbnQsAKcpfvzHpOpZjSfLilZWp2dPTybwIvHYIdSNhCHTeFkcCpxOVoYEo2rFRX1mHn1JQOlvjn5lyaVaelse3Hfx8+DkH72WNcaXDc3HmrWJS4nBH6cZJFsyl37PmeWJuK9o0syaPSuRGiffQEtLBfRPEBHnGspuncBOwy6S94Q+CwqJ3cnUx5U24BLBq+ElNnXafn4X4OO+ROA2JuBL/nZ4+MjMBPCIDNLPJvrDok//vNnqtDEibZrw=;5:kBlcMw9BGQ0ZaM1meaggbGGtkZIxKhUqjR0zevTmKiKspJFTG7I/8vh4ZFHdPTZgk+VE2Wm7dOMCtdl9M8Kg+mtiaKtuIc+5ikxzQDTe1uIomC6LMXdpxLd88tzGEz9vsz1Ll3Dx0XGJMh7IH04Ynw==;24:j8PiOq6jCWPZGtjicJ0ev+lqcwNjQ02acLKIDV6z+u9ZeCeSWsE9IbNiyg28Vaqmnu3NBFGAP+feVCJivNXOXVLfCUmFw8rOzPTy6n6DViE=;7:RPX2tEQXUl3DSCbsDgBk5AZwzimFIPr2HBYOfFkZZbPZMMHgA7B8VhaoEg57aI+O9kbLTNFNsvv9ODdDfihVbLEu8ML//z3TctZ5dBKxLpvDEfb5qX027YNybLmoi0N0Srg6qKLXNKNMPb66i+FOG2CnBUZuQfrCquja/7t0loOFXRxH69GXv+vYR0JyYoDo2NsH0x10K9YltBuxtQQQoMLGDRRrPM36+J/c7gBP/3j8lUS2PhTlysla1l0aDZPf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1321;20:WWeZhxgTq/78cVYpA8ws88EAwFClHBsWaHNPIBuuF5APIFgFTtgW5/ieinSQH4Oep4bJShK8XftvmghOfk/+mtJXWBXxPhqFlWmYUkcUpkZSeCUnGNEqenvVu+93qgS6KXNui2bZahV7cL2YChgk+Ffa3Scc2OzY+5kShkBjy5w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2016 18:46:29.3207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1321 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-10_15:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2016 02:25 PM, Linus Torvalds wrote: > On Wed, Aug 10, 2016 at 11:22 AM, Josef Bacik wrote: >> On 08/10/2016 02:06 PM, Linus Torvalds wrote: >>> >>> More information in the original email on lkml. >> >> I'm not subscribed to lkml and for some reason I can't find the original >> email in any of the lkml/linux-nfs archives. Could you forward more of the >> details? > > Done. > So my naive fix would be something like this From: Josef Bacik Date: Wed, 10 Aug 2016 14:43:08 -0400 Subject: [PATCH] nfsd: fix dentry refcounting problem b44061d0b9 introduced a dentry ref counting bug, previously we were grabbing one ref to dchild in nfsd_create(), but with the creation of nfsd_create_locked() we have a ref for dchild from the lookup in nfsd_create(), and then another ref in nfsd_create_locked(). The ref from the lookup in nfsd_create() is never dropped and results in dentries still in use at unmount. Signed-off-by: Josef Bacik --- fs/nfsd/vfs.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index ba944123..ff476e6 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1252,10 +1252,13 @@ nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, if (IS_ERR(dchild)) return nfserrno(host_err); err = fh_compose(resfhp, fhp->fh_export, dchild, fhp); - if (err) { - dput(dchild); + /* + * We unconditionally drop our ref to dchild as fh_compose will have + * already grabbed its own ref for it. + */ + dput(dchild); + if (err) return err; - } return nfsd_create_locked(rqstp, fhp, fname, flen, iap, type, rdev, resfhp); } -- 2.5.5