Re: [PATCH 1/1] dt-bindings: spi: Add separate binding for dh,dhcom-board

[Marek Vasut <marex@nabladev.com>]

On 10/16/26 10:57 PM, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
> 
> The dh,dhcom-board SPI device uses spi-cpha and spi-cpol properties,
> which are not permitted by the trivial-devices schema. Move it to a
> dedicated binding file that references spi-peripheral-props.yaml and
> explicitly allows those SPI mode properties.
> 
> Fixes below CHECK_DTBS warnings:
>    arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dtb: spidev@0 (dh,dhcom-board): 'spi-cpha', 'spi-cpol' do not match any of the regexes: '^pinctrl-[0-9]+$'
>          from schema $id: http://devicetree.org/schemas/trivial-devices.yaml

How come this did not trigger until now ?

> Assisted-by: LLM
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>   .../bindings/spi/dh,dhcom-board.yaml          | 46 +++++++++++++++++++
>   .../devicetree/bindings/trivial-devices.yaml  |  2 -
>   2 files changed, 46 insertions(+), 2 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
> 
> diff --git a/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml b/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
> new file mode 100644
> index 0000000000000..ed213cbe9b04c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/dh,dhcom-board.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DH electronics GmbH on-board CPLD trivial SPI device

This does not look quite right, since compatible this is used only on:

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts

        model = "DH electronics i.MX6ULL DHCOR on maveo box";
        compatible = "marantec,imx6ull-dhcor-maveo-box", 
"dh,imx6ull-dhcor-som",

So the whole

        spidev@0 {
                compatible = "dh,dhcom-board";
                reg = <0>;
                spi-cpha;
                spi-cpol;
                spi-max-frequency = <54000000>;
        };

Should probably use a different compatible.

Christoph, what device is this on this board ?

(and this change should only be applied with RB from Christoph, I do not 
have the hardware so I cannot tell what it really is)

> +maintainers:
> +  - Marek Vasut <marex@denx.de>

@nabladev.com

> +  - Frank Li <Frank.Li@nxp.com>
> +
> +allOf:
> +  - $ref: spi-peripheral-props.yaml
> +
> +properties:
> +  compatible:
> +    const: dh,dhcom-board
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-cpha: true
> +
> +  spi-cpol: true

Wouldn't it make more sense to allow those properties for trivial SPI 
devices in general ?

[...]