On 11/10/2020 1:31 AM, Rafał Miłecki wrote: >  10.11.2020 04:31, Florian Fainelli wrote: >> Provide an empty 'ports' container node with the correct #address-cells >> and #size-cells properties. This silences the following warning: >> >> arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: >> ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed: >>          'ports' is a required property >>          'ethernet-ports' is a required property >>          From schema: >> Documentation/devicetree/bindings/net/dsa/b53.yaml >> >> Signed-off-by: Florian Fainelli >> --- >>   arch/arm/boot/dts/bcm5301x.dtsi | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi >> b/arch/arm/boot/dts/bcm5301x.dtsi >> index 807580dd89f5..89993a8a6765 100644 >> --- a/arch/arm/boot/dts/bcm5301x.dtsi >> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >> @@ -489,6 +489,10 @@ srab: ethernet-switch@18007000 { >>           status = "disabled"; >>             /* ports are defined in board DTS */ >> +        ports { >> +            #address-cells = <1>; >> +            #size-cells = <0>; >> +        }; > > You can drop those two lines from board files now I believe. > > grep "ports {" arch/arm/boot/dts/bcm470* > + arch/arm/boot/dts/bcm953012er.dts Yes, indeed, thanks! -- Florian