From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DE972D6619; Tue, 12 Aug 2025 21:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755034164; cv=none; b=a7x2Z6ba1JE9eB0nFj+7Wa0LBMlQi73VWdWqxZylVyVPminrF7lY1qVIgzG22p1Ta4/p3U/cB5cxEO7SBUgxoYQcjZHjQlEq+8tpNR2qFRsED0DuiQpJl8sZp72nYAKdRX697ChuNvXfhGlkNalqGdnuBfWk5i31dW1ZxH1GSVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755034164; c=relaxed/simple; bh=m+K/AlYj6sFpDViOsi+7YVub9fm04RF467U2Bgdxm4s=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=gBxcu16xJaUgwXuQK2lIYBSlDb8394TiiWdlWpN+1Xy7crg7qHxQ628juw8wHhz5R/EppKu3/0WlTZ0up8LhgEnGRwqivjUNb0S66l9KSikP7TqvuST8NKw7Dhj+6tVMDBQq3/7JdiR2g6FahfBkbn4IJEMCSm9cPjgBs+ynzj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=Bznh4Yn7; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=M2JsktkK; arc=none smtp.client-ip=202.12.124.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="Bznh4Yn7"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="M2JsktkK" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id DCDCD1D0011D; Tue, 12 Aug 2025 17:29:20 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-05.internal (MEProxy); Tue, 12 Aug 2025 17:29:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1755034160; x=1755120560; bh=lbs7wklbxmzRpXaW4E8RAy4dqvO2ltqvef6oxyXevvA=; b= Bznh4Yn7V0ie0KyWMyoEvQJOHUzGPETC4xDdS5LF7U8Gz/yqR02DoUEYwpHi9xXO oD0ZF757xFqRVjWs+iRYj2bR5KSZB6zEhpThknnA9IMT4Ke417jWsil5YiPdfOSd Ye7fARZtAZ1T9SCZlttSpCiUe6U4NoI59G1CrRy72wm2IZ++nRpVTBI5ChDQBLIq /ANAQIhrNdXNfUQTUXblXDrS14c0nZ6BP2T65JkCZT5XNAaFPm/2M0somUYgwyO6 TtQuP79u+X/kuU9IxsgfaS5Gmt6M1PJQ5MQHCHqxLV1E5rPyzib2owmPDPBo3Xo8 ZOFmIwXF4HGr4g0FUYEA6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1755034160; x= 1755120560; bh=lbs7wklbxmzRpXaW4E8RAy4dqvO2ltqvef6oxyXevvA=; b=M 2JsktkKAbWoNiQGi2MqZqVunuBW4m5QszIndv/w35s6JwiA7qVutZ23PBjn8lZRe lg+VVATG9a0U0ckFqA2w0/N8GMmlpcmMLqEul3bIrBYx/DLw2T5wf13f6Ibe8zlD +Dr/nAJoojfYoIo7VdE5sZc+TM16p66owEKX7ghoFNgBar465QIl0mxh2yEDFawJ +cIaAapu+cTFyO4XwA/VV9PwLuVA+9WwXqAiqxJJyds4Ba2SeBYzDkdB+HbnKjOw bU8I7oeC7dPk2RsvcExcqM8/a4axXesp73b3jTL++c29cKW8NjgTjOP5q0b5sRzI RnwYuUrNiZn20GV4Ko4ow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddufeeigeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrnhgu uceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrthhtvg hrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefggfevudegudevledvkefhvdei necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnh gusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepudeipdhmohguvgepshhmthhpohhu thdprhgtphhtthhopegsrhhglhessghguggvvhdrphhlpdhrtghpthhtohepmhhpvgesvg hllhgvrhhmrghnrdhiugdrrghupdhrtghpthhtohepghgvvghrthdorhgvnhgvshgrshes ghhlihguvghrrdgsvgdprhgtphhtthhopehrohhsthgvughtsehgohhoughmihhsrdhorh hgpdhrtghpthhtoheprghrnhgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmrghs rghhihhrohihsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprghulhhmtghksehkvg hrnhgvlhdrohhrghdprhgtphhtthhopehrohgssehlrghnughlvgihrdhnvghtpdhrtghp thhtohepuggrlhhirghssehlihgstgdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 4915470006A; Tue, 12 Aug 2025 17:29:14 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 12 Aug 2025 23:28:31 +0200 From: "Arnd Bergmann" To: "Rob Landley" , "Arnd Bergmann" , "Bartosz Golaszewski" , "Linus Walleij" , "open list:GPIO SUBSYSTEM" , "Yoshinori Sato" , "Rich Felker" , "John Paul Adrian Glaubitz" Cc: "Michael Ellerman" , "Steven Rostedt" , "Paul E. McKenney" , "Masahiro Yamada" , "Dave Vasilevsky" , "Geert Uytterhoeven" , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <543b5d42-a007-4f13-824e-1f8a27dfbd33@landley.net> References: <20250808151822.536879-1-arnd@kernel.org> <20250808151822.536879-5-arnd@kernel.org> <543b5d42-a007-4f13-824e-1f8a27dfbd33@landley.net> Subject: Re: [PATCH 04/21] sh: select legacy gpiolib interface Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, Aug 12, 2025, at 20:28, Rob Landley wrote: > On 8/8/25 10:17, Arnd Bergmann wrote: >> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig >> index d5795067befa..d60f1d5a94c0 100644 >> --- a/arch/sh/Kconfig >> +++ b/arch/sh/Kconfig >> @@ -462,6 +462,7 @@ config CPU_SUBTYPE_SHX3 >> select CPU_SHX3 >> select GENERIC_CLOCKEVENTS_BROADCAST if SMP >> select GPIOLIB >> + select GPIOLIB_LEGACY >> select PINCTRL > > Is there a reason to have both rather than having GPIOLIB_LEGACY select > GPIOLIB? (Does the legacy one ever NOT use the new one?) The way I've staged the series was 1. add GPIOLIB_LEGACY as an always-enabled symbol in 6.17 2. add the 'select' and 'depends on' for that symbol in 6.18 3. turn it off for all configs that don't select it already Having GPIOLIB_LEGACY select GPIOLIB does sound like a nice idea in stage 3, but that doesn't work with the first step that's already merged now. Arnd