From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934594AbdJQJLg (ORCPT ); Tue, 17 Oct 2017 05:11:36 -0400 Received: from mout.web.de ([212.227.15.14]:49924 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933198AbdJQJLa (ORCPT ); Tue, 17 Oct 2017 05:11:30 -0400 Subject: Re: [PATCH 4/4] char/snsc: Delete unnecessary braces in five functions To: Dan Carpenter , linux-doc@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , LKML References: <20171017084919.oa462je5y45otrw7@mwanda> From: SF Markus Elfring Message-ID: Date: Tue, 17 Oct 2017 11:11:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171017084919.oa462je5y45otrw7@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:0qFBJ6bW2D/YkOfkpRN624X94q7zCUozyVyrE47OGFdnyV93Fsk Z10/94jgc/hLRllQo9UswwhXIkY1VT0vzwpAhj2JIyGPEMTITx8+4H9oNKDfOHcjoKKFvTm DP53rLbAHIyhrU1brZFZo9TrLMIIgzGa6b6+ElsvCqbQ33u2sNNa99e4IqRk5EOTVIEsjpE 2I8x5tz4atA6aZF5AxxTA== X-UI-Out-Filterresults: notjunk:1;V01:K0:r3AwnShc4h8=:a0QBvsreb7DqV6Kh6ZVCPs EnrZPocViKD1LpI67q5DvmA6p88fuuzZAVGRzLjesGQ0X0DyZwopyPeGuAE5Scxrelm+CS90v AQ0qpIvQr2fW4gRBxdHMhuWY8SFfxTnmG5fS3wtSLFnjSEpJJdYGnuThW2mw0bwFqJr1juhpW 5Ic1ZRBe1kQR3Kx8ee+1icMGoujpT2wJ9oq5HZCfpM/3sTc4IOtTcmsGvwuQL/qJSGinSSU1H 3ZHatx8/WV9JI80G+Hr/6LQ2B7LycvVOQA/2UdLr4omiiGi9668usyNAOc2Lw2AV6lWKM8Kgs 2PLIH3XYDvRfQ69BBUg9mvr1ERbq+OY5FGZ5pZMcK7jFOWWd90Wi1UkTWeL2C7Aue2gy1j1TC dJOsY7VAicyOvdG8mTp6/uslLhPbGEzC4B+pDXaFpyopuYfsyyCfqNbCKYixJJeImKoznwnaq CblL626FIoy5BvfEBOKDA3+Ev+9hE0tmg2/7bUjLNAKE4beMdkJscG/OOsbJcV4zfc3epg77H kThDmANzMrduyfr9bEkY3C4LPSEfG1uVcVEusAIOvWS9ac4K4UHoO9puxGlHREHOeH6XFj2HN ZjxmT2JUSIOEA/XOPH08PsvpLtB0PXPseKwlLsZF/N10QJuWfIEiJ80baNjksNiQsbuRTgiV/ Nrylhz/9l9KOPtVqVCuRxqX9byAFeo3HBwfMKaACi1ZlKY4VIVu9TNiFzxd9ojFiZUW7q9Zcy D85Y27XAnv1aRA1ypLpidf7OrgQhktdD70O720MDYnYdZ1kOndyh4stW6pYDNg1HhMPG54Ne4 G+pKBsHsYIDwJsUUYt8Hjh2NwmqczGTGxwMSszckb7lffcep2M= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> /* ...or if we want to block, then do so here */ >> - if (down_interruptible(&sd->sd_wbs)) { >> + if (down_interruptible(&sd->sd_wbs)) >> /* something went wrong with wait */ >> return -ERESTARTSYS; >> - } >> } > > Multi-line indents get parenthesis. How do you think about to add such an expectation to the section “3) Placing Braces and Spaces” in the document “coding-style.rst”? Regards, Markus