From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f98.google.com (mail-pj1-f98.google.com [209.85.216.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 765D935A930 for ; Wed, 29 Oct 2025 20:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761768679; cv=none; b=aOlu/ufJwOGa3cMkEsYdg8c+6NIYz4+1h90/jEAzbp05DUVsuTpZ5NyBu8lr6v1/ExsCwkL5JQkP9au0FJZC1xnqqCqlqQVRYg/0btQR1mlHrLm4SUAP8YWmLTQJOWBRoJWrlsnSer9bUmtgyP96QrOhPTTOI4LDVOiHXQsgj/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761768679; c=relaxed/simple; bh=5kwQs+9suNK+4X2kC6NQpa2xZpkIM4WvOQV/rVeCd9g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DUWc6KBvAdyG10fyvnVdV6LjLyyWH38F1dFFuOlc+EjjLS4VDWhoMIE2P91HHpsBSNWiivND4r9jl8lwYl/58TzF68aidSk1Q8YntEWzUKaAjkl8lYoA0LqtMONL3gPfE5lvba4mMbzqZyaIYOG22K4i6kqYk3sB3m6hLSUbE7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VRqH9COy; arc=none smtp.client-ip=209.85.216.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VRqH9COy" Received: by mail-pj1-f98.google.com with SMTP id 98e67ed59e1d1-33e27a3b153so352677a91.3 for ; Wed, 29 Oct 2025 13:11:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761768676; x=1762373476; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Fd8815X1RUqCabuTvLuXZbJKbv+i/J65/QtTSTp+uo=; b=endzCEAmeOVmQjZdmZG4jK9eZbBlRI9b9i0O2Pa0odFs7QkwxRLk7YW/nV+l5aKNWW fSgogyodT6nKPSYLWRTnPtwQegDSv46U0voQ8xi0LaeSpPrAcVSzThkFsuak4s2mLoeN 7v6fLBKC4SjXL6LXsOUD02sUjrLQCVY3yqoQqWurBx4CyqDC7Nsa+9KJuhGL7NXZ7KNl j7+w67/8UktPtANWeFp2lE8kBbe4dlwFKjXCtKNGrLm2wAotrQi+qK7MxJ06liA1dJlG +jI1Kfu63sEXeSUeJi5sN4z9zTBf9+wJhAh8TLNeAjx3cpGnV5FcPTrMnAzperheQUsq t4mg== X-Forwarded-Encrypted: i=1; AJvYcCXJwjJIblCVIu4hoLJtwwSjvF1N4fFcyvw+wu+6E1zZDIRUiBaxA6TEDl5yI5OVw1RZ7A7dK2yU4Vi9xt8=@vger.kernel.org X-Gm-Message-State: AOJu0YxFzjTkg8z94jPDNl5QlB2wd8qYcBYhIU3DuxxWmN2KG/DD6EB2 prrUFH3qOpEUio/WL5kE8ny/MGJtS1D7ix9rpAqQ0uXj6JDNompGK3lUzsUlpiwtYak8PXUFht2 YA/mxsenrm16ruL6rWWQ5QkA+RmvKi0QecrMf82cxSNdpCFkyUpX1UjuKDAA+yfE/enO2MBR0jZ twEqN+2RIQB+PmuWGD+Szyl+RjIofGI1WV0IZRcxv9bBDhwXi24CtFFQXqLz9ibKgqjUXmMg+jC qQgLj0pgnmKy3AWnjH55ZGW X-Gm-Gg: ASbGnctjNoZUTLbGTxtO9KG9kX+RRtCuQX94vo9Q3TEzTfLOt9w2Auuq2nYXSbJ/ZmF VnEc/pGOQYWFNQ4icv2NCY7sXq/lIcSwDrhlnp44DQ2S+MRU3hOX0HthmaWYgGIJINmGoMaOdSu 2NZPCmUBJqBTqd8yQUwu8oZhVMgCENi5vYz7NeICthKRRLJHnXseahlYuD+5pcwKQ4/Ulv3qF2B EzsK5X4q03F9IOVtC9kdEKhzLDnoOArlZN0o5sUQdoRHgZU5AMa7RKqHh9SDwFICLb2ebVvzoA0 fHA9YTW3DY6YZ40MsRWoI3Qgv56t9bsrwDMDfwGHZRHSBvk3tklVF2qP3UFdoK5qnPshu2Kk5Lb 7+j/LED4zqwvyDMLThp1c83KJ9Mv9fxlHnLJYHRD3/Vk9joS4/5cUTIf8nqUAbtGsvpeu3/4ms8 hFVvpWVJi0PBBp1kdDpn+VXTDvwNnQuXsBm0RyK2pD7g== X-Google-Smtp-Source: AGHT+IHP7q/05bMQEbxObiBlHl9BEM6f3ovc3efn0T0OgcuiZiijD6UNnfZhqKj/zRNSKarA5gsHWswC3EaY X-Received: by 2002:a17:90b:2246:b0:30a:4874:5397 with SMTP id 98e67ed59e1d1-3403a25f8b1mr4691024a91.9.1761768676161; Wed, 29 Oct 2025 13:11:16 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-101.dlp.protect.broadcom.com. [144.49.247.101]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3404f19105asm14798a91.0.2025.10.29.13.11.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Oct 2025 13:11:16 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-87c0e0d12ddso9320386d6.3 for ; Wed, 29 Oct 2025 13:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1761768675; x=1762373475; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=2Fd8815X1RUqCabuTvLuXZbJKbv+i/J65/QtTSTp+uo=; b=VRqH9COyQnoCZWeentq1MpsDlcFrHGrr7wFpjdKTpGOhE1NzM8K5NxCGt9zMQ+AwNz NB7Sm/7h9vRCXHcKVeYmk8r3uo/aLoKD3i519ujHOcvcTNmFZPDAFdrbITHjy3hNbAuX p1Z9q+hg0ot8dNfx4QCmoLBMkJdxvza2qjO94= X-Forwarded-Encrypted: i=1; AJvYcCWSPxqfmKc2RF7xWzXUjQlR1aLn4M1CiBxpNmxK8WBCHIgphyy8w1CDIoobf0gv1/K1y4LhlbRFmnlembE=@vger.kernel.org X-Received: by 2002:ad4:5d44:0:b0:87e:d590:89b7 with SMTP id 6a1803df08f44-88009afcaa5mr61772176d6.19.1761768674858; Wed, 29 Oct 2025 13:11:14 -0700 (PDT) X-Received: by 2002:ad4:5d44:0:b0:87e:d590:89b7 with SMTP id 6a1803df08f44-88009afcaa5mr61771726d6.19.1761768674483; Wed, 29 Oct 2025 13:11:14 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fd3c48f20sm91342686d6.32.2025.10.29.13.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Oct 2025 13:11:13 -0700 (PDT) Message-ID: Date: Wed, 29 Oct 2025 13:11:10 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] PCI: brcmstb: Add a way to indicate if PCIe bridge is active To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20251029193616.3670003-1-james.quinlan@broadcom.com> <20251029193616.3670003-2-james.quinlan@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20251029193616.3670003-2-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/29/25 12:36, Jim Quinlan wrote: > In a future commit, a new handler will be introduced that in part does > reads and writes to some of the PCIe registers. When this handler is > invoked, it is paramount that it does not do these register accesses when > the PCIe bridge is inactive, as this will cause CPU abort errors. > > To solve this we keep a spinlock that guards a variable which indicates > whether the bridge is on or off. When the bridge is on, access of the PCIe > HW registers may proceed. > > Since there are multiple ways to reset the bridge, we introduce a general > function to obtain the spinlock, call the specific function that is used > for the specific SoC, sets the bridge active indicator variable, and > releases the spinlock. > > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian