From: Vasant Hegde <vasant.hegde@amd.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Sairaj Kodilkar <sarunkod@amd.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
joro@8bytes.org, suravee.suthikulpanit@amd.com,
robin.murphy@arm.com, ashish.kalra@amd.com, will@kernel.org
Subject: Re: [PATCH v2 1/2] amd/iommu: Preserve domain ids inside the kdump kernel
Date: Tue, 2 Dec 2025 10:51:40 +0530 [thread overview]
Message-ID: <e71c0c1c-8bd8-4ad7-a8ed-c5b005a72788@amd.com> (raw)
In-Reply-To: <20251126152040.GH520526@nvidia.com>
Jason,
On 11/26/2025 8:50 PM, Jason Gunthorpe wrote:
> On Wed, Nov 26, 2025 at 01:51:27PM +0530, Vasant Hegde wrote:
>> It looks like on non-SNP system in kdump path, if it fails to reserve old DTE
>> table, it tries to allocate new one! Looking into code again, it may be OK to
>> fail in that path as well.. so that we will have common flow.
>
> If it allocates a new (empty) one and does a full flush of the iommu
> that would be OK?
I did look into the init sequence. We have kdump check everywhere which will
create issues. We will try to cleanup that path along with your suggestion to
remove flush from ste_dte_entry() code path. I will have separate series for that.
-Vasant
next prev parent reply other threads:[~2025-12-02 5:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:11 [PATCH v2 0/2] " Sairaj Kodilkar
2025-11-21 9:11 ` [PATCH v2 1/2] " Sairaj Kodilkar
2025-11-24 14:44 ` Jason Gunthorpe
2025-11-25 6:32 ` Sairaj Kodilkar
2025-11-26 8:21 ` Vasant Hegde
2025-11-26 15:20 ` Jason Gunthorpe
2025-12-02 5:21 ` Vasant Hegde [this message]
2025-11-21 9:11 ` [PATCH v2 2/2] amd/iommu: Make protection domain ID functions non-static Sairaj Kodilkar
2025-12-02 5:23 ` [PATCH v2 0/2] amd/iommu: Preserve domain ids inside the kdump kernel Vasant Hegde
2025-12-19 10:29 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e71c0c1c-8bd8-4ad7-a8ed-c5b005a72788@amd.com \
--to=vasant.hegde@amd.com \
--cc=ashish.kalra@amd.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=sarunkod@amd.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®