From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 992A5378D96 for ; Mon, 16 Mar 2026 09:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773653849; cv=none; b=g26iDzHbkDkUH8nYGR3PQmYvHyyaT3Nqtzv1QPuCKp4x0Ln4bfiLhlRhGW3/mlR8E7u6lfz8s140ZvH44bgV/DB1Z7scpvVl8TqqhlAgatElWP4k936T3TCOV+nL0wVGXvDZSJlHgs2H72Rq5NnmMylaXoupGlqZ6xAAohBSQbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773653849; c=relaxed/simple; bh=DbvCh94rpXDv7WluBYY0jPnaT6bK+G4/fSGmypdNLWA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OxDXCDIQ/F1KkbOSss1obj1VThTLjVGnHMxQh4cJPBQFGFPSj20KNStHnh3MJkRBwJ82FyTUzIa+Yt15eqEPG+GpcbK2OKm9D0vzkbHYO8Ae2tkepBbwg3Eet6TQD76AYAdcM07icwHPrA00KyK/4pfa9Im+aMn8wyj/MkQrCro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XXrGPEhd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VFF3PfS+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XXrGPEhd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VFF3PfS+" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64jMN538903 for ; Mon, 16 Mar 2026 09:37:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vL0QFFEBT4HCnrXbSuzaMv26nwLRIwkg7ItBWYHCTmw=; b=XXrGPEhdVCVgz8gy tBUuw4mAsye4Rzy8JRLsrKWQHrc/dOuqFBtj43aBPfI+oH2OpN8BR9cHcsAOXf27 ghIcwGPyo3x6cLnmvGFFSBnXPx7VM5bE2ilYfu5uexAercdLZx9FJYua/b6I6tfq 5TRhGz0W5GooLJYsA3wVewwaCatvZEI3yI4sRqAPf004cy8jCLnZw1DfXw2Nvksc hzwAJBgKUk2mxRtQdKmNt9FZUGRWpHNN/0PvD8uT0Foka0AtMi5bPLGk9Xo1VrVr QLJ1VppyRyJinhwo20w5Ied8dtp6swAKwWk0lXLNiGKLdMPgPSTDsmCQI4M2bAW2 PR2LrA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvyy5n216-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 09:37:27 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2aec805eec4so28396035ad.1 for ; Mon, 16 Mar 2026 02:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773653847; x=1774258647; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vL0QFFEBT4HCnrXbSuzaMv26nwLRIwkg7ItBWYHCTmw=; b=VFF3PfS+w2vKaBMA2coDKnxumgvN+m2r16tk19Ql9X8Yh5acpmTGhyRGH8aLXnDunn +QaTOHHQTNdxrGI5dRKr0XSzhj/vYI0wBoV/oC6tyArxdUc9brFE+B36XJHERmphu1kK cMSsXNCavTwJ2tNlw4AdPp89Yk5ITiDc1ZnmgS6xewUrNeaAmZwZKY76vdUSmrIX7zr7 6fR1xh2hqb4bETokQrU76FPyzOkyth5Mua+7QBY/ePCGZM6vH+9NtMayAnwhQN4qIJUv LxKiQCL6ZH9QENkPYfTlpRqj8sf3VWJO570OWgfeRMUoKmoaqQulGY9fi/iu32qc8xUd GRqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773653847; x=1774258647; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vL0QFFEBT4HCnrXbSuzaMv26nwLRIwkg7ItBWYHCTmw=; b=PFvDVffswmAfMvKkIBAkV9SBfP6gqPCY3H3AntNSkygx1ocpI0c9x/MTogtR7wH7kt CM5zkQg0dXMMc3ls74gUGKb8p4TTptBKcRwshvE37bDDuszKKd2ZcTV95/20hj4nKbw3 Ff32ckcpFwe/zZYZKxE9HE2l3hx2lM+VCccgV+Xdk9FcTRuHXp8wWzFdurEIq3QCmPTa gpsFkaDDyjVdqb5hC2d0zSungEXtBBn0NEBC2MPsA8XlNX2hA91UJJv9/YhMdQyJjuw4 cNl8Y5opa6F/CfR2Zp3X5sm6YLjl1XPqi9stiQkrlpuM76ebNIq3/UfvGCTHqBTF43p3 Y4+Q== X-Forwarded-Encrypted: i=1; AJvYcCVqoh5JAaxZpl3QJakt/J8M9EYMTe2jo7NKj/h8iCJ/ycKYaTBoW8nCCa8bYR37g7gEBs3fC5XD+lrnWDk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyvv01lEpRPOL6BQJz05k947Md4AA1ypwtUM1LAi/5Ef7ApVEkW jJQf40nHUnR6+bWMoKRV4yBeRhkhax7tU53LljfCM5JlB2AiGRPnacrzJ5pYvWAM8D9V7sKjnBF SDstiW8JmAn1NbxnOLIiEHhxNpsBdHkOE2YYU0zP2uEYYKgvZtsCAt6EIfFMGvz1RPM0= X-Gm-Gg: ATEYQzxuNc0WwVRn9TZzjYXZXgnlurHtwF9BZLK+vvr3QmBlQVqseYNnPiTXWMDm4ej VtxsrORASv9lVwJSEyjTgE21YXMlLcodQ3zIYmFm5Ckgvvz5nnl7Bn9Si21evafM2JSUTQUsvR4 6oP7n6QPHrkUuvqEGSTDtqFW2dV7sdxxEX20dpQGUpfJ6IFWITv05nNafZLLRnS7X8+aZkv3OJY CG9KXJJnSLJTV53zIb155mvcPcj35iYOreZpaERXR9cirawM5SBzeNypm0b7UFWPVI9ov4JgJ+7 9ockEgrMv56p/ryBcB1VAJLxkD1xvrZ5UqbpP0rDkCBCr5mERNkTCUK/NWCgjYlmN8PLjSevcOn rdn3Y5ZkZrS1dag4540QAGSaxm9OZuUq/tNCURlE1JiNrmdzgnEnDNe0LkjrsVDJ39ajQ5pqwNM 2teFcHFFgqPiMOSwc19MP60A06esWrlxbZDw== X-Received: by 2002:a17:903:3b8e:b0:2ae:3afc:eb42 with SMTP id d9443c01a7336-2aecab04a1dmr114987565ad.38.1773653847157; Mon, 16 Mar 2026 02:37:27 -0700 (PDT) X-Received: by 2002:a17:903:3b8e:b0:2ae:3afc:eb42 with SMTP id d9443c01a7336-2aecab04a1dmr114987095ad.38.1773653846553; Mon, 16 Mar 2026 02:37:26 -0700 (PDT) Received: from [10.79.197.144] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b05f0ab2b7sm15664115ad.39.2026.03.16.02.37.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 02:37:26 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 15:07:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] dt-bindings: embedded-controller: Add EC bindings for Qualcomm reference devices To: Krzysztof Kozlowski , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <20260313-v04-add-driver-for-ec-v4-1-ca9d0efd62aa@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: IOhLp6qE1Tf5503LreBY4bQK6wwZO_Uk X-Authority-Analysis: v=2.4 cv=QOxlhwLL c=1 sm=1 tr=0 ts=69b7cf57 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=P-IC7800AAAA:8 a=gEfo2CItAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=yKxla6SPEuOvPVJYePEA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=d3PnA9EDa4IxuAV0gXij:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-ORIG-GUID: IOhLp6qE1Tf5503LreBY4bQK6wwZO_Uk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA3MyBTYWx0ZWRfX4NeOqt5tIdY+ H2hHlDpOkn/gLbW9H7HLtxJ73t/zbg9/C1Pv/GlpQ5hYEIBZlUQ5kOxC14sMj5b8GHDd0tYWySu qPiJV8SF5qMblu7OzgJZRogH8KyAmyRZVKvbnmypT++4PtE68xIq3vRvztbPbHEik24k3/1/LHa yPK5xXyEhtFUriRcAbya+4ZWLb9VheHPmgaI6ToxgGIndQQJKUFLrOWPfUuDOXjLGk/XmvMoi4v IZA6D+l4v/rfXyIGc92doxbD6cE0d1z54J4JKpCT64Th6iBgFLk+IWJ5vjOZXWN4DYAbWvZ/1cu paDpQ1Ju5AeIAvHkQTabCgSTRzt/XJ24M1yiLG0CGmKg8AdMcw5BRzUllOGEWBi1hqMI+k7Gm/5 i8afQCelzUSRipux8Eejm7tMU92g7s3al/FfxxplcMIt++FBlkyW8poKuASOoruhw3j8CLEaO5N 30oLaF1X8of5DeHXqOw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_03,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160073 On 3/14/2026 12:31 AM, Krzysztof Kozlowski wrote: > On 13/03/2026 11:29, Anvesh Jain P wrote: >> From: Maya Matuszczyk >> >> Add bindings for the EC firmware running on Hamoa/Purwa and Glymur >> reference devices. >> >> Signed-off-by: Maya Matuszczyk >> Co-developed-by: Sibi Sankar >> Signed-off-by: Sibi Sankar >> Co-developed-by: Anvesh Jain P >> Signed-off-by: Anvesh Jain P > > A nit, subject: drop second/last, redundant "bindings for". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Noted, will fix the subject in v5. > >> --- >> .../embedded-controller/qcom,hamoa-ec.yaml | 56 ++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml >> new file mode 100644 >> index 000000000000..baa95f06644a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml# > > Filename must match compatible. > > This is a standard review comment already documented in kernel and your > internal guideline, no? > You're right. The filename qcom,hamoa-ec.yaml does not match the base compatible qcom,hamoa-crd-ec. Will rename the file to qcom,hamoa-crd-ec.yaml and update the $id accordingly in v5. Thanks for the review! -- Best Regards, Anvesh