mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriel C <nix.or.die@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: e1000_netpoll() , BUG: sleeping function called from invalid context
Date: Sat, 18 Feb 2017 00:53:12 +0100	[thread overview]
Message-ID: <e7262413-f221-964b-8442-9f0d6fa3a4bf@gmail.com> (raw)
In-Reply-To: <CAM_iQpVznUMtGJwC1Toa4X=dVtDigefZavUcQfFPk22YN5BxbA@mail.gmail.com>



On 18.02.2017 00:44, Cong Wang wrote:
> On Fri, Feb 17, 2017 at 3:38 PM, Gabriel C <nix.or.die@gmail.com> wrote:
>>
>> My card seems to use the e1000e driver which is buit-in..
>>
>> Anyway here an objdump -x :
>>
>> http://ftp.frugalware.org/pub/other/people/crazy/kernel/t/objdump-x_e1000.ko.txt
>>
>
> Found disable_hardirq() but not disable_irq().
>
> Are you sure the kernel warning was emitted by this binary rather than
> some old one?
>

Yes , I use an clean build , remove any other files in /boot && /lib/modules before installing the new build kernel.

I've asked Thomas before I send this to lkml and to you and he said :

..


It's a real issue. netconsole calls disable_irq() which might sleep from an
interrupt and preemption disabled context.

 > [85362.132801]  __might_sleep+0x6b/0x80
 > [85362.132803]  synchronize_irq+0x33/0x90
 > [85362.132805]  ? __irq_put_desc_unlock+0x19/0x40
 > [85362.132807]  ? __disable_irq_nosync+0x4e/0x60
 > [85362.132808]  disable_irq+0x17/0x20
 > [85362.132810]  e1000_netpoll+0x3d/0x110

Though, what's weird is that the e1000_netpoll() does not longer call
disable_irq(). It calls disable_hardirq().

That got changed in commit 3111912971251 which got into Linus tree during
the 4.10 merge window. So it is in 4.10-rc8.

Confused.

...

  reply	other threads:[~2017-02-17 23:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 21:20 Gabriel C
2017-02-17 22:38 ` Cong Wang
2017-02-17 23:16   ` Gabriel C
2017-02-17 23:24     ` Gabriel C
2017-02-17 23:25     ` Cong Wang
2017-02-17 23:38       ` Gabriel C
2017-02-17 23:44         ` Cong Wang
2017-02-17 23:53           ` Gabriel C [this message]
2017-03-01 17:13             ` Thomas Gleixner
2017-03-01 22:32               ` Gabriel C
2017-03-01 22:38                 ` Thomas Gleixner
2017-03-01 22:44                   ` Gabriel C
2017-03-02  0:04                     ` Gabriel C
2017-03-02 12:22                       ` Gabriel C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7262413-f221-964b-8442-9f0d6fa3a4bf@gmail.com \
    --to=nix.or.die@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®