Re: [PATCH 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A

[Rouven Czerwinski <r.czerwinski@pengutronix.de>]

Hi,
On Wed, 2024-10-23 at 14:44 +0200, Rouven Czerwinski wrote:
> The LXD M9189A is a 1024x600 MIPI-DSI panel.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  .../bindings/display/panel/lxd,m9189a.yaml    | 64
> +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> 
> diff --git
> a/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> new file mode 100644
> index 0000000000000..49cee8865cae1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LXD M9189 DSI Display Panel
                   ^ is missing an A
> +
> +maintainers:
> +  - Rouven Czerwinski <r.czerwinski@pengutronix.de>
> +
> +properties:
> +  compatible:
> +    const: ronbo,rb070d30

This is the wrong compatible.

> +
> +  reg:
> +    maxItems: 1
> +
> +  standby-gpios:
> +    description: GPIO used for the standby pin
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: GPIO used for the reset pin
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Power regulator
> +
> +  backlight:
> +    description: Backlight used by the panel
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> +  - compatible
> +  - reg
> +  - standby-gpios
> +  - reset-gpios
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      panel@0 {
> +        compatible = "lxd,m9189a";
> +        reg = <0>;
> +        backlight = <&backlight>;
> +        reset-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>;
> +        standby-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
> +
> +        port {
> +          mipi_panel_in: endpoint {
> +            remote-endpoint = <&mipi_dsi_out>;
> +          };
> +        };
> +      };
> +    };

Fixed both for a v2 of this series, will wait for more feedback before
resending.

Best Regards,
Rouven Czerwinski