From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbcIAIzr (ORCPT ); Thu, 1 Sep 2016 04:55:47 -0400 Received: from mail-db5eur01on0106.outbound.protection.outlook.com ([104.47.2.106]:39304 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752396AbcIAIyD (ORCPT ); Thu, 1 Sep 2016 04:54:03 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dsafonov@virtuozzo.com; Subject: Re: [PATCHv4 0/6] x86: 32-bit compatible C/R on x86_64 To: Ingo Molnar , Andy Lutomirski , "Oleg Nesterov" , Al Viro , Andrew Morton References: <20160831135936.2281-1-dsafonov@virtuozzo.com> <20160901061846.GA22552@gmail.com> CC: , <0x7f454c46@gmail.com>, , , , , , , From: Dmitry Safonov Message-ID: Date: Thu, 1 Sep 2016 11:19:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160901061846.GA22552@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR01CA0012.eurprd01.prod.exchangelabs.com (10.164.74.150) To HE1PR0801MB1737.eurprd08.prod.outlook.com (10.168.149.149) X-MS-Office365-Filtering-Correlation-Id: 868c9a75-7b82-4a9f-c4d4-08d3d2410a88 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1737;2:D/h+pdZ54PyYUxGIsYNL5llY4MoxsfxoP+VgRzlOKiovJPmoFKiConiEfO+MMPFYbkfDISx7KBxxju8BKkFkKipb0j60mZIFXCGZX8It2LKHkytHSUOFdQPFUqIjps3xb8UsF++QfagIqTFif18SziRD+z1phOkG01MvhF9gUt1gyRUplga6/JyZjKvcnp3e;3:w9tE6PEDIyUz6j483f2NWNUT97/8GRWPrv4PW78N9G0UAwS/3HKZa1EpnJLZ4YuhwgdBGT95KrFzNoZbmL9OGK1s8hu0PxSkex7WhwuqVhGIr6FCtOZbBXgu4CapbPoo;25:VwIANSsO1d+N+iGhA6exahti1YiNgsRlcaP8pFRYBnlalrpb46gyzDw/a50ANZgtosi5R4S1JOp+EsbeApC32Zc8eZEqYrNRojXayEWyJLTfM/BVQhxP4I4/Vyv3LovCLstMyFyWaMYXnZv7L3k5CQY3QCOQ6umRI4FfiMO4+0CXP2mCVbnVBfkA/VD6b456x2M4wiJMncqIOjFENoTbmgb81BivWCHgEsD74uk5PIo/G2gem9NAKLr1FDYBbmIJPpuhoibGUftIy5NXFI3X0S1jhqVT29bMCacjIDG13kdugFi1GLRHF3A3aaH1ra7lXt/ixCrDyG19NEjv15SmbJ/em2bxQmi/as4Sm+RQn7YTCz2TC5BXPykN2QD8nzSKXr+aO5LyjNZOHRn7SVyjOIYPLRTFcXR2jHvXFDwe8YA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1737; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1737;31:N6VOEM/0+sRLopN1f1AsMbcCsJ/o1RhI7K+buyjVXUviK/d8kOu+U4PCYE7l2T9xfOLGxdGK8KBkI98XtqJ+YdQbf4DWULONxP6gT8yPfUSZ5Sjsnb4DJbYkv3aarxeom19SNZSgnYD7qSHvogiuDhWM2wMUk1NbdBxvAvNVmr49pv396BCrpZ4RL0pEheuRLmMXbR3moVkonfdncT1MOl9Ix2XTIvEgzEKHaZRkero=;4:hq144KUuikdov+PjCSsr2M4IaT6emgUPDn3ZcRwQadP7Yf94olWgbTkIcUOEf7cR6KLPh8JT+JV0lb92Lbk9GDybDBMSI7evlnbEIRGmfO6Fi//Aq1nouGmyLq1jY/e5DKQ6WhzL6lat/SJ/FIgU3rLkJKeTb127+J6SkNjWYSR8I1Hv9FdMeQlpalJMu+MLoy9YpBDHH2+iRCqgAnqe8P2/UMsmmSyS8VeJX5fIwUekX3DjOIw5t4ILATFyfOEOaJuYxqVv/vD4LIDydZeFUqTuIrT+8a5ui+Tzj0siOlCvG1LYFx4+BzfYsZkwfKljTRw+Gf872hhPVRIzDUB2/0iNiXwGOph0pMtlEZ3rCEcdSaFXGSu2wcOriVeWup14RtolnRxPihu0qsbJHIDCwClY9t+ZjDcNtu/UKuJGoYk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6042046)(6043046);SRVR:HE1PR0801MB1737;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1737; X-Forefront-PRVS: 0052308DC6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(189002)(24454002)(377454003)(65826007)(305945005)(86362001)(107886002)(42186005)(4001430100002)(65956001)(66066001)(65806001)(31696002)(19580395003)(81166006)(47776003)(81156014)(7736002)(7846002)(33646002)(5660300001)(31686004)(77096005)(64126003)(19580405001)(8676002)(50466002)(189998001)(106356001)(2950100001)(5001770100001)(36756003)(105586002)(101416001)(7416002)(4001350100001)(586003)(97736004)(23746002)(6116002)(3846002)(92566002)(83506001)(4326007)(54356999)(68736007)(230700001)(50986999)(76176999)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1737;H:[10.30.26.154];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0801MB1737;23:qipLMzsDihd6AqeZ/zCbRsIYmjoJ4Vsw4at?= =?Windows-1252?Q?J4F1i8jZaWZcZOK3zuVL4tVB5QshZUJXndOXq0ZyNNXXlwXNaYVNVgHe?= =?Windows-1252?Q?KXWJaq+DX6aPLwHtfq1dhV1yTY+bri3eNqU3nL3jj17Lb6A/W1TmHzBd?= =?Windows-1252?Q?pJJG5TsXMuKFTVvKfY4df6FmRuTDqaLjVLoJvO1icOFDOInd+xRnKeim?= =?Windows-1252?Q?oR3KE8OKEu6yLxlJoT7Y4k7y/9T6ZUjnGjjxhcqI8oNU9HzQv5yiVqRA?= =?Windows-1252?Q?Akhw/ZKsfnqUXs2o5hPTUJebMmOaft63Ivag44KETnm25/aXrTJ5OKUP?= =?Windows-1252?Q?Dxk/yXtGCeNv6uLEV+/Zm9ihSd1KUIzkHfBoijvLISkCkxWTL4/qRmda?= =?Windows-1252?Q?swfjDnwLoJMpAPG9HrQivaRegkw/Y7hqiETQJiHKQ0qujG95DnCd5wGI?= =?Windows-1252?Q?2fyQpRl5TBBdCUMklv8DfZaSLsWe0qAn/gRaXN5dCDnIXi5ikczpaNUP?= =?Windows-1252?Q?xnwyjPGcfuPu8mWoF9DHvXNorQ8v+42Z/xYlvex5jx0vNdkVC3ezhwDN?= =?Windows-1252?Q?Jjih5EUzlZEsSXKA6qFBV9FEMwsMpOdWBWXblIXxb0TbGOMgct8gss00?= =?Windows-1252?Q?DoIH+40ENhYsx6Lqx2FanxLja+IN9zY2+wjxOGY4BfgN9dI0MGC8QuKZ?= =?Windows-1252?Q?xdn7b9bOomp2ag1+36RhOrombVhmnzs1XzGx0+ILpcbXPp8NzFYWTQb+?= =?Windows-1252?Q?8tVqPG4xqhxRUvjFdxk+JwVJhtX+RrSvsT+AkyvivAoDapBXJiMiOCUq?= =?Windows-1252?Q?Bn2oT5w3bTqoH+HHnOSavK9ZOvWJBC/8U+UhdnWHOwwbynkeVZtnACuA?= =?Windows-1252?Q?OQ6/YpbAwxF7HBcp1K+DgkuRSwGpzhbU6fwcZcUe8xXD3Q/uF0NGrMIT?= =?Windows-1252?Q?+hIodrHqAEg5m3byFXcXVmiYkGhIgrqL15CZkC+0Z01z6p07WSQYdkNJ?= =?Windows-1252?Q?X1uUTJSM4l4+EzjnzJz6U7gZfYULOViqv5DYxrLSVh2Ph7YyOpuhd/EO?= =?Windows-1252?Q?Fpv7RFfBxcoULK41t9ewQqgRfEjbEaaB6w7/3CtSnMX7VAt9s/Amrcy6?= =?Windows-1252?Q?Dz2FR14kUgh6uDRYu9b1i3uVSTdthVun0DDEKTfB9T320R/uqtF1qOZk?= =?Windows-1252?Q?8hAqp8Sgpwu+J0QKWCoVbHOP7KkBLg/5sxNau17hP5Lhy83zfzBoqHn2?= =?Windows-1252?Q?DTLxa9FBZ3IwQ4jNBc3LTcVbMK26RxaNXWMgF6Vu5wkY2Mjpdwuj5YcZ?= =?Windows-1252?Q?aCx3PuOq62xlU5QX2wsxucRj3fCvqHkltxLVhMmINvMpsiSDPMgMTmq/?= =?Windows-1252?Q?e3XZJVYc8F24Kj9rRfDtBJlsUHmBfii4oMXdvdVdKA19VEzeh2o9CPRo?= =?Windows-1252?Q?CsRnJamCfk78NlQFl35AOMkMhWhbDXSn+OhbQDrTBDZrYp59Icm8WmlB?= =?Windows-1252?Q?g9N4+yLA=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1737;6:D5MUw/W7ARnba5lIH24VleHQ+NT3MqTewZ93/L5DN+TBm+FgrdjKNZK/uRLzqYz77lbsW8ARrwNhL9wvD5exOLMZT+nRrjcrey8U/58gvRsBliLS+R72zVbttVcwuM+K7X4rJ/HxZJnEjDfL6/L/YYICtHUISDZPyFWj2boRYReQF/JxA0EmDnihjim7jz8uoxBFINA4ofF8K5K1zdlQ8Pc1i5I8q1tNsgx2FQq0jIMf5FbxQ2tvyDxnxvdSAPbgJjq6sVOL59Q79zRGm13L0YaLeZeXf8p1OoBkbVv7nd2NgPYZhR0o58IcN1lr355B;5:6vcqmWWNSIO+rnEkL+Jvn4sCEs6WWZ3sJAJniPULdWhgEaQZbmptVc01cmeEphrE1fSBXhmtjmzfG+RQQC6VROgRCXk6+6Oo97NriJ1048moMumzrD/FYV4tyazzdPxGsWToIsPrnlBxN78ia3tAog==;24:8omgCMYcBrL2Vz8KPon5SW4jRG9cDUGeVbCYSGigjChzkB4PTTuu9V3ePhgw5y+tDugnaKjpWLOVnnZkox18wQ/kX/KdtmUdF5jggJdk7tA=;7:5JWQ5Q0NRnr94LHP2fzZTUK2JAlGi4VR/q/qVZopEbNVuinZn/AlqUD48+xTz5JNI5vCS2rqLE3ZmQWUO2RE8CnFrmsXGpwala5LR0c1BU+WhtmE2xHyja+8OD7xry2vlS0+XOBOUuAftbju7ttc3pg/Q2klbyH8uKbMUwHSI1/fJaZkVAPVQufnTXQHbJgfipF1Z0KTxMHF7a9ZOFJadeUTu5Wqzlmip1w/+EXrVerL7AI/784Ckkt0d+BK+sms SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1737;20:66V354qvP/fb2FRdGvhRSksmbigKa6bSJmpr1FME9MwM3sMWrULdMs8T7UWrk+S5JlXkTdwqoLd8dXA4eZGpB+UN3x1Q7zNO2Yx4kVQOmi/pEt1uAflOi4ZmuWpnBRpIM4t/RS0B8UM48fYpto4OG+jwokxBIzfyPMrwYFDExpQ= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2016 08:21:56.4841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1737 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2016 09:18 AM, Ingo Molnar wrote: > > * Dmitry Safonov wrote: > >> Changes from v3: >> - proper ifdefs around vdso_image_32 >> - missed Reviewed-by tag > >> arch/x86/entry/vdso/vma.c | 81 +++++++++++++++++++++++++++------------ >> arch/x86/ia32/ia32_signal.c | 2 +- >> arch/x86/include/asm/compat.h | 8 ++-- >> arch/x86/include/asm/fpu/signal.h | 6 +++ >> arch/x86/include/asm/signal.h | 4 ++ >> arch/x86/include/asm/vdso.h | 2 + >> arch/x86/include/uapi/asm/prctl.h | 6 +++ >> arch/x86/kernel/process_64.c | 25 ++++++++++++ >> arch/x86/kernel/ptrace.c | 2 +- >> arch/x86/kernel/signal.c | 20 +++++----- >> arch/x86/kernel/signal_compat.c | 34 ++++++++++++++-- >> fs/binfmt_elf.c | 23 ++++------- >> kernel/signal.c | 7 ++++ >> 13 files changed, 162 insertions(+), 58 deletions(-) > > Ok, this series looks good to me - does anyone have any objections? Thanks, Ingo! There is a nitpick from Andy about checking both vm_ops and vm_private_data to avoid (unlikely) confusion with some other VMA in map_vdso_once(). I'll fix that for the next version, which will be ready to be applied, if no one has any other objections. -- Dmitry