From: Haiyang Zhang <haiyangz@microsoft.com>
To: Sitsofe Wheeler <sitsofe@gmail.com>
Cc: KY Srinivasan <kys@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [BISECTED][REGRESSION] Loading Hyper-V network drivers is racy in 3.14+ on Hyper-V 2012 R2
Date: Fri, 18 Jul 2014 21:30:49 +0000 [thread overview]
Message-ID: <e72aea6f4eab48e6851fdc4d32b89fa2@DFM-DB3MBX15-06.exchange.corp.microsoft.com> (raw)
In-Reply-To: <20140715050832.GA28549@sucs.org>
> -----Original Message-----
> From: Sitsofe Wheeler [mailto:sitsofe@gmail.com]
> Sent: Tuesday, July 15, 2014 1:09 AM
> To: Haiyang Zhang
> Cc: KY Srinivasan; David S. Miller; devel@linuxdriverproject.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [BISECTED][REGRESSION] Loading Hyper-V network drivers is
> racy in 3.14+ on Hyper-V 2012 R2
>
> On Mon, Jul 14, 2014 at 10:39:48PM +0000, Haiyang Zhang wrote:
> > > -----Original Message-----
> > > From: Sitsofe Wheeler [mailto:sitsofe@gmail.com]
> > > Sent: Monday, July 14, 2014 5:31 PM
> > > To: Haiyang Zhang
> > > Cc: KY Srinivasan; David S. Miller; devel@linuxdriverproject.org;
> linux-
> > > kernel@vger.kernel.org; netdev@vger.kernel.org
> > > Subject: Re: [BISECTED][REGRESSION] Loading Hyper-V network drivers
> is
> > > racy in 3.14+ on Hyper-V 2012 R2
> >
> > Thanks for the tests! I will make a patch that can automatically retry
> > smaller memory allocs when memory is insufficient.
>
> This concerns me a bit - why would there be insufficient memory on a 64
> bit VM with 4 GBytes of RAM just after startup (presumably the host's
> memory isn't the issue)? Additionally, while things might fail just when
> things are starting up, doing ifup eth0 at some point later succeeds so
> whatever issue it had seems temporary.
>
> Perhaps it would be wise to adding some debugging output to see if the
> allocation really failed and why...
Actually, there will be debug log in dmesg if the memory allocation fails.
But it didn't show up in your dmesg. And since it can be recovered by
"ifup eth0" later, the NIC must have been properly loaded (buffer alloc was
successful but took a bit longer time). I think the larger receive-buffer
size (16MB) may take longer time, because vzalloc() may sleep. And, that's
why we don't see the bug with a small buffer size, because the allocation
is quick.
Could you try put "LINKDELAY=60" into the this file?
/etc/sysconfig/network-scripts/ifcfg-eth0
And see if the problem goes away?
Thanks,
- Haiyang
prev parent reply other threads:[~2014-07-18 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 20:18 Sitsofe Wheeler
2014-07-07 16:54 ` Haiyang Zhang
2014-07-07 18:13 ` Sitsofe Wheeler
2014-07-11 5:52 ` Sitsofe Wheeler
2014-07-11 15:25 ` Haiyang Zhang
2014-07-14 21:30 ` Sitsofe Wheeler
2014-07-14 22:39 ` Haiyang Zhang
2014-07-15 5:08 ` Sitsofe Wheeler
2014-07-18 21:30 ` Haiyang Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e72aea6f4eab48e6851fdc4d32b89fa2@DFM-DB3MBX15-06.exchange.corp.microsoft.com \
--to=haiyangz@microsoft.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sitsofe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®