From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933177AbcIELqN (ORCPT ); Mon, 5 Sep 2016 07:46:13 -0400 Received: from bes.se.axis.com ([195.60.68.10]:54548 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932209AbcIELqJ (ORCPT ); Mon, 5 Sep 2016 07:46:09 -0400 Subject: Re: A potential bug in drivers/net/ethernet/synopsys/dwc_eth_qos.ko To: Pavel Andrianov , Lars Persson References: <1403c768-7ed1-dc5c-38ae-ac91f876a175@ispras.ru> CC: , , Vaishali Thakkar , From: Lars Persson Message-ID: Date: Mon, 5 Sep 2016 13:45:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <1403c768-7ed1-dc5c-38ae-ac91f876a175@ispras.ru> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX04.axis.com (10.0.5.18) To XBOX02.axis.com (10.0.5.16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, Thanks for the notification. I agree that we should register the device after all initialization has completed. A patch will be sent shortly. BR, Lars On 09/05/2016 10:26 AM, Pavel Andrianov wrote: > Hi! > > There is a potential bug in > drivers/net/ethernet/synopsys/dwc_eth_qos.ko. In dwceqos_probe there is > a registration of net device (line 2879). After that initialization of > common resources is continued (lines 2918, 2924, 2941), but at the > moment handlers from net device may be already executed. > > Should the registration of net device be at the end of dwceqos_probe? >