From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0247D1386C6 for ; Thu, 27 Jun 2024 09:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719481189; cv=none; b=TAGgVfqlOuDTvmA1eftX95Gc+ctgEUOdQjL/aWsNK6CRmHQtxxzsL5MOUlM7t1JHGkf/OkHZp0o5WvE4hDO2SfZ8SUNYaxYXBGuPFJEjVH/cY6HnWih4jfD8yXNO9bX8WRN3yymV28bOZBrnlmR7IIfk66lkOgW41bjuaA3PqE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719481189; c=relaxed/simple; bh=lxTZXKZuxfotuscn6ZIT1ZAkADWhWpvVGjic8HteS5E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JXaRFz/K6DYYNiFStl7DKdwPLZKCQqsRWhwQNdNN7E3Ym/7blgO5vSUArhN1aA2H+NzOgkkf+miF5DjFzHX1hqe9lR/PBqOhZQHBh8n5JR9UnmstGvbSTktwDSC/lppU55NLhzVkmB8quXq2h6q4HHb/or2Dmi+04dceS6eEPSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=W0FT3aMa; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="W0FT3aMa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1719481174; bh=t84FHH9Qz2oscsWXd253HB7jbbaRf6bF8zfUqJ67FIU=; b=W0FT3aMa2lrw4vE48d5nRgT2oomXuhZveVPMuMb6bPxOLENPJQF1KyFmsMD6tgZD114M1zrg5 5vs+v76Q8Vjbg1JOz2iFOQCVWjQk9nNR8d7uo/oavDQUTTYrt6VygU4pfAkGLiqgAoY+1Wx14EI gpwLaa0IlK/JSdRU7GtHwO96QrRSMmToMP2uPtRBfZJjm29mCK1T++0IWSnHc95Op7zpMpOKcpm xy9fn/U45R5QPrR2eaJHPtGEnXzUtaqCXjfA99iqrJR+e/BDWjze1HGJx8TzKMdrDMGk8JlqqLk I+oIP2rZv8blW3Z/zlDCEQVApbUqawtBERQ9w4N6UMnA== Message-ID: Date: Thu, 27 Jun 2024 11:39:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/10] media: rkvdec: Add image format concept To: Dan Carpenter Cc: Ezequiel Garcia , Mauro Carvalho Chehab , Hans Verkuil , "Greg Kroah-Hartman" , Alex Bee , Nicolas Dufresne , Benjamin Gaignard , Sebastian Fricke , Christopher Obbard , Detlev Casanova , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240618194647.742037-1-jonas@kwiboo.se> <20240618194647.742037-9-jonas@kwiboo.se> Content-Language: en-US From: Jonas Karlman In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Report-Abuse-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Complaints-To: abuse@forwardemail.net X-ForwardEmail-Version: 0.4.40 X-ForwardEmail-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-ForwardEmail-ID: 667d33569aa1b906e1d3e383 Hi Dan, On 2024-06-19 09:21, Dan Carpenter wrote: > On Tue, Jun 18, 2024 at 07:46:32PM +0000, Jonas Karlman wrote: >> +static u32 rkvdec_enum_decoded_fmt(struct rkvdec_ctx *ctx, int index, >> + enum rkvdec_image_fmt image_fmt) >> { >> const struct rkvdec_coded_fmt_desc *desc = ctx->coded_fmt_desc; >> + unsigned int i, j; >> >> if (WARN_ON(!desc)) >> return 0; >> >> - if (index >= desc->num_decoded_fmts) >> - return 0; >> + for (i = 0, j = 0; i < desc->num_decoded_fmts; i++) { >> + if (rkvdec_image_fmt_match(desc->decoded_fmts[i].image_fmt, >> + image_fmt) && >> + index == j++) > > I really don't care for this j++ which is tucked inside a condition. > >> + return desc->decoded_fmts[i].fourcc; >> + } > > int fmt_idx = -1; > unsigned int i; > > for (i = 0, i < desc->num_decoded_fmts; i++) { > if (!rkvdec_image_fmt_match(desc->decoded_fmts[i].image_fmt, > image_fmt)) > continue; > fmt_idx++; > if (index == fmt_idx) > return desc->decoded_fmts[i].fourcc; > } > > return 0; > >> >> - return desc->decoded_fmts[index]; >> + return 0; >> } > > Don't resend if this is the only issue, but if you do resend could you > get rid of the j++? Thanks, I will send a v6 later today/tomorrow and will include your proposed change. Regards, Jonas > > regards, > dan carpenter