From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756552AbcISKCJ (ORCPT ); Mon, 19 Sep 2016 06:02:09 -0400 Received: from mail-by2nam01on0068.outbound.protection.outlook.com ([104.47.34.68]:11487 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755172AbcISKCA (ORCPT ); Mon, 19 Sep 2016 06:02:00 -0400 X-Greylist: delayed 7308 seconds by postgrey-1.27 at vger.kernel.org; Mon, 19 Sep 2016 06:02:00 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/amdgpu: mark symbols static where possible To: Baoyou Xie , "Deucher, Alexander" , "airlied@linux.ie" , "nils.wallmenius@gmail.com" , "Deng, Emily" , "cpaul@redhat.com" , "Nath, Arindam" , "Zhou, David(ChunMing)" , "Liu, Monk" , "Zhang, Jerry" , "dan.carpenter@oracle.com" , "StDenis, Tom" , "Daenzer, Michel" References: <1474207775-16768-1-git-send-email-baoyou.xie@linaro.org> CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "xie.baoyou@zte.com.cn" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Mon, 19 Sep 2016 12:01:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474207775-16768-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:e5d2:5583:7841:2f5c] X-ClientProxiedBy: AMSPR02CA0051.eurprd02.prod.outlook.com (10.242.225.179) To MWHPR12MB1309.namprd12.prod.outlook.com (10.169.205.21) X-MS-Office365-Filtering-Correlation-Id: 0477d967-7090-437f-9af4-08d3e073fcc0 X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1309;2:t5PbV1PF8+KIfdBNtiS+mrWr81a4Uesa00r5fflbvPwKb+bh4iDQni5xKfEhh3+cKxq5y5u+m0R3PmPVhnabKOF7QkmGJR+PGJZ+VAz6RX9gmsQAan+dH/n80TsQY7mx1PKznK168yEPgv6v5NeviOO+BF+3z9J8YjVTkGQNMlSVtQ/GcVYQaRMGcq+HCwJV;3:F9YjMGnFfkofPJV41JtcvKjdzSsTvG/8Dl25VmL+C5xga1myGC2TVZqfq+wCYtP2UVTzCPZr/+5XAnQ4qoc9/3bludIYvrH7TBgmvyprBQkWw1j0xfXyQNDwe/XbfQiC X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1309; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1309;25:rZryRweiYVOfGvVZ9rD0nOHNw8orMGSt0PGZs5f+sZG0Mvqx5pZWxNIwPkkcxuLA0HEjLYzww8hQJnj/jzwukj1tKNagOffBhcht/mnFXoo/NZhHgbURYijkrHteXoYtxWBcpb3mq5oB0eGmMqBvLtEtagGBucrYWr6bWwUOQ2EN8eaagzQdcYYlCV5WzkWK+EFNEDNttv+3bKJNPHIi6KtGYd/B5JVJ0A6ggcxYaFD9RF0nugp2F9AGUYlvuIX0O0PzXja9Va4JjqlEb8G1jx4p0kY9wWqx+fTL6E7fKi0xhxlJ0Asm7C+NUmYI5nTrucnU2JDi1V8YbXBIG9cAWtBQXK6gSq3fnJo65JpAHaJPJhyP/2pHcqH1saLZbEzCLBhAETXaUD+hkujECYOoIzEceRDEJP7mamEJn8n6RXMn7spdI71TjXhhUnT/SCDZIi7HxJ9ZwbriYyvfESOECOHeYz3P47ByDHtd+N+yXm4F+K/K3ezT7xabKukGL0lTMOdqEG7GwnZW1DH+m7UpsgshFuPMmazSSHPc/e1D5AU6kBp93Gtq9k/3EGCUjgkHjodjelo1w81Ds34n6BqHgIXPJ5fGt8CIxPSqTnHVsspYEs6XLNRr/fdirLUAhHS6nC8xaHiPLrWScD+QqCy9kGGrdUjDXuyX0umBuuqwYt2IUSgl6CK+/Ij9KgCiKTB6ojeqbMaYAZV61irWAzegV5FRohLfpO5f29YexCzAiMQd8Mo5pyMIIdTDUYSx3GABu3zBaKvoXqgfgOe+jcfXQA== X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1309;31:1oawPVU5gOMbkmg4Po3SVs5Hbo+POwzN+QG4F2/kBP1zMmUntMU3jyP5fZkljMtezdd0sPgpfbZft7gMKTHhrbf2sK3IQGLAQBeK7FrNcmB9PcsWpLjtaUcmF7GyFs4ZOEYCydbNUuwlRKm64VYm3+jWkzKkirS1hcyuHSdTfb8YhT/u/CDwNxbAeIAu8xIWrTGdf/WQO558BrtQ2udzeJN6jjcjVqKAIbzBcEogEKg=;20:X7xUls0CA4EMrrpF1evDb7Ppoo9ys2oeMpGrmYBwRW8PC9tHuCTnLmQSS6tEyX3PWMTQJWPAuIBTGVxKaGvp6mm7cdt1aFy8kDBi19xgqD5MZzlHS2Nw3xdz3NTETjqFYYM02R+sLeJtq8e388D8PbE3V9jdpX33XTWouq/1jiL4LAs3lU7xMhMBpV5Oy5yrYCWVQYRituhh6HliZC1MS2eqynnowCbWCEwa0VEuDhe8CYVS6XtqLopRDdhZBS9/KqdW5toZ+x5gdEMtGAhzle7QGTxrq4nle6Apy9661Pg+tkn7DTzdEiET/XKMqz/9H+lw9Lp9Tglb9XdnI2w26tRD8R399Cwq67k9K8CFagN8zReL/Z3Gsv8zbueFQfIj+aRKx/wP/S4P27y0MDMqychQOP1zNLmeT31qTBAVYflsTwq7+cZ55d1+Q09OTfA7+cavTxcWhtKYQ6cKnlktfM9wL1Vu6x7GEi3A6f5ewhubbnrFnNbs/qzUL4lqpysK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:MWHPR12MB1309;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1309; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1309;4:MhI/fmyPr45NGpuxrkQk+9KovNJ1KBZuRk1ghLOGGpCjjrSi1ZfIjfnm6xbdPu2cPAjf0y2yDuR5ejGZcDwXhONwn09x4Rg5WUA/WBpKqvM5SKadbtiKr/z1PjaOWA7KJhp6qSk0omEpkkIWiuw0nDcWGwut+enL/DqvqLHeEOpzv3aWml+08US5/iYedx+FhuvWEnBwMhWxCL0avhf5fF8gh82FCpUIzesxrs5Ji3Sz8m0Xoj4rG9q9tk5wxhGcY5F5aVieVgcalxTnhbW9P7i6A1DQ7H87wIRyhOfAdoRz2hKFEgv25IYlObbwKDqci5ibq/sCtH72pvTYI59/2hJ7QNJ7amlQNNORxuqTtJNLaKvG9oPKs9ZFQKOxTmQhMkXKvP8pSKn/F1iZoUYX6JGdtAXxgE3eU+Sa9Pd5tc8oAtsO/OiBBO7KRn78UgI4 X-Forefront-PRVS: 0070A8666B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(65806001)(50466002)(77096005)(65956001)(31696002)(81156014)(81166006)(1706002)(47776003)(36756003)(68736007)(8676002)(101416001)(54356999)(2906002)(6116002)(19580395003)(83506001)(586003)(19580405001)(4326007)(33646002)(2201001)(50986999)(76176999)(86362001)(105586002)(31686004)(2501003)(2870700001)(106356001)(64126003)(42186005)(92566002)(5660300001)(189998001)(7846002)(65826007)(2950100001)(23746002)(97736004)(305945005)(5001770100001)(4001350100001)(7736002)(921003)(3826002)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1309;H:[IPv6:2a02:908:1251:7981:e5d2:5583:7841:2f5c];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR12MB1309;23:cr7Zglj5sKAB2FCBhem09T+bF0MlWewt0GUIi?= =?Windows-1252?Q?LXrgQWO+hUgDuvhzbk6+GsZ9A79Sp95l8XdVo4Nt9PDabexbvWkKZAaz?= =?Windows-1252?Q?1oStk/szQcwLn0ajbM5GONoROSL3T6IhHUNEyeGKrfcDCIzvXxDfKlQI?= =?Windows-1252?Q?oreNA1FpO/rDhHZrSr87LpoB6pMPmHIb51v/yOdH77qGZAqkULr8S4e/?= =?Windows-1252?Q?acQF+sKLcZdcUNx6LxNgb7mmnGgFhnVB1hy7B44E1xlKIlG9kKuNmZHM?= =?Windows-1252?Q?Ooru2mOY698Y8gbyMDl6zM8LU2w0ENabPBm8P4h6K8vBjrNIS+en+MCH?= =?Windows-1252?Q?2uMZsXwNphAzZyYR5VDl5Jv8VeLLwCWUDEUWlE8F24o7PibTIS30RIOP?= =?Windows-1252?Q?KtO0VOdjLJf1HuPc3G3uhkzfkqlDyfUKTjgSBumv2/FzuOBWpyEJYRvb?= =?Windows-1252?Q?JR68DEMuHPdvpyjQ4KxfMBp8c+97xAlHJexV6+6PJD3c3XjTLI4yGdDg?= =?Windows-1252?Q?5qqBJ/I694EuUcstl5cwX0RKnpZQrCZ+0dkASSmWcju/gLV51C6+dP58?= =?Windows-1252?Q?3IEoERwKzzBfNMtMMPjqPB2d8qtHJJHR+WUHjuWf7Df9CguIY0UAj0Fx?= =?Windows-1252?Q?Al+VyYLWUHoOLCvebIII41FHH50vIDp4wq9kjgnifmMmyYGpY8bRaf+R?= =?Windows-1252?Q?EkQmXHXbVXfOJgBh6qDoojJKphmDEmyJlts8vS4fQVYLE42r+NGZDu6C?= =?Windows-1252?Q?kPOgY3VXRUSeswHjC7/XOCabrw/wExMd3uohNbVDpzE3qIYMRJqMycO2?= =?Windows-1252?Q?KPewbJIKRy2AGL3YM74sl9GA61pii4hd4LzKb7ogmozE9P0W3kuoT7ri?= =?Windows-1252?Q?hvDp8N1tyQFMCuyuNZZHSO5ojy7iUXLk94CPq3JB6cVlEYfC7M2vgfjA?= =?Windows-1252?Q?YVxuTrOM2XSgY9XbnUTlf54bneF2HSMKiYIQ7Fdo2F70liQNYb1JzrJ0?= =?Windows-1252?Q?5CrPC/3b3jTzZYjH+bx5NjN4F7RP/CVoi2b45tA6esCSQxSepg08MmZA?= =?Windows-1252?Q?xKFeMZ99dMZgR3//GlhCyhccU6JCYnDC4VhOCTOwesI6hJbothSCM17W?= =?Windows-1252?Q?nOLE2xzLwpPko5HYNifEcVJ0Q8JNsV6PCCMR/tuQJg8CQHvekrXYrXTd?= =?Windows-1252?Q?L1iwn7dD44LTR64VvnTKZ80MSxQZ4fn8fDIlv2O03fAf9TYttOb7IUgr?= =?Windows-1252?Q?d78PPQdwESgEWKJi7zjceyyTgwPO+mOCuQGgGODC+Wip4M+JtJoQt4AR?= =?Windows-1252?Q?mrua5g3kSr9vslIgmMKKY52qo4QBzHSUoMVFMnIa/9ffRtW4L6DlZHk6?= =?Windows-1252?Q?kCvZglyX1rsE6GoQflvMkduHuhNmRt7V1aDq/TR6kOCgC6cEpJfhpE?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1309;6:oeUqpNHOIMjc4arii44BH69HQc51rTP1dJDOnThqTGYoavoowcCYCuoExIzId418ZQCQ9gMnarwjNin/0zK7lzEvqew8R7M+Wx43tolLx9oFSMnvQrSgwgWpXyozx4W5VpLPmfZshbh1ayfoxL7QGJnMhg8/TXAMf4Go0BaX2yq/yjA544ofxmvzhtzkaZ21+QmAOfQkBrmFD6yp/kRics6DGALSRXLcqzAyFdGAEfjh29h2HR88Rl9JdMh68IJ9+lBNRNTATI0Fvi9Yr6xxmJLbAqRzvQw/IIoXn5ZzlXtbbuG+OiqEXs25a7I3mzJc734t+vpfcxX632aPptnYBA==;5:INDEjlOz3hxXhaTMpPnt8uuAZfNofzC3XUnZE3Krd3P9+ubmttxU6cofBpapjHuCZNdCJ3G0ztep5JI/XS/ghSGrGbF1JkXoXxTeJcnmmhPkf9zRPgAIDDDJCtRVhd4raDiOU31CghnRa1J96m6Ojw==;24:vL7kXTAkMR774coQCL98NtuE4WFTUqjXtiU82slmnYb6OVvaDI+kfXzfaqxoAoRHUb4qlDPaRTYqnEQdfwsLpkMDsJtkw+UQthBaepTetJs=;7:4kTc5jlRvL1qMWH7+AIVQ7YIEac6hJL5KTuuP92gq8qxmMxM7AYKVZp531ggx2i0qYQEiSMC1E8yy5l3viJUqMk/9AM3DHSE+eFC23N2WFbptSyCSmeMtI19z4eOwBiDWYu+271wNVhYCySXfMfmmue3Ba1HJHBkO7dY55qoZZzWBo9urWlgUWryWyuoufT3CBYUgSoYell0++pfwbsPd/YveM12S7CclNW0KtyZvBM5ba7ZeezZ81H0IyTB4Dm5ctAhKSxFBp53A3KNrNxDdNgWoWpk2WsYbKwgR8OTTKdDDJd+65DlFy9rcfdg2FU4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1309;20:3gKcobnI3jZd391WJQ1/PEf19enyDAdZ6IOa4plJ+6BwOiVyTEInYiijHYDNj7SbZ9OALt8Gn2tfPfoquLPKUrKBnQRGC2C1ha5M8zU2Ims6wvoYaqkZJz8wQD7v4Ptj6H4knXPuBi7PQ7ZtvGS98C1mUMFrePG40ZOI98GUJDcH3twyqxVs/KyK49pSLMKywcxP9eLT2lY9jbw+dUonNjwV3mPENscGxw96SdseeRHTr3labpkviUiNQVi6HBZi X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 10:01:52.3526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 18.09.2016 um 16:09 schrieb Baoyou Xie: > We get 7 warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1990:5: warning: no previous prototype for 'amdgpu_pre_soft_reset' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1548:5: warning: no previous prototype for 'amdgpu_connector_virtual_dpms' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1560:5: warning: no previous prototype for 'amdgpu_connector_virtual_set_property' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:330:5: warning: no previous prototype for 'amdgpu_cs_list_validate' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/dce_virtual.c:98:6: warning: no previous prototype for 'dce_virtual_stop_mc_access' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/dce_virtual.c:130:6: warning: no previous prototype for 'dce_virtual_resume_mc_access' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/dce_virtual.c:136:6: warning: no previous prototype for 'dce_virtual_set_vga_render_state' [-Wmissing-prototypes] > > In fact, all of the functions are only used in the file > in which they are declared and don't need a declaration, > but can be made static. > > So this patch marks both functions with 'static'. > > Signed-off-by: Baoyou Xie Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 6 ++++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 6 +++--- > 4 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c > index 319a5e1..decbba5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c > @@ -1545,7 +1545,8 @@ static int amdgpu_connector_virtual_mode_valid(struct drm_connector *connector, > return MODE_OK; > } > > -int amdgpu_connector_virtual_dpms(struct drm_connector *connector, int mode) > +static int > +amdgpu_connector_virtual_dpms(struct drm_connector *connector, int mode) > { > return 0; > } > @@ -1557,7 +1558,8 @@ amdgpu_connector_virtual_detect(struct drm_connector *connector, bool force) > return connector_status_connected; > } > > -int amdgpu_connector_virtual_set_property(struct drm_connector *connector, > +static int > +amdgpu_connector_virtual_set_property(struct drm_connector *connector, > struct drm_property *property, > uint64_t val) > { > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index d80e5d3..b408eea 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -327,7 +327,7 @@ retry: > return r; > } > > -int amdgpu_cs_list_validate(struct amdgpu_cs_parser *p, > +static int amdgpu_cs_list_validate(struct amdgpu_cs_parser *p, > struct list_head *validated) > { > struct amdgpu_bo_list_entry *lobj; > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index c38dc47..09b809d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -1987,7 +1987,7 @@ static bool amdgpu_check_soft_reset(struct amdgpu_device *adev) > return asic_hang; > } > > -int amdgpu_pre_soft_reset(struct amdgpu_device *adev) > +static int amdgpu_pre_soft_reset(struct amdgpu_device *adev) > { > int i, r = 0; > > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c > index 00663a7..2d02acd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c > @@ -95,7 +95,7 @@ static bool dce_virtual_is_display_hung(struct amdgpu_device *adev) > return false; > } > > -void dce_virtual_stop_mc_access(struct amdgpu_device *adev, > +static void dce_virtual_stop_mc_access(struct amdgpu_device *adev, > struct amdgpu_mode_mc_save *save) > { > switch (adev->asic_type) { > @@ -127,13 +127,13 @@ void dce_virtual_stop_mc_access(struct amdgpu_device *adev, > > return; > } > -void dce_virtual_resume_mc_access(struct amdgpu_device *adev, > +static void dce_virtual_resume_mc_access(struct amdgpu_device *adev, > struct amdgpu_mode_mc_save *save) > { > return; > } > > -void dce_virtual_set_vga_render_state(struct amdgpu_device *adev, > +static void dce_virtual_set_vga_render_state(struct amdgpu_device *adev, > bool render) > { > return;