From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9A942882B4 for ; Thu, 21 May 2026 11:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779363539; cv=none; b=ls4DJ5EdO8YhkamnwlMGwWN5RpvaEp6+q+c+qda7Xj9bxwREeMAiAIApUJtwiDT+pclrXEae92tn0b44wiSEU2X/CSYSCn8MEqXvauB6JupMIF3cA/k5PLB9QP6g5huU6zG8iRCcDO3aYAbN97aj2J07Zn64H+CWqkwi4VMzfeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779363539; c=relaxed/simple; bh=sOZG44HAL+XlEZxyGEXOLSiTIKnY6lJ2BOOCo6j33TU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bmxUXQaZGWz3nEPpi77Aand0qp+rPyJ5xySDg0q+U3wSmYLIFX1euvPjOIhZEQ6fHtbo/AdGouYiQP2YrnVnrfX48iBOZLFJ3/a8M6nZjUJaKU/UqoYeFBdjP1/NyXjfpNDDZ2NuzHn3Nf17JtndhsJ/rDcisvcdOnwQCL6xxA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=znzvohCm; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="znzvohCm" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-449de065cb3so5622804f8f.2 for ; Thu, 21 May 2026 04:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779363537; x=1779968337; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bf7++OSA/ehjamW69p/Uz0SzqGOGvNCrQjb/sL6WnB4=; b=znzvohCm3N4ZI1MXWmV8FKybjatuhdePUGGRhYza+gCfptK915/NowHYbkYYWryOya yippJ9W3I/2e4PcHw339/M0WBtqw79D6OdJAJRenYJ4pcMWFXDMpfzLSU/c65lQGb/cV ajoNo+YtUoZGLKdRjxBAM7dHLykJV8XTbcZi81/Tuoz7xsjHGYZ2v2BUN73tFtFtlcPh NBUsa5jgArR9leOsrGdRzPbNbjWlYCwZn7CjUCKIQ0jGvBHouNgOeqztTLZO1n5QSP/1 2PHpKps63ZPOEBzWOkDNGhm83vXVqoKWYcR80ZnYVGOsndKTZZr39MkBWwnG/EP7GsXY N8Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779363537; x=1779968337; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bf7++OSA/ehjamW69p/Uz0SzqGOGvNCrQjb/sL6WnB4=; b=j8R0yybOS16Lc9D4eQvVlluGolJ66swoY8fR8pd30/mhqdD4+D2BjXUlgF6g6JS7E8 e3QSXZ4oKSTkaOks6FRaTVh/4JlG9JbUO2wNbBL2X1BuaDaRt7Z3TnXVdL5hR12uY55y L9OxfdVnvA9LwvnARMh2m8L3S0SkuulHl8Zf5NxncXZpZJhOeLcW1oyIjhPtv4U7EHLU kIcEZncbGc5N0KzlfAZcdmuxTH8NDZp9iad29Vrs/09XTroxYKrOyZtXBuKc6y9jJDSw ZdFV3KVcY2RQOtvjv+CLJxWDJcCArk10jm9Faw+bXDbhbNUwyQsI+wDcvBJEZOcuURUz O3XQ== X-Forwarded-Encrypted: i=1; AFNElJ9R5cpypv4soa6qEGtC4N+Z2Sk35MVj3AJeOTOzTh2WQstUhgVBqyRlY3Y+dUY5SrTxQTRaz/TP3p1oD64=@vger.kernel.org X-Gm-Message-State: AOJu0YxM34oZ5Au0dhcDOXhAwZtTQ3h80FRQ2TDVjzble0n+7nFZuS3T o/8I/s7u6TeoCmT8uHfgL+qegsX07nw7GOXUr6p4FviagI69JSnvfBscomNCqvN4mT8= X-Gm-Gg: Acq92OFHN9KaJ/CGDoOJNwbCD436Oazbb5474x4CHmvGItU2vBJxhtPIbKpfOe/lK7p VYcOEVewCttendbTsvZFYxYjUQtPx3JmZk5CXTkfDw7RAq27FS/I071t97ZSjIift1CO35DwQbc hi1TFXWZAyJuVnE+EhMJ72gaMEiQqMMavXwvxgt5ouJ67F9KcNRb1do8ArzqBP8rGWCCIxKFnOR +ZILtfaPW3d5bHMb7J85NgAKKCwdbY4rBofFm1gAdGFOGIxaG1xARYo1kGYDeX/3imLgMNpHfOd moV5xs9K40RqyLYQNWxtV/imypynkOeISsxEGogczJAY+dbBQ/wU0Ec7cHH2VbDSRBtMeQYmi3Z SUwe0P2xD+EYk1hWL9Pic2CNPWOEbpl1cnRLVpO7k1CUaFRwAXjz+lD8NApLKimQt9sK4w4bC5f Jfg2j+Phfs3v6yb44kueEwYUr8yqwHN5nnn171I6EJvyh91psTX765131uO7NuO/hmbdeXlQLiW 2vLQoRdvZqw9SA1udnisbGP0tAzwZ2MC9ET X-Received: by 2002:a05:6000:2f87:b0:43d:762e:76ba with SMTP id ffacd0b85a97d-45ea3ae7068mr3841739f8f.17.1779363537026; Thu, 21 May 2026 04:38:57 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:fdc3:41fb:621:f792? ([2a01:e0a:106d:1080:fdc3:41fb:621:f792]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eaa7da46esm2500466f8f.14.2026.05.21.04.38.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 04:38:56 -0700 (PDT) Message-ID: Date: Thu, 21 May 2026 13:38:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] regulator: add SGM3804 Dual Output driver To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, KancyJoe References: <20260506-topic-sm8650-ayaneo-pocket-s2-sgm3804-v4-0-7495e7905693@linaro.org> <20260506-topic-sm8650-ayaneo-pocket-s2-sgm3804-v4-2-7495e7905693@linaro.org> <91ace2b7-a0c7-485f-a464-d7db397e0df7@linaro.org> <6689f2b6-b369-4048-be65-4cee6d653533@sirena.org.uk> From: Neil Armstrong Content-Language: en-GB In-Reply-To: <6689f2b6-b369-4048-be65-4cee6d653533@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 21/05/2026 à 12:21, Mark Brown a écrit : > On Thu, May 21, 2026 at 10:17:16AM +0200, Neil Armstrong wrote: > >> I checked the Sahiko review and the reported issues are all false issues that >> won't happen in real life. > >> Do you see any parts I'll need to improve ? > > I haven't looked properly given that there's two drivers for the same > chip in flight, like I said I'd like some agreement about the way > forward between the two submissions. I did see you follow up and no > response from the submitter of the other driver. Sure, I forgot to review the other driver which is the original driver I used for this enhanced implementation, done now. Neil