From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D493313531 for ; Mon, 2 Mar 2026 07:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772435508; cv=none; b=CQQGWYCDMDe75Qs89jf+Q2o6XFtzr3Ipd2TwxkEl++tT9h+r81OTqcT13GlSrPkgUuZPo2oT2ysAYzipBBOymKvIl/tx5muoeWWiZ4wJerM2f0DAhULKgmhDNjIytUrZ5YpCyvBH3ogbZQG4BQ2BdVKYI+9DTitpj9IE6sXd9kU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772435508; c=relaxed/simple; bh=gN9cMriQiaCdbwYViMPIAzJuND8RisiyNlgQZi9J+KY=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=NLubdfvsoPn35XcWlIiBuJJKFc+lyjhA+TZy1Q+YdNZYY9S4nhkqISDmPmhFIp2puRyYpjYeSARwVWYjrdJ/AyXUzVXUL5rcBLjECLRC2feiv3H96Z6tGDUQeqgGRpkD+lbpaQnm25b7GDV7bmXIi++cYUY6h7/TWT7/zn8V2Ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PukqBZ5U; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PukqBZ5U" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439afc58ac7so1186868f8f.0 for ; Sun, 01 Mar 2026 23:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772435504; x=1773040304; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gN9cMriQiaCdbwYViMPIAzJuND8RisiyNlgQZi9J+KY=; b=PukqBZ5URLfJ5f8wCWUr2L4x5O1m+OFYgzSYER6y6mZqSi/BvFvTcCYbG+gICT4Y3h m1mTSI0rAaZp+WoI17E/xrVbWeJRxFawpFnTnKM3+8RK3jR0vvkStf8qqv7s1BeeITJP 1Rk48zWgVduz0a2fIMjZx9taFjeM6hzxWkOt7+xzN9N4SsQh4Us8fD7e3oPFu8Y/w4fV 9A8PWqdKp8HjigLEq2oWvZREyMV0ci4c5mt42JftaD4KVjPSN6Y/eWbw7m9J4fQ7kYVj g+T7GEl0YWDpCXsYDEkmupGIZCWbNp/pLeAAbDNMjCNe+DAEwJhzRlABPgPN7BJZjp7F t8dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772435504; x=1773040304; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gN9cMriQiaCdbwYViMPIAzJuND8RisiyNlgQZi9J+KY=; b=FvyN+Cc0twuuxiQLFVn945zEaGcfyXMisehgdXwULAwEATPvw+N6lS4wKp3ehrnx+5 16G48skWAVCma4TIkEtsUEzAMi0JPPoaNJ5TyWjLwJXA/9/oG3Olw2Mp+xJnAOfm+fcB wQzTpuDYiepHS3W0An6bRpFFGUv3XvpFCAmY9b9fo37Xz4sHG35kw4HBN65BcyriRwg5 bsieuakiiqJDkpvL09fe9tbGnwuJ2l7iNCPj77PTugj6XxaTQQIwiyRjH2AV3kVjTsfB q2t1A+5gYTYqca3jZyF7DcayqteylvwIpLbSefwtwQMXdzH3BQJ86KlCZ21RdfT5kIE5 hgEg== X-Forwarded-Encrypted: i=1; AJvYcCV2eCZmxJIdSx48BcO2y8SjX1wGsgkMNF0cWrsq84TdJ3AuTIgQKPtCeRH31W96o5SvyCYOF/AGuujhNCA=@vger.kernel.org X-Gm-Message-State: AOJu0YxYB1gRYZSKdvZ9SG5BS6sinEJVRY4bm9iMfo1JNBO+7Ksy1rJ+ FikYBOeHwKi7MRT8iQapoNUj1HA2Ryc59hyBVJSP4mg0jExerD42GHzL X-Gm-Gg: ATEYQzzv5Y9ht+NOTHHn5fVvzHJMPrv0lAksxUsnZdPa3LHxLwQySeQC1699Q1AGH3Q Q1NPM8o5ZGPSGTCEiZ7ls/+nMusZViVlFMvL+EL/V2EH9lwwparpkJ6CoqMTIUE5Ugip2TWaOrO Xt4QZ6vAcbCTAJK7F/HJmHtX0QwPr6qVClg6ynrQUa/blrw3SjNaJtWA3ioTXZis/M+uXE7san6 Ex5EoHcjaNnSGmH649eRhDbKdzPkwRJUab4+Uy/+7D33g2hsS0BjVZg6Q6n8LvpDREqIvyt/1eQ 9bSf03cGy3Zj1g56I0oG/HPhhDT8tKruBRoFBiDb/TujFJts8dccVV73DwOYvRAcglLbfU2nJtl BMiwV4pKF1MVJim+XCWmkJliujGrfZDthD37wcX3Q+vLoqX85L7TqxcqJ2pVxfdiN3xGJ+e73Bm QArJ5xxsaNGXKQZcBZ X-Received: by 2002:a05:6000:18a3:b0:437:81b0:6650 with SMTP id ffacd0b85a97d-4399de559a4mr20935838f8f.56.1772435503577; Sun, 01 Mar 2026 23:11:43 -0800 (PST) Received: from [127.0.0.1] ([86.1.69.5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c70ed47sm27919440f8f.11.2026.03.01.23.11.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 23:11:43 -0800 (PST) Date: Mon, 2 Mar 2026 07:11:43 +0000 From: Josh Law To: Kuan-Wei Chiu Cc: Andrew Morton , linux-kernel@vger.kernel.org, Josh Law Message-ID: In-Reply-To: References: <20260301152143.2572137-1-objecting@objecting.org> <20260301152143.2572137-2-objecting@objecting.org> Subject: Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Correlation-ID: >> >> checkpath.pl reported the following warnings: >> >> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) >> #81: >> Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools. >> >> WARNING: From:/Signed-off-by: email address mismatch: 'From: Josh Law ' != 'Signed-off-by: Josh Law ' >> >> total: 0 errors, 2 warnings, 0 checks, 9 lines checked >> > > BTW, both of your patches does not apply cleanly. > > Regards, > Kuan-Wei I think Andrew fixed that.... Including the from lines V/R