From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E142C43217 for ; Sat, 19 Mar 2022 11:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242817AbiCSLjl (ORCPT ); Sat, 19 Mar 2022 07:39:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231818AbiCSLjj (ORCPT ); Sat, 19 Mar 2022 07:39:39 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71AE586E16; Sat, 19 Mar 2022 04:38:17 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 094082223B; Sat, 19 Mar 2022 12:38:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1647689895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zmfB9xFrYldmqq1FLPQ4/Iztnp51kdC7eGjZLGK9R9I=; b=nK72s+a+CriFy2uCBz7cVC/oV2dJ7STsg5K6+FvOMXhbU9OHAvyFezhKJEonlNukjIE/At iOXENIVw/Ky8/ukxJLQk4qnF9236PXkZDjyKrMEr+u4yWjrEg/Q+8XVa+s9iLb4n4DtONH 11Plc7zM79jDmEgGlak5dmfX2BOKI3A= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 19 Mar 2022 12:38:14 +0100 From: Michael Walle To: Sergei Shtylyov Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Thomas Bogendoerfer , Gregory CLEMENT , Paul Burton , Quentin Schulz , Antoine Tenart , Kavyasree Kotagiri , Nicolas Ferre , "David S . Miller" , UNGLinuxDriver@microchip.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v2 7/8] ARM: dts: lan9662-pcb8291: fix pinctrl node name In-Reply-To: References: <20220318202547.1650687-1-michael@walle.cc> <20220318202547.1650687-8-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 2022-03-19 09:24, schrieb Sergei Shtylyov: > Hello! > > On 3/18/22 11:25 PM, Michael Walle wrote: > >> The pinctrl device tree binding will be converted to YAML format. All >> the pin nodes should end with "-pins". Fix them. > > It does end with "pins" already, right? It ends with "_pins". Please note the underscore. >> Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board >> pcb8291") >> Signed-off-by: Michael Walle >> --- >> arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts >> b/arch/arm/boot/dts/lan966x-pcb8291.dts >> index 3281af90ac6d..3c7e3a7d6f14 100644 >> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts >> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts >> @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins { >> function = "fc3_b"; >> }; >> >> - can0_b_pins: can0_b_pins { >> + can0_b_pins: can0-b-pins { > > Mhm, I can't even see what is changed here... :-/ The name of the node, s/_/-/ -michael