From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF70C0044C for ; Mon, 5 Nov 2018 07:19:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05B7420827 for ; Mon, 5 Nov 2018 07:19:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05B7420827 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729569AbeKEQh6 (ORCPT ); Mon, 5 Nov 2018 11:37:58 -0500 Received: from mga03.intel.com ([134.134.136.65]:61335 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729000AbeKEQh5 (ORCPT ); Mon, 5 Nov 2018 11:37:57 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2018 23:19:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,467,1534834800"; d="scan'208";a="93711892" Received: from allen-box.sh.intel.com (HELO [10.239.161.122]) ([10.239.161.122]) by FMSMGA003.fm.intel.com with ESMTP; 04 Nov 2018 23:19:38 -0800 Cc: baolu.lu@linux.intel.com, Joerg Roedel , David Woodhouse , kevin.tian@intel.com, ashok.raj@intel.com, Jean-Philippe Brucker , sanjay.k.kumar@intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, yi.y.sun@intel.com, jacob.jun.pan@intel.com Subject: Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode To: Christoph Hellwig References: <20181105053151.7173-1-baolu.lu@linux.intel.com> <20181105053151.7173-12-baolu.lu@linux.intel.com> <20181105071505.GA13230@infradead.org> From: Lu Baolu Message-ID: Date: Mon, 5 Nov 2018 15:17:12 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181105071505.GA13230@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/5/18 3:15 PM, Christoph Hellwig wrote: >> --- a/include/linux/dma_remapping.h >> +++ b/include/linux/dma_remapping.h > > FYI, this file seems to be entirely VT-D specific, but has an awfully > generic name. It should be renamed to something more suitable (or maybe > just merged into intel-iommu.h?) and also grow some comments describing > the contents. > Yes, good catch. I will do this in a separated patch. Best regards, Lu Baolu