From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753367AbcLHMOG (ORCPT ); Thu, 8 Dec 2016 07:14:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752786AbcLHMOE (ORCPT ); Thu, 8 Dec 2016 07:14:04 -0500 Subject: Re: [PATCH v2] rpmsg: qcom_smd: Add support for "label" property To: Bjorn Andersson , Ohad Ben-Cohen References: <1480716362-23467-1-git-send-email-bjorn.andersson@linaro.org> Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Jeremy McNicoll Organization: Red Hat Message-ID: Date: Thu, 8 Dec 2016 04:14:02 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480716362-23467-1-git-send-email-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 08 Dec 2016 12:14:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-12-02 2:06 PM, Bjorn Andersson wrote: > Add support for the "label" property, used to give the edge a name other > than the one of the DT node. This allows the implementor to provide > consistently named edges when using the rpmsg character device. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - Moved sysfs attribute to the correct (this) patch > > drivers/rpmsg/qcom_smd.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > Could you please add something to Documentation/devicetree/bindings/ showing this "label" property. Or add a "label" to an existing DTS so people/implementors have a reference if they so choose to use this property. Thanks. -jeremy