From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tty/serial: Sort drivers in makefile
Date: Wed, 13 Sep 2023 07:29:51 +0200 [thread overview]
Message-ID: <e74982c0-4942-1c46-1c53-6dd6e7677373@kernel.org> (raw)
In-Reply-To: <20230912103558.20123-1-ilpo.jarvinen@linux.intel.com>
On 12. 09. 23, 12:35, Ilpo Järvinen wrote:
> Sort drivers in alphabetic order in Makefile to make it easier to find
> the correct line. In case the CONFIG and filenames disagree, sort using
> the filename (but ignoring "serial" prefixes).
Overall looks good.
I just want to make sure you considered the below, as you don't say
explicitly in the commit log.
The order in the makefile defines the link order. So built-in drivers
are loaded in that order. So are you sure your patch doesn't change
order of some drivers which need to be in a specific order?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2023-09-13 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 10:35 Ilpo Järvinen
2023-09-12 10:35 ` [PATCH 2/2] tty/serial: 8250: Sort drivers in Makefile Ilpo Järvinen
2023-09-13 5:29 ` Jiri Slaby [this message]
2023-09-13 10:36 ` [PATCH 1/2] tty/serial: Sort drivers in makefile Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e74982c0-4942-1c46-1c53-6dd6e7677373@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®