From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout02.his.huawei.com (canpmsgout02.his.huawei.com [113.46.200.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B6B3DDAB; Sat, 31 Jan 2026 01:43:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.217 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769823820; cv=none; b=Nd4KhVO8Lglc5LaPtPOJ/dSoJ0NBwEHk14ZC39W6b50jpogamMasNAlNWK2qzQMCZFjBDGnedgaskUS+GH8Pk3yEOSXQlDyySf9WkF760ztX22W4I88iBUO5A5oXynHiLH5DC327hfZj27qP4mZWS+fvGCkSkC+UTSsbhW4uBYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769823820; c=relaxed/simple; bh=cHFkGyI9jGLKJ2AP85/yrIti37J1RRdkCTBXJAQ3r68=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=MHhv5v4jWXr/YI70nbjoydWX+DshN9d3OLU65WnlKVfOTbZKDbdJzSF/mrpJ/khxAXoWl6d9wmLgGSdxbWf8PV7blhv66dgrWJxjrA8rEsw+Dtsl2VsjyVI5AGSNO5rNNPybiIgI+6a2ZUm+VV6gAdkFTgWPFn/xpJC9cOliAH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=BeQrO5Wo; arc=none smtp.client-ip=113.46.200.217 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="BeQrO5Wo" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=dz1X5NwehduOdLuqzXJfd4vZBbbj36ZumdOgXhC2B6M=; b=BeQrO5WodJ7LcjpfGp3ggL4G2lVrinrryJMqyRj3DjTLXQzPl/Ypkv8txuHyS2JikC561oyUl gfgChwvS74wOmOBroc8g+Tt0FJzfNYNmtDY8MMUK3zedgKUQwGwnTcCOwoIA8xtNwJm4LQAjnM8 dIQ5QmRevv6HgLqqy4ppR4Q= Received: from mail.maildlp.com (unknown [172.19.162.223]) by canpmsgout02.his.huawei.com (SkyGuard) with ESMTPS id 4f2wXL54r1zcZyM; Sat, 31 Jan 2026 09:39:14 +0800 (CST) Received: from dggpemf500011.china.huawei.com (unknown [7.185.36.131]) by mail.maildlp.com (Postfix) with ESMTPS id 711B64056F; Sat, 31 Jan 2026 09:43:29 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by dggpemf500011.china.huawei.com (7.185.36.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 31 Jan 2026 09:43:27 +0800 Message-ID: Date: Sat, 31 Jan 2026 09:43:26 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v11 09/14] entry: Rework syscall_exit_to_user_mode_work() for arch reuse Content-Language: en-US To: Thomas Gleixner , Kevin Brodsky , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20260128031934.3906955-1-ruanjinjie@huawei.com> <20260128031934.3906955-10-ruanjinjie@huawei.com> <56978cb8-f9de-4bf2-b1fc-b5564fec7387@arm.com> <3bfa15fc-187e-4c39-9cb3-a936fdd443b2@arm.com> <87o6mbl82j.ffs@tglx> <13d22231-d84a-4993-9a69-e3922e45b500@arm.com> <87cy2rkuu9.ffs@tglx> From: Jinjie Ruan In-Reply-To: <87cy2rkuu9.ffs@tglx> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To dggpemf500011.china.huawei.com (7.185.36.131) On 2026/1/30 23:01, Thomas Gleixner wrote: > On Fri, Jan 30 2026 at 14:27, Kevin Brodsky wrote: >> On 30/01/2026 11:16, Thomas Gleixner wrote: >>>> Agreed, the comments are essentially describing what each function >>>> calls; considering how short they are, directly reading the code is >>>> probably easier. >>> No. Please keep them. There is more information in them than just the >>> pure 'what's' called. >> >> That is true before this patch, where it made sense to highlight that >> exit_to_user_mode() must still be called after this function (without >> re-enabling interrupts). With this patch there is however much more that >> this function is lacking, and it feels very likely that comments will go >> out of sync with exactly what syscall_exit_to_user_mode() calls. >> >> I suppose we could simply point the reader to >> syscall_exit_to_user_mode() to find out what else is needed, and keep >> the comment about the calling convention being the same. > > I've picked up _all_ four entry changes and reworked the comments and > changelogs already. > > Those patches should have been bundled together at the start of the > series anyway so they can be picked up independently without going > through loops and hoops. When will people learn to think beyond the brim > of their architecture tea cup? I'll make sure to group related changes together from the start next time and keep the whole series in view, not just the architecture-specific parts. Thanks for taking the time to re-work them — much appreciated. > > I'll go and apply them on top of 6.19-rc1 into core/entry and merge that > into the scheduler branch to resolve the resulting conflict. > > ARM64 can either pull that branch or wait until the next rc1 comes out. Thanks for re-bundling the four entry patches and reworking the logs — that definitely makes the series easier to pick up. I'll rebase my remaining changes on top of 6.19-rc1 once the core/entry branch lands. Let me know if there’s anything I can do to simplify the logistics. Regards, Jinjie > > Thanks, > > tglx > >