From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25AC6C001DE for ; Fri, 28 Jul 2023 20:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232874AbjG1Uen (ORCPT ); Fri, 28 Jul 2023 16:34:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232142AbjG1Uej (ORCPT ); Fri, 28 Jul 2023 16:34:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5AAE422B for ; Fri, 28 Jul 2023 13:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690576432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NPoM804CxQXNyaqYOi76F9KayN7Vk1JGyDtsJtbRViY=; b=HahAFVaO/3KqYT+rdbVpmuS0X6b0lQstZJYvEMl5R0AD8wVByxcEq+DjR48AvRIjWdvHi2 /NSFcCWXbz1HC6F/Yb5Psx6B3aMA/slrNI/J9qfB19JsoDt/uV2rvbRtQuhq6E9p7cEbNk IjwRn3JIZcecd7CLS/+kyLHNgNgi5sg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-rUUA8VMxPRGJfueHvOCFgg-1; Fri, 28 Jul 2023 16:33:50 -0400 X-MC-Unique: rUUA8VMxPRGJfueHvOCFgg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fd2dec82a6so14886335e9.3 for ; Fri, 28 Jul 2023 13:33:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690576429; x=1691181229; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NPoM804CxQXNyaqYOi76F9KayN7Vk1JGyDtsJtbRViY=; b=PlOBLqQZ2tMReBI7RHG4PzTrDW7tWrYdgtbIdMB7demgQNYgCE0kyGx1R/PvXlDP/2 LStSHhwnnSOajNdnso1te/adkwlcOcA+YkM58EJLS4nY2/06Lq8kdldy4xugReU0ibm2 rhM49apYiqwbRhRNy2kk16ovLOcYGiIjqazuJLKUSVERAeEUzoK4UesVOzLDUFx4I806 819hBWZH47a6Qm1nnIzx2yNhUUKfwgwWT7iFpO7kSuPWOo8tk7gZSbV4ja3zLNzCGnFA XysaAKutHXjawLu0mun7/2pb0i8lbRqrIhvBUz/954H1SZQdBI/SPRaDO70FxCSndmfR IsNQ== X-Gm-Message-State: ABy/qLZu3AdVV+uQHhOezl18AdKVImJTaQx53afw06uxLG+ll+Z9dd55 sZ3Wm/laemYGEYA1XxAiAGHWNVlktf5G837tBkXN8MO0T5KGUA0vP0OWhsxdqJOuHLY+ZOSG6v4 1iii0r7MPJe7CQhTA83HDkhrM X-Received: by 2002:a05:600c:210b:b0:3fb:fb88:974b with SMTP id u11-20020a05600c210b00b003fbfb88974bmr2633201wml.6.1690576429286; Fri, 28 Jul 2023 13:33:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlE0EWcwQHpVt4+4O+ITavcaEd7PJtizFZdLzot0OrKUsQ+DOTY++M7GZKjU+qSoarDGlXFOaA== X-Received: by 2002:a05:600c:210b:b0:3fb:fb88:974b with SMTP id u11-20020a05600c210b00b003fbfb88974bmr2633190wml.6.1690576428946; Fri, 28 Jul 2023 13:33:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id v25-20020a05600c215900b003fc02a410d0sm7630531wml.48.2023.07.28.13.33.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 13:33:48 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 22:33:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 0/4] smaps / mm/gup: fix gup_can_follow_protnone fallout Content-Language: en-US To: Linus Torvalds , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard References: <20230727212845.135673-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.07.23 22:23, Linus Torvalds wrote: > On Fri, 28 Jul 2023 at 12:39, Peter Xu wrote: >> >> But then does it means that any gup-only user will have numa balancing >> completely disabled? > > Why would we ever care about a GUP-only user? > > Who knows where the actual access is coming from? It might be some > device that is on a different node entirely. > > And even if the access is local from the CPU, it > > (a) might have happened after we moved somewhere else > > (b) who cares about the extra possible NUMA overhead when we just > wasted *thousands* of cycles on GUP? > > So NUMA balancing really doesn't seem to make sense for GUP anyway as > far as I can see. I do agree regarding many GUP users. But at least for KVM (and probably some others, but most probably KVM is the most important GUP user) it does make sense and we have to find a way to keep that working. At least, removing it creates significantly more harm than having it, guaranteed :) So would you rather favor a FOLL_NUMA that has to be passed from the outside by selected callers or a FOLL_NUMA that is set on the GUP path unconditionally (but left clear for follow_page())? -- Cheers, David / dhildenb