From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB553C46CA1 for ; Mon, 18 Sep 2023 15:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234149AbjIRPU5 (ORCPT ); Mon, 18 Sep 2023 11:20:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234346AbjIRPUu (ORCPT ); Mon, 18 Sep 2023 11:20:50 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB5A123; Mon, 18 Sep 2023 08:19:01 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38IEfb5o008143; Mon, 18 Sep 2023 15:18:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=sNZugfDj0EUXzn0lGOUGppcQYeOxKSNN7aJIe/l8fAU=; b=BM5TRVH1EmWNOXCgNxBmxBW19IvPEqX/nUk2xVdWXwHLinf16ZB0KImLTX+GI3InKBnb 9iLk9dw4KkXjj8rXjz0s756nKi2wU3EnxX5ayj8FF/a1klYmuucKIfF6qTOteo15pTYe FYIf10uVabqUMn046JPp1bfn8pnJUWffS93ONxtW2IroQFL4sC7I1oQaIuV80EMpF+eF 1mZ6BEh232cPEa1wWsOIVEgswS8VSwu7Sz+CdLPO+ZZVJ6K80h4YYrJeAN9kFecCXIGE fhE0P07RnZ5XzVAHaGDrdK8tHbipcPfKRr0sl5LsRuFqUPb8Uz8Zt3lPBwGjvP9veir5 VQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t6nh78drg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Sep 2023 15:18:51 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38IFIo3i028903 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Sep 2023 15:18:50 GMT Received: from [10.216.52.36] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Mon, 18 Sep 2023 08:18:48 -0700 Message-ID: Date: Mon, 18 Sep 2023 20:48:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: usb: typec: ucsi: Clear EVENT_PENDING bit if ucsi_send_command fails Content-Language: en-US To: Heikki Krogerus CC: Greg Kroah-Hartman , , , "# 5 . 16" References: <1694423055-8440-1-git-send-email-quic_prashk@quicinc.com> <21d247d3-83be-ba53-c982-2ab0e2e4ffb3@quicinc.com> <4e876097-aed1-2b0d-ecb4-6434add4ef26@quicinc.com> From: Prashanth K In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: cwjP36aFSjAg90LUWnvfML0geSJOkLMG X-Proofpoint-GUID: cwjP36aFSjAg90LUWnvfML0geSJOkLMG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-18_08,2023-09-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 spamscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309180134 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-09-23 07:55 pm, Heikki Krogerus wrote: > On Sat, Sep 16, 2023 at 01:58:30PM +0530, Prashanth K wrote: >> >> >> On 15-09-23 07:27 pm, Heikki Krogerus wrote: >>> Hi Prashanth, >>> >>> On Fri, Sep 15, 2023 at 07:10:25PM +0530, Prashanth K wrote: >>>> On 15-09-23 06:02 pm, Heikki Krogerus wrote: >>>>> On Tue, Sep 12, 2023 at 04:37:47PM +0530, Prashanth K wrote: >>>>>> >>>>>> >>>>>> On 11-09-23 06:19 pm, Heikki Krogerus wrote: >>>>>>> On Mon, Sep 11, 2023 at 02:34:15PM +0530, Prashanth K wrote: >>>>>>>> Currently if ucsi_send_command() fails, then we bail out without >>>>>>>> clearing EVENT_PENDING flag. So when the next connector change >>>>>>>> event comes, ucsi_connector_change() won't queue the con->work, >>>>>>>> because of which none of the new events will be processed. >>>>>>>> >>>>>>>> Fix this by clearing EVENT_PENDING flag if ucsi_send_command() >>>>>>>> fails. >>>>>>>> >>>>>>>> Cc: # 5.16 >>>>>>>> Fixes: 512df95b9432 ("usb: typec: ucsi: Better fix for missing unplug events issue") >>>>>>>> Signed-off-by: Prashanth K >>>>>>>> --- >>>>>>>> drivers/usb/typec/ucsi/ucsi.c | 1 + >>>>>>>> 1 file changed, 1 insertion(+) >>>>>>>> >>>>>>>> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c >>>>>>>> index c6dfe3d..509c67c 100644 >>>>>>>> --- a/drivers/usb/typec/ucsi/ucsi.c >>>>>>>> +++ b/drivers/usb/typec/ucsi/ucsi.c >>>>>>>> @@ -884,6 +884,7 @@ static void ucsi_handle_connector_change(struct work_struct *work) >>>>>>>> if (ret < 0) { >>>>>>>> dev_err(ucsi->dev, "%s: GET_CONNECTOR_STATUS failed (%d)\n", >>>>>>>> __func__, ret); >>>>>>>> + clear_bit(EVENT_PENDING, &con->ucsi->flags); >>>>>>>> goto out_unlock; >>>>>>>> } >>>>>>> >>>>>>> I think it would be better to just move that label (out_unlock) above >>>>>>> the point where clear_bit() is already called instead of separately >>>>>>> calling it like that. That way the Connector Change Event will >>>>>>> also get acknowledged. >>>>>> Do we really need to ACK in this case since we didn't process the current >>>>>> connector change event >>>>> >>>>> You won't get the next event before the first one was ACK'd, right? >>>>> >>>> >>>> The spec says that we need to ACK if we received AND processed a CCI >>>> >>>> "4.5.4 Acknowledge Command Completion and/or Change Indication (R) >>>> This command is used to acknowledge to the PPM that the OPM received and >>>> processed a Command Completion and/or a Connector Change Indication." >>>> >>>> And here in this case, we have received, but not processed the event. >>>> So I'm not really sure what to do here in this case. If we don't send an >>>> ACK, then would the PPM think that OPM is not responding and reset it? >>>> OR would it resend the previous event again since we didn't ACK? >>> >>> Every PPM behaves differently. >>> >>> Did you actually see that happening - GET_CONNECTOR_STATUS failed? Can >>> you reproduce it? >>> >> >> Yea we actually hit the issue once where GET_CONNECTOR_STATUS failed and >> subsequent events didn't get queued since EVENT_PENDING wasn't cleared. Its >> not easily reproducible (<1%) though. >> >> [4948:kworker/0:3]UCSI: ucsi_qti_glink_write: timed out >> [4948:kworker/0:3]ucsi_glink soc:qcom,pmic_glink:qcom,ucsi: >> ucsi_handle_connector_change: GET_CONNECTOR_STATUS failed (-110) > > Okay. It would be really interesting to know why is it failing. > But let's just go with this for now. > > thanks, > Agreed, I'm not really sure why its failing, because its in happening the lower layers. Anyways thanks for the comments and review! Regards,