From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932684AbcI3Lx0 (ORCPT ); Fri, 30 Sep 2016 07:53:26 -0400 Received: from mail-by2nam03on0079.outbound.protection.outlook.com ([104.47.42.79]:39840 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932311AbcI3LxS (ORCPT ); Fri, 30 Sep 2016 07:53:18 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH 1/3] drm/radeon: add missing header dependencies To: Baoyou Xie , , References: <1475223183-19698-1-git-send-email-baoyou.xie@linaro.org> CC: , , , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Fri, 30 Sep 2016 13:52:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475223183-19698-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:88fc:ef2c:682f:68c5] X-ClientProxiedBy: AM4PR02CA0010.eurprd02.prod.outlook.com (10.165.239.148) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-Office365-Filtering-Correlation-Id: 9dd6a251-f8bd-4a8f-5fbc-08d3e9284b1e X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;2:xOW1DSsI27euar6F8Y1NnfVlAqvl8nDZOZ3+oiu32bXf7QWOSKUEztAO+doqa02MdFckDEHwctrRC6DsVZDbBUY2yLuaLzl2G7w2dzoRaBA5n2YPjiVQAQl0RW3LtJhDPONCaRx2cRITGRtcd0MGfxrAfsaYGYUU3wD9eGf4iLgmG4Darsfs65kBbQYL+Z7N;3:orilU+B7LTZr1jVpu3pbIlamR/t136FV17harY7ztOr0zo+hd5bQan8VX/iI8P1VJACdCmGw+tkDVXtSZ28GZLRpQxGskiVP6EV9paiE6yygPdXE7OZY8X2P8TJD38P1;25:UrMQKE1PrBxokkcjNl+74VZswfn3d7e1QHN3ZlZX1KNzhVSd66t6YiHHIsf93Q7BXo7i7YftUwsNV99E8CElQDDYeCOWcl2Z5MKywJS9jjieCaRv1loZ8aiUlZdeAGjJwbqBhBsnPlyHdMzHFI0snAjm2O7cqYHSvsetmGeRX4eY/J5z0Otl3EnA0IQYxEXUq4KFFS8sfzUxLKJjNN9qa4ydmAXO0r6VUSHa8L7Xb6nqwlyvrgpsdofPDXMb0fK1y3oCvA/cvjOrPDcL43YqVteaDL1bi8HKIk5EaWlYPo92YS9RPnEap1NUuEmc+Dw60lNxgE0qeQJvscAPL6zwD5XGJOcA/iS/oGDX0Ww43QPd+NopLkEK13+I8FJSPbjAKIvfqNvNaTuntnkYd9tbiajy2xmqDOPZFiYxB1kNDMA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;31:3pRIf+NteRhHUjxviniuLlYX67B+JXmDwM/vYKdtae3QxmDW7hKzEKy6LaaaFV03j7VjeEgbVJcOSC+6ZpDJocm3/w479B7w74p3VHByWcoQ5u5MwMQdWYBixzAzmXwmqJzR/jh3X3S1JZqTSSUlorkQbUXxoQnWVzd3WlF7u6HSUQ3H2y0sH8f2TPbOg3LVpfzXRaFw9BadIR31bAxUz8ENZ/u92v7CdAeMFhTWYB4=;20:ucdDws/LtMLgqwQXGEa3lBAMh1xb5g93Q80/IQAFvbv5Rjp8J0ALKB6FtoZASDsNvHdDmshwenxRAVzKp6eHalQx6qAFqUOZ+EpWU1vozo7ckc+LHBFzhoA9MbkpVsp50T4FLwgJCxNAUKVSYg+qwv2CngZtvzqrn2kvvpKzxPsYwwzDbp+mEX30GnyyFBKIubnJ5a3c98AJztiim7lETMA3UnL0WKbfLF2cvSBWGSUVFjgiRBSch3aAwaYF8z9du9fs6QM/CgSUlnwOrKN1UZKSZd6YTcXvi+OvIyUQjEnDHXqVN/u23wqkbt10PN7WdoNbjKVFdxYjMWgc3DGa1/IeaWsgZ5wiXC1I3lpt9qtiKso7xhscF0gosdRIo0zqFUG5RndombEMYPKPOTS4ViNa+2znWjkc5x3dXglI5voRmcsTSSgOZtS7E8x1C6VSaX0uNVrE9TO01GfGWzYBLELpwtXwVS4YttKOs73j7d9CfJLBV0gvCSY8ToFGeyLC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;4:itgX7RA9nghnLu61uDGykco0f+qNUsy5KvXALw3YnBfJj+qLf2YvboOQ7YSJ376ZcFbF0QyJVSs7zf+TVckUBMoDF4ZsNVP2uZXow6t/RARzbRL+xXTdoAFwUxX6VLQvyEJ/qLkb7ljB8qF60Oe64x93I0wGvFbTH7iGRK7g+K3SSysRnaC7Cj9gEBjrkz3XGE6PC89y4FaAOq1MrxQg9DJ1NUaTcRqlrYx+yaoP5Oki8eVFTl3Yl8VbPBX5oEcGta/MDN2AbHdZW8xN5/sAxWJ47YfZICRf54flHxHD7j/lBv+L5eTWzJJwgkWPh2wD8c1vy/jdJH6n49hhIGDM6pEeje3rShP2ZTmz5wRKhBzg56bXp9Ah07gDiH9BqxULKq2X7RnmAhNCcs++YOvjCJSJ5OhRDDYffAsw59yQlsOaDB7ye3aVA75uuQhFPtJl X-Forefront-PRVS: 008184426E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(2201001)(47776003)(5001770100001)(54356999)(76176999)(50986999)(7846002)(101416001)(92566002)(65956001)(65806001)(97736004)(68736007)(77096005)(2950100002)(7736002)(23756003)(6666003)(5660300001)(81166006)(81156014)(305945005)(8676002)(4326007)(2906002)(1706002)(83506001)(189998001)(6116002)(19580405001)(19580395003)(33646002)(86362001)(31696002)(586003)(106356001)(4001350100001)(31686004)(105586002)(2870700001)(42186005)(36756003)(64126003)(50466002)(65826007)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:88fc:ef2c:682f:68c5];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;BN6PR12MB1298;23:YnRA7/ttblZDWlFTjfB5n4d3LLfmCMh+iBQ+9W?= =?iso-8859-15?Q?bNrfVn7+t4WvA82/MzloKtgMbSckIwipxxiKRbBBWRBBix/NYBBoAyvVw?= =?iso-8859-15?Q?xXxB4d6zqdiK6autE2akb+dJCl0Mq3pKaFEgLKhrVZ6AiZtcPoyqAewkr?= =?iso-8859-15?Q?p1uBGY6/rJwe1sJdCQkAnVgFpVwgLeOEPhZqbC79wF3lTZjSF1I7T9TAB?= =?iso-8859-15?Q?ONhAjPc4NMeMvQmtcMGs92DEu5bTuaI4ynLugUkIcexxskzKE48XazAp7?= =?iso-8859-15?Q?SG+56x5z/3xOQkCJgd5YRitCFmzsu/qxhkPz56b/wlsdpXCI+PCtXhipD?= =?iso-8859-15?Q?tNi/QK9TiSlZDLjtJtSrUDHn+lBkZEVamcIc2gf/1rJg9+UfE6KAxQ1yk?= =?iso-8859-15?Q?Xry63/EIcvkm+nhKR0Z1d6LZLurunpcqzHLhOw90SmD89SvNpwpDYBP1d?= =?iso-8859-15?Q?6wYySZVNpwV5bsAe5d5O3Ye3Th2ISZzU2Gf+22yTBVEREHiHiTvrUv8bi?= =?iso-8859-15?Q?tpc9sAaOZhiIHfjlsurpfph6wxx7RcgMW9gNKOGrlbn33GSOTVkDJWWws?= =?iso-8859-15?Q?SOqpx6pVaB9iyB+bb7+EhU4gy55qaUgGHhehLrXBcRDeq/89rtaLxMYTM?= =?iso-8859-15?Q?+iDKqreQQygiwXaLORFJAbWKUyjhuqU2lANMj1Tzh/v2vZZcKuJYH8sXb?= =?iso-8859-15?Q?hshRGVAwgyGNxeNZy6It2/T5js1DKpTY23G2R71p3iyqpNMwuzOaqwC2G?= =?iso-8859-15?Q?iSmu21XYFdBtDUQzKZDT3YsEggkzYIlu+Iq6J2tXvz2sD7AC0uqfODF0g?= =?iso-8859-15?Q?Heqlw2CZI69Pqh9gdOh0G2uo0FAXFJvtrpJQcxXn5szhILdZkgXE013qJ?= =?iso-8859-15?Q?kemC6x7+8CShBSEbrg1QQKWX5zAX7H7ywOhUyREffRo+O5jAnKgsNQT1e?= =?iso-8859-15?Q?RM/8dlSdiB2ONYhxeiLp5FBqwTGXheUeMs21UYBss1ZLywBAZvJh9sNNi?= =?iso-8859-15?Q?pEx/fevaN6L9/fF6ZyuMlllumVXlvoJ1BDVZwVOzJFdQWJCJFx9on3W1o?= =?iso-8859-15?Q?FVT1xWyYm/556ekKIFEnR2dfsHdUFRLuZaHPNCUI0dPGcxZJGPnwws2f9?= =?iso-8859-15?Q?LZNnCzYo0p4qIXmlOvBeB0SX+sfIS328MS28s1IaYGfP1EREv08k+8ZWx?= =?iso-8859-15?Q?xvCQ1CYDVjBonT7wRPxeO1shkfMA9OfV5yDZy9KRHEWCeFamERrIPhjTb?= =?iso-8859-15?Q?OQXcsBOcou/0axIE0+5Hf/IUfzmk51geZuIMUINDlb/eaupR24fXtgAar?= =?iso-8859-15?Q?D9R7PrrxqMllSfqngERJi7keful9QHBUPNw/b0d7aqhzFos3GkZJ7evKi?= =?iso-8859-15?Q?SSygqLNcAg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:3PsSGjq4TJZmAvH5uMtjaG7uNcXNCPuG6KD6PSA3S4XpQnx7Lw9S8wp9uZdWSlXGQRy44nbMFwWZjN/VQXzsaBjOQgNZWC7OfUwCvSZ8ksASrP9mQQ4SjRzQfRx46m6M1VZZbWGfDmaWpkI88rO+z3Wf9Uzl0xUrm+YHcroOm7XzP331n1I2tagfcvgkU+JxztnjKp6SiO2vPf3Z0BM5dM+EKAvQyqGNjmc9Q/LC/Sg3pku2FEadB1UG0UjQwlj6iSXkNar/zEJzLg7zIgTvI+w2AFfjq5+D4IAHd1R3Ogk/Tv0ST+GvbV7dA6/rj8gB73Ah2aJlXmmbtFdRyY/HUQ==;5:am97Q1nM2U6dYRMHAYbQGVp+XyYpTzmfsXKIfErLC+Mpu8PDYM13GYHUO65woo1KBY7JoShCLYkJbPPZrTHDUDRtKK/IjsPWgAzCpz4/p4cGFiJ8Osi8wgE+pvTUy1QbOHTlnSl7mP8GgI/8tM+JuA==;24:s/Qqv3gWKZbpGWjJsZK+k6WAH1xyw4FCxmyd78cWN2McJT+apY8KE6vSWB92YTbBsaXwjVQ39mKCt/CeGKyLfJwVG+mTMY5ROGH7j2nxCP4=;7:uqyrNIFe5Bsj3/rl94jtIEuy1j1SWutu0o5riqLetQsTR421KvjPdjBQtP+n7RlqA3ByKOnsq6CEj72/s47rL60t+6GD1Uq7xxLM8c1tiZC2a4Fep5wXDdp0c9dkR8D84EWtOG7/SViRjFEtl0Fn5U/ulS8INUL+u9NzZ12hou9Pia/9pgON1/TCqsn5zlSzTBCTNcPbIK0ARKtEsAiFq8IXJZijKmfW1tkkgZFoY10GyUhvbVxzjk3GniG8uAED4HYSGM26Xa++p4hPObtDkUWqEdDdf1K5xQEx7xqntm5SLOIYBv4UPt+MrT9p+x+b SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:k+A1WnCd/yAtukVk/8nhj6aHVsm3t/ssq8idEzX50cvb4PrwbbDXYC/Mub+w0PnQ45dmSPnh13Rs+nGYkqZO7L92Y93fSQkj5yz7pJIDJMwtUeZrHJxqp7/3h3/sDFtMEk+Df26eqvBytbdHDjxcBFHNLdcFI7pXxfaZSLjJET2iUMIVA17lUrTMSWO6JPgTRzK6ltV+NN5xkCpKCI98vsPHw/vGbBiZmbc+9GO0O9e7z6qe5W4+dKpmsbrdFR78 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2016 11:52:44.4236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This one and patch #3 are Reviewed-by: Christian König . Where is patch #2? That never made it into my inbox. Regards, Christian. Am 30.09.2016 um 10:13 schrieb Baoyou Xie: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/radeon/radeon_clocks.c:35:10: warning: no previous prototype for 'radeon_legacy_get_engine_clock' [-Wmissing-prototypes] > drivers/gpu/drm/radeon/atombios_encoders.c:75:1: warning: no previous prototype for 'atombios_get_backlight_level' [-Wmissing-prototypes] > drivers/gpu/drm/radeon/r600_cs.c:2268:5: warning: no previous prototype for 'r600_cs_parse' [-Wmissing-prototypes] > drivers/gpu/drm/radeon/evergreen_cs.c:2671:5: warning: no previous prototype for 'evergreen_cs_parse' [-Wmissing-prototypes] > .... > > In fact, these functions are declared > in drivers/gpu/drm/radeon/radeon_asic.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/radeon/atombios_encoders.c | 1 + > drivers/gpu/drm/radeon/evergreen_cs.c | 1 + > drivers/gpu/drm/radeon/r600_cs.c | 1 + > drivers/gpu/drm/radeon/radeon_atombios.c | 1 + > drivers/gpu/drm/radeon/radeon_clocks.c | 1 + > drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c > index 56bb758..fa4f8f0 100644 > --- a/drivers/gpu/drm/radeon/atombios_encoders.c > +++ b/drivers/gpu/drm/radeon/atombios_encoders.c > @@ -28,6 +28,7 @@ > #include > #include "radeon.h" > #include "radeon_audio.h" > +#include "radeon_asic.h" > #include "atom.h" > #include > > diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c > index d960d39..f8b0509 100644 > --- a/drivers/gpu/drm/radeon/evergreen_cs.c > +++ b/drivers/gpu/drm/radeon/evergreen_cs.c > @@ -27,6 +27,7 @@ > */ > #include > #include "radeon.h" > +#include "radeon_asic.h" > #include "evergreend.h" > #include "evergreen_reg_safe.h" > #include "cayman_reg_safe.h" > diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c > index b69c8de..595a197 100644 > --- a/drivers/gpu/drm/radeon/r600_cs.c > +++ b/drivers/gpu/drm/radeon/r600_cs.c > @@ -28,6 +28,7 @@ > #include > #include > #include "radeon.h" > +#include "radeon_asic.h" > #include "r600d.h" > #include "r600_reg_safe.h" > > diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c > index 5df3ec7..4134759 100644 > --- a/drivers/gpu/drm/radeon/radeon_atombios.c > +++ b/drivers/gpu/drm/radeon/radeon_atombios.c > @@ -29,6 +29,7 @@ > > #include "atom.h" > #include "atom-bits.h" > +#include "radeon_asic.h" > > extern void > radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, > diff --git a/drivers/gpu/drm/radeon/radeon_clocks.c b/drivers/gpu/drm/radeon/radeon_clocks.c > index 38e396d..c1135fe 100644 > --- a/drivers/gpu/drm/radeon/radeon_clocks.c > +++ b/drivers/gpu/drm/radeon/radeon_clocks.c > @@ -29,6 +29,7 @@ > #include > #include "radeon_reg.h" > #include "radeon.h" > +#include "radeon_asic.h" > #include "atom.h" > > /* 10 khz */ > diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > index 868c3ba..222a1fa 100644 > --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > @@ -27,6 +27,7 @@ > #include > #include > #include "radeon.h" > +#include "radeon_asic.h" > #include "atom.h" > #include > #ifdef CONFIG_PMAC_BACKLIGHT