From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D280A2C027C for ; Thu, 26 Feb 2026 13:44:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772113450; cv=none; b=AM0YfhJO0f37V6TeGefztkcAk/0V8YDYpUfNFWfqSm6Ladas8inutJuNKVLUuq+GsYWNEOwQDoFf0KzPckB85fnqFAXDSO44fOMAUr+TOidGrKNOcPRHTkkiBZpQk6YQZSwIqo/cwrMrdZdQ21DOGWfbgCoqGrgD5jzqHccZCFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772113450; c=relaxed/simple; bh=gYACJLn3/0GZSiDl9hZ0qOJ1DMoWtAfWBCr6MWFZTqM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kyFFJWgAS59Ptofw+XT102Uf9GwKbTy4sCk4qGBPyHqq/Q5McRroij2Dwb1nmAGVXGkpClB3WFtsBVxq2ELXKBzQJQKHNFbStM+u0TUrdidfLm1+1uSm+a/mdBH8WV/i/53Pv3zIbHiacYvqtBhUJpJ6NdcYZVnOMSDfO/jPqF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TUGBuzDP; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TUGBuzDP" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4806fd9033bso1822755e9.3 for ; Thu, 26 Feb 2026 05:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772113444; x=1772718244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RiW9GHemN6Ann66iA0XbJEcnWOl2O4mI5KnopxyGsJg=; b=TUGBuzDPnS5sqEqtfQ+EAnxTogsw/t+YZtVmDG/HrwWHCq7j+R4zYzBeTSb20KL9hT khffNIFWqnKzdHY9UAh13yCHtjA+u4+ymOejC6PFjDn5gLDX8zT2o+wmzgjmoZ/44EVK 9tWzpHd074Q0wzOqwqe6r8tuWkQWmG37xHb6FfrwptotAyxC7eTVE4kISnP5E6Rb0V0D mVrfJ9KMRDHWp0/ghS/fx+SFacIzfFdXrdtF+3MQepvPeqPT/fxO7QvWlXylsZZ61k2G 3sq5W63DVJYr//3s8n2Vea+nGm0vivOmyJfhCOeSTKdzcV1HSbI9AsO/+EoUaOEWPtb/ SSDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772113444; x=1772718244; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RiW9GHemN6Ann66iA0XbJEcnWOl2O4mI5KnopxyGsJg=; b=FtVTWVK6Kgt6hKHQ4Xl/MNM/P0Xm6mGAGFjSXkwp/0u5VkyYWHOx3DnF/HfduLocLn k1LesTX1mx0oWuJALahPnVugalwtNnvvXBODl9alEL5RVz+VK/K/UmcHTwlL2s8Czbkw 4UwPWhpYYGjZyfesb968FHRrIa+2svq0toSN+sRRph5gPNoXUmXkyBLXCe0fEtPs9z5k wXlCQkcKDJp2SviT7o7FQPFNL8UEAguuFP/JjvTwT1h0ofwTzUYFFqmKtnAH0TrdzlmA FDtycG/QTGAerzBDKuwqJuJYEE3yqVhvSXXFPeqndK/FUMnU6YHUNC5DLDX4aWytWWDN jx0w== X-Forwarded-Encrypted: i=1; AJvYcCUcimJ5PbAO5Qfy0Yi7Q+nnpV6rD5S9de2S5ZohykTe+lyqUXbJuUYVasjak8BvH+0HAP34960Bm6I0eVw=@vger.kernel.org X-Gm-Message-State: AOJu0YzHA9B17lPfm3ivR3rXNzfHvJn7W0b2CbChkn1wSCsS7OxDc/Ad 0l1ClCKE2NY4WZ9K58/8Op7wiEINvykuFMcWJNMbgwmE0JpyMWsBTUZ5nnpwPNjarPObcVV64Lx JDjDPijcNLA== X-Gm-Gg: ATEYQzzyImnkX/FJdC/S9WsI+i6ZutwZQK8+RVDoziMhSnUChGmchHNIFSM3D/kmGu0 9zkp/bxb1xBJMfJT/OV8Bi7vrIzXEvXf8EkWJATexYSu/ms6VsPwsQoTl/4Wkts7xv6sQx3Rv0e tiZkhIxEwbfXdDee2cpgu2a8XqD3fTpW49YQ05XxMyEmb+zg/qkBr4SjSVTTdSM9tNSIHCPbbjE ZurGr7Zb8DgOZr3UHF036J7CoxP21j3yFUGg3uKpeJf93bY66YBpsUVEhD/sV3wgd1lsBJ3kwge 0Zx+2QUp/mwh807s6kJl/XOuV4ponIzzhbE6sWAaZn2O4706SeaKaX54PXeFOvc6eAUefbP445I p36PRkRS+sa32RyMA/hvHMEwFOCn/8YFUexZ6seI/grvXtvArManCIsmIbspLFI9+S9Wb60vwAA RgPUo1UgOeSdOJxkUgjL3lb4boxna5NDDUBGuNI8GU7eQaV1vDEVIRm72rwU8SZNEXl8LF X-Received: by 2002:a05:600c:34cb:b0:477:a16e:fec5 with SMTP id 5b1f17b1804b1-483a9555ad9mr192713905e9.0.1772113444133; Thu, 26 Feb 2026 05:44:04 -0800 (PST) Received: from ?IPV6:2001:1a48:8:903:1ed6:4f73:ce38:f9d4? ([2001:1a48:8:903:1ed6:4f73:ce38:f9d4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd6f3124sm141938035e9.1.2026.02.26.05.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Feb 2026 05:44:03 -0800 (PST) Message-ID: Date: Thu, 26 Feb 2026 14:44:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] memcg: fix slab accounting in refill_obj_stock() trylock path Content-Language: en-US To: Shakeel Butt , Hao Li Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, vbabka@suse.cz, harry.yoo@oracle.com, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260226115145.62903-1-hao.li@linux.dev> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/26/26 14:39, Shakeel Butt wrote: > On Thu, Feb 26, 2026 at 07:51:37PM +0800, Hao Li wrote: >> In the trylock path of refill_obj_stock(), mod_objcg_mlstate() should >> use the real alloc/free bytes (i.e., nr_acct) for accounting, rather >> than nr_bytes. >> >> Fixes: 200577f69f29 ("memcg: objcg stock trylock without irq disabling") >> Cc: stable@vger.kernel.org >> Signed-off-by: Hao Li > > Thanks for the fix. > > Acked-by: Shakeel Butt What are the user-visible effects of the bug?